| Message ID | 20210929075437.12985-1-lulu@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | vhost-vdpa:fix the worng input in config_cb | expand |
On Wed, Sep 29, 2021 at 03:54:37PM +0800, Cindy Lu wrote: > Fix the worng input in for config_cb, > in function vhost_vdpa_config_cb, the input > cb.private was used as struct vhost_vdpa, > So the inuput was worng here, fix this issue > > Signed-off-by: Cindy Lu <lulu@redhat.com> Maybe add Fixes: 776f395004d8 ("vhost_vdpa: Support config interrupt in vdpa") and fix typos in the commit log. > --- > drivers/vhost/vdpa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c > index 942666425a45..e532cbe3d2f7 100644 > --- a/drivers/vhost/vdpa.c > +++ b/drivers/vhost/vdpa.c > @@ -322,7 +322,7 @@ static long vhost_vdpa_set_config_call(struct vhost_vdpa *v, u32 __user *argp) > struct eventfd_ctx *ctx; > > cb.callback = vhost_vdpa_config_cb; > - cb.private = v->vdpa; > + cb.private = v; > if (copy_from_user(&fd, argp, sizeof(fd))) > return -EFAULT; > > -- > 2.21.3
On Wed, Sep 29, 2021 at 4:32 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > On Wed, Sep 29, 2021 at 03:54:37PM +0800, Cindy Lu wrote: > > Fix the worng input in for config_cb, > > in function vhost_vdpa_config_cb, the input > > cb.private was used as struct vhost_vdpa, > > So the inuput was worng here, fix this issue > > > > Signed-off-by: Cindy Lu <lulu@redhat.com> > > Maybe add > > Fixes: 776f395004d8 ("vhost_vdpa: Support config interrupt in vdpa") > > and fix typos in the commit log. > thanks Michael, I will post a new version > > --- > > drivers/vhost/vdpa.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c > > index 942666425a45..e532cbe3d2f7 100644 > > --- a/drivers/vhost/vdpa.c > > +++ b/drivers/vhost/vdpa.c > > @@ -322,7 +322,7 @@ static long vhost_vdpa_set_config_call(struct vhost_vdpa *v, u32 __user *argp) > > struct eventfd_ctx *ctx; > > > > cb.callback = vhost_vdpa_config_cb; > > - cb.private = v->vdpa; > > + cb.private = v; > > if (copy_from_user(&fd, argp, sizeof(fd))) > > return -EFAULT; > > > > -- > > 2.21.3 >
diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index 942666425a45..e532cbe3d2f7 100644 --- a/drivers/vhost/vdpa.c +++ b/drivers/vhost/vdpa.c @@ -322,7 +322,7 @@ static long vhost_vdpa_set_config_call(struct vhost_vdpa *v, u32 __user *argp) struct eventfd_ctx *ctx; cb.callback = vhost_vdpa_config_cb; - cb.private = v->vdpa; + cb.private = v; if (copy_from_user(&fd, argp, sizeof(fd))) return -EFAULT;
Fix the worng input in for config_cb, in function vhost_vdpa_config_cb, the input cb.private was used as struct vhost_vdpa, So the inuput was worng here, fix this issue Signed-off-by: Cindy Lu <lulu@redhat.com> --- drivers/vhost/vdpa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)