| Message ID | 20211013102722.17160-2-frankja@linux.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | s390x: Cleanup and maintenance 3 | expand |
On Wed, 13 Oct 2021 10:27:21 +0000 Janosch Frank <frankja@linux.ibm.com> wrote: > Somehow the ";" got into that patch and now complicates compilation. > Let's remove it and put the constant in braces. ouch Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com> > > Signed-off-by: Janosch Frank <frankja@linux.ibm.com> > --- > lib/s390x/asm/arch_def.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/s390x/asm/arch_def.h b/lib/s390x/asm/arch_def.h > index b34aa792..40626d72 100644 > --- a/lib/s390x/asm/arch_def.h > +++ b/lib/s390x/asm/arch_def.h > @@ -53,7 +53,7 @@ struct psw { > #define PSW_MASK_PSTATE 0x0001000000000000UL > #define PSW_MASK_EA 0x0000000100000000UL > #define PSW_MASK_BA 0x0000000080000000UL > -#define PSW_MASK_64 PSW_MASK_BA | PSW_MASK_EA; > +#define PSW_MASK_64 (PSW_MASK_BA | PSW_MASK_EA) > > #define CTL0_LOW_ADDR_PROT (63 - 35) > #define CTL0_EDAT (63 - 40)
On 13/10/2021 12.27, Janosch Frank wrote: > Somehow the ";" got into that patch and now complicates compilation. > Let's remove it and put the constant in braces. > > Signed-off-by: Janosch Frank <frankja@linux.ibm.com> > --- > lib/s390x/asm/arch_def.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/s390x/asm/arch_def.h b/lib/s390x/asm/arch_def.h > index b34aa792..40626d72 100644 > --- a/lib/s390x/asm/arch_def.h > +++ b/lib/s390x/asm/arch_def.h > @@ -53,7 +53,7 @@ struct psw { > #define PSW_MASK_PSTATE 0x0001000000000000UL > #define PSW_MASK_EA 0x0000000100000000UL > #define PSW_MASK_BA 0x0000000080000000UL > -#define PSW_MASK_64 PSW_MASK_BA | PSW_MASK_EA; > +#define PSW_MASK_64 (PSW_MASK_BA | PSW_MASK_EA) Reviewed-by: Thomas Huth <thuth@redhat.com>
diff --git a/lib/s390x/asm/arch_def.h b/lib/s390x/asm/arch_def.h index b34aa792..40626d72 100644 --- a/lib/s390x/asm/arch_def.h +++ b/lib/s390x/asm/arch_def.h @@ -53,7 +53,7 @@ struct psw { #define PSW_MASK_PSTATE 0x0001000000000000UL #define PSW_MASK_EA 0x0000000100000000UL #define PSW_MASK_BA 0x0000000080000000UL -#define PSW_MASK_64 PSW_MASK_BA | PSW_MASK_EA; +#define PSW_MASK_64 (PSW_MASK_BA | PSW_MASK_EA) #define CTL0_LOW_ADDR_PROT (63 - 35) #define CTL0_EDAT (63 - 40)
Somehow the ";" got into that patch and now complicates compilation. Let's remove it and put the constant in braces. Signed-off-by: Janosch Frank <frankja@linux.ibm.com> --- lib/s390x/asm/arch_def.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)