From patchwork Wed Nov 10 22:07:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brijesh Singh X-Patchwork-Id: 12613361 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC91FC433FE for ; Wed, 10 Nov 2021 22:09:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A978A6137F for ; Wed, 10 Nov 2021 22:09:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233801AbhKJWMX (ORCPT ); Wed, 10 Nov 2021 17:12:23 -0500 Received: from mail-co1nam11on2083.outbound.protection.outlook.com ([40.107.220.83]:51680 "EHLO NAM11-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S233834AbhKJWLP (ORCPT ); Wed, 10 Nov 2021 17:11:15 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hDc9xQEqAwsJe030mVemq23OsVxdRis0p5XW3BB7K/OWCk581/PMOo5Iwd7DXMSwe1cPCLcqmjSGjVisHgN9S6EDUANdrYkU7pQ9+osiLTq8WhOB07VaImkiNBBkR71zP+5Uc0awuH59P7/9EI8PbZ6nfjhy3KQtrO5eCL7J7FKDyexv4gPzWUhgMEB6nRvMcvATZ8znSRiKd6vgwJX37AA9e6dDwL03o8evcRk8hgsAkRTxlB+HuLpOxhhJv9XOoaqLWfKSi7QRosFTX9r37AjWVpRt43XY9mlu17nHot3vDaasF4oII5FhnYe/k2Nvg2zvzbfvFSZeh6UM4nQrIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=in8gFxI5n/gAj8CDMwfHtQh52d6CxTjBogMQ9ZwR7ns=; b=PwLdDo6872I1kWVytxjZj5ErbNhOwfWe8Lv6qYvFLMwLpdINXWwYzp4pWq8thNhQgxmNw6LU0qJyqeTYMdl6L7+PuWjHQ0UoQmXZTAJ5apPWaD3XvZmw+0eE6NrnQ0r2MFT/dciYK3aJ81yJeK593KfbvTt0k7WX7hQY40nVqPybVMA4B+nDtebtGRmY5to57DlEPC7jl1XL1+MLAl0dxU7/wxHXBSD0arO5tJXynCbo0zg8+UmPfvVryLj86W3c0+W3y3mneNx2EmoWbSIYNiwQuldZQbWa/fNmVyVcfPvlArI1JH3IQKUEyzETk0s5na+4osV3JGzpFMcv5f5waw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=in8gFxI5n/gAj8CDMwfHtQh52d6CxTjBogMQ9ZwR7ns=; b=Ieg3FBD/WQwIHklHXO5yHl6SGfAToUOn4eK2T1cVSLK9Hh8Y98sXkqgt93M+523yT1lvBUJasZ0SFCa8FrL01yoQcX5RKWlRgKFjt819ZNyeN56l6MqIPtTcpSM3nMlYT0SHaA58kAyUZwqoh4sOP/Ay6A6ngkXTW1J4cQu3l9U= Received: from DM6PR07CA0131.namprd07.prod.outlook.com (2603:10b6:5:330::19) by BYAPR12MB3479.namprd12.prod.outlook.com (2603:10b6:a03:dc::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Wed, 10 Nov 2021 22:08:21 +0000 Received: from DM6NAM11FT026.eop-nam11.prod.protection.outlook.com (2603:10b6:5:330:cafe::ac) by DM6PR07CA0131.outlook.office365.com (2603:10b6:5:330::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15 via Frontend Transport; Wed, 10 Nov 2021 22:08:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT026.mail.protection.outlook.com (10.13.172.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4690.15 via Frontend Transport; Wed, 10 Nov 2021 22:08:21 +0000 Received: from sbrijesh-desktop.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Wed, 10 Nov 2021 16:08:16 -0600 From: Brijesh Singh To: , , , , , , CC: Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , "Vitaly Kuznetsov" , Jim Mattson , "Andy Lutomirski" , Dave Hansen , Sergio Lopez , Peter Gonda , "Peter Zijlstra" , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Borislav Petkov , Michael Roth , Vlastimil Babka , "Kirill A . Shutemov" , Andi Kleen , "Dr . David Alan Gilbert" , , , , Brijesh Singh Subject: [PATCH v7 15/45] x86/compressed: Register GHCB memory when SEV-SNP is active Date: Wed, 10 Nov 2021 16:07:01 -0600 Message-ID: <20211110220731.2396491-16-brijesh.singh@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211110220731.2396491-1-brijesh.singh@amd.com> References: <20211110220731.2396491-1-brijesh.singh@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9bba4fea-a188-4881-ebe6-08d9a4969b98 X-MS-TrafficTypeDiagnostic: BYAPR12MB3479: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pKWambvDyZKjtRKI14DCfZnHRQ0N2ofhrNjFYJyDh4JZAP+jwQP/MGb+0nisdH1j77UMRLu5VSDwtHvaof2YgzK8coMeYVnYdZzqwhCZYLCcU/WvaFJyvexomK4OaAJRtpf5wPgCdOUlI8k9Z1j25lvajEXlWFWgTTELbgp09T07cd7uBrWq+Z3HpVdazlxHzIwK7qCGY7JSHqQQJs51qsS3OCdGQJixzPOnHLSV0eepQzai8UtUL/O2tqVEz5dKosrjjbvgY4Q01yro87eE0U/h+YsvaNfMUFoBm3EIrVSKM2ZL0NCV3TpYdSmPThc6cIqHpYbQ7HV+IvyeViQOIg0wA2aPDLQ7E4e52ypbw1pC1d/uU7tjWd7b2CFXO69SD5SJS8XgMwhEebS36DiKADpNSDLePCdflBtPXnD13ifziQPfH6QAYqskhfT7CTcQ6vT7fbBe61XGoTO9ef89PNmEXTcC6ZYL/dH7X2NCbd4xCBY/a2zYZtFD9cOIqRBAYAE0sAEa9E+j5BiqUsrhMqXPzU5rEbN2hm/q58NPtaA9he6PE+NlbOT0NGsvRj6D2R1HT+wY+pjE09p1nYdxJwob2L0PUp73FXlcJqMYyimY6fpefghqblcwTp/dGxLqMzdBRSPQydq4b/E4CrRu4x8V6LPaVnWEms+G7314rL0v420ZfL/2XUNzYm7rmuTiCBjheglC/G16Lpt6+Vj6ZgRGM/rSwFLBTtPx1MwZ5y7yrgCNADOm18vkGqcbKW4J X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(81166007)(5660300002)(356005)(186003)(44832011)(6666004)(82310400003)(2616005)(110136005)(8936002)(1076003)(2906002)(316002)(86362001)(36756003)(4326008)(7696005)(426003)(16526019)(8676002)(336012)(47076005)(7416002)(70206006)(26005)(36860700001)(508600001)(7406005)(70586007)(54906003)(2101003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 22:08:21.1326 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9bba4fea-a188-4881-ebe6-08d9a4969b98 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT026.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3479 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org The SEV-SNP guest is required to perform GHCB GPA registration. This is because the hypervisor may prefer that a guest use a consistent and/or specific GPA for the GHCB associated with a vCPU. For more information, see the GHCB specification. If hypervisor can not work with the guest provided GPA then terminate the guest boot. Signed-off-by: Brijesh Singh --- arch/x86/boot/compressed/sev.c | 4 ++++ arch/x86/include/asm/sev-common.h | 13 +++++++++++++ arch/x86/kernel/sev-shared.c | 16 ++++++++++++++++ 3 files changed, 33 insertions(+) diff --git a/arch/x86/boot/compressed/sev.c b/arch/x86/boot/compressed/sev.c index f85094dd957f..fb2f763dfc19 100644 --- a/arch/x86/boot/compressed/sev.c +++ b/arch/x86/boot/compressed/sev.c @@ -217,6 +217,10 @@ static bool do_early_sev_setup(void) /* Initialize lookup tables for the instruction decoder */ inat_init_tables(); + /* SEV-SNP guest requires the GHCB GPA must be registered */ + if (sev_snp_enabled()) + snp_register_ghcb_early(__pa(&boot_ghcb_page)); + return true; } diff --git a/arch/x86/include/asm/sev-common.h b/arch/x86/include/asm/sev-common.h index 1c76b6b775cc..b82fff9d607b 100644 --- a/arch/x86/include/asm/sev-common.h +++ b/arch/x86/include/asm/sev-common.h @@ -57,6 +57,19 @@ #define GHCB_MSR_AP_RESET_HOLD_REQ 0x006 #define GHCB_MSR_AP_RESET_HOLD_RESP 0x007 +/* GHCB GPA Register */ +#define GHCB_MSR_REG_GPA_REQ 0x012 +#define GHCB_MSR_REG_GPA_REQ_VAL(v) \ + /* GHCBData[63:12] */ \ + (((u64)((v) & GENMASK_ULL(51, 0)) << 12) | \ + /* GHCBData[11:0] */ \ + GHCB_MSR_REG_GPA_REQ) + +#define GHCB_MSR_REG_GPA_RESP 0x013 +#define GHCB_MSR_REG_GPA_RESP_VAL(v) \ + /* GHCBData[63:12] */ \ + (((u64)(v) & GENMASK_ULL(63, 12)) >> 12) + /* * SNP Page State Change Operation * diff --git a/arch/x86/kernel/sev-shared.c b/arch/x86/kernel/sev-shared.c index 85b549f3ee1a..b0ed64fc6520 100644 --- a/arch/x86/kernel/sev-shared.c +++ b/arch/x86/kernel/sev-shared.c @@ -75,6 +75,22 @@ static bool get_hv_features(void) return true; } +static void snp_register_ghcb_early(unsigned long paddr) +{ + unsigned long pfn = paddr >> PAGE_SHIFT; + u64 val; + + sev_es_wr_ghcb_msr(GHCB_MSR_REG_GPA_REQ_VAL(pfn)); + VMGEXIT(); + + val = sev_es_rd_ghcb_msr(); + + /* If the response GPA is not ours then abort the guest */ + if ((GHCB_RESP_CODE(val) != GHCB_MSR_REG_GPA_RESP) || + (GHCB_MSR_REG_GPA_RESP_VAL(val) != pfn)) + sev_es_terminate(SEV_TERM_SET_LINUX, GHCB_TERM_REGISTER); +} + static bool sev_es_negotiate_protocol(void) { u64 val;