diff mbox series

[kvm-unit-tests,1/2] unittests.cfg: groups should be space separated

Message ID 20211112133739.103327-2-drjones@redhat.com (mailing list archive)
State New, archived
Headers show
Series Groups are separated by spaces | expand

Commit Message

Andrew Jones Nov. 12, 2021, 1:37 p.m. UTC
As specified in the comment blocks at the tops of the unittests.cfg
files, multiple groups assigned to 'groups' should be space separated.
Currently any nonword character works for the deliminator, but the
implementation may change. Stick to the specs.

Signed-off-by: Andrew Jones <drjones@redhat.com>
---
 README.md         | 2 +-
 arm/unittests.cfg | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Marc Orr Nov. 12, 2021, 3:37 p.m. UTC | #1
On Fri, Nov 12, 2021 at 5:37 AM Andrew Jones <drjones@redhat.com> wrote:
>
> As specified in the comment blocks at the tops of the unittests.cfg
> files, multiple groups assigned to 'groups' should be space separated.
> Currently any nonword character works for the deliminator, but the
> implementation may change. Stick to the specs.
>
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
>  README.md         | 2 +-
>  arm/unittests.cfg | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/README.md b/README.md
> index b498aafd1a77..6e6a9d0429bc 100644
> --- a/README.md
> +++ b/README.md
> @@ -101,7 +101,7 @@ host. kvm-unit-tests provides two ways to handle tests like those.
>       a) independently, `ARCH-run ARCH/test`
>
>       b) by specifying any other non-nodefault group it is in,
> -        groups = nodefault,mygroup : `./run_tests.sh -g mygroup`
> +        groups = nodefault mygroup : `./run_tests.sh -g mygroup`
>
>       c) by specifying all tests should be run, `./run_tests.sh -a`
>
> diff --git a/arm/unittests.cfg b/arm/unittests.cfg
> index f776b66ef96d..945c2d074719 100644
> --- a/arm/unittests.cfg
> +++ b/arm/unittests.cfg
> @@ -232,7 +232,7 @@ arch = arm64
>  [micro-bench]
>  file = micro-bench.flat
>  smp = 2
> -groups = nodefault,micro-bench
> +groups = nodefault micro-bench
>  accel = kvm
>  arch = arm64
>
> --
> 2.31.1
>

Reviewed-by: Marc Orr <marcorr@google.com>
diff mbox series

Patch

diff --git a/README.md b/README.md
index b498aafd1a77..6e6a9d0429bc 100644
--- a/README.md
+++ b/README.md
@@ -101,7 +101,7 @@  host. kvm-unit-tests provides two ways to handle tests like those.
      a) independently, `ARCH-run ARCH/test`
 
      b) by specifying any other non-nodefault group it is in,
-        groups = nodefault,mygroup : `./run_tests.sh -g mygroup`
+        groups = nodefault mygroup : `./run_tests.sh -g mygroup`
 
      c) by specifying all tests should be run, `./run_tests.sh -a`
 
diff --git a/arm/unittests.cfg b/arm/unittests.cfg
index f776b66ef96d..945c2d074719 100644
--- a/arm/unittests.cfg
+++ b/arm/unittests.cfg
@@ -232,7 +232,7 @@  arch = arm64
 [micro-bench]
 file = micro-bench.flat
 smp = 2
-groups = nodefault,micro-bench
+groups = nodefault micro-bench
 accel = kvm
 arch = arm64