Message ID | 20211223222318.1039223-16-seanjc@google.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <kvm-owner@kernel.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9A46C433F5 for <kvm@archiver.kernel.org>; Thu, 23 Dec 2021 22:25:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350506AbhLWWZA (ORCPT <rfc822;kvm@archiver.kernel.org>); Thu, 23 Dec 2021 17:25:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350654AbhLWWYM (ORCPT <rfc822;kvm@vger.kernel.org>); Thu, 23 Dec 2021 17:24:12 -0500 Received: from mail-pg1-x549.google.com (mail-pg1-x549.google.com [IPv6:2607:f8b0:4864:20::549]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 589C0C0617A2 for <kvm@vger.kernel.org>; Thu, 23 Dec 2021 14:24:06 -0800 (PST) Received: by mail-pg1-x549.google.com with SMTP id i8-20020a639d08000000b00340a257c531so3867809pgd.16 for <kvm@vger.kernel.org>; Thu, 23 Dec 2021 14:24:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=reply-to:date:in-reply-to:message-id:mime-version:references :subject:from:to:cc; bh=S9jL8LBJWDSO1EwBcm6bNP8GuX6QWRTMXtWDTQ0GzAo=; b=i1m9kNDo4lVbMKKMJ7noTQCVlV3rFRnpbwW5J7eBAQQPmfGVNRgPfQBPDoRb1Ui5y2 KYxDCaTU2lwHc08gaE/rqtAxLDrTeqm80ZNH7WvWCMyYs81zGzFgowjDFgmU88xrLgLg 2Dvm8rQ52rYuwfXnf2c/wiI2pecS49FLZIgoc7FuwdApv+HH4WEuZVLXy4yGgUFhkmu4 fcYG+xN+po6iQzh/2vHnvyX/C0sYpJhBYfZ/B3szzJakAbN0UAspYVPVp+fnqdqBUxjM 4RqNPN+GELSi2uwFEnKy0QaqslvNHc+0WxfR5F7DJIsZ83D56N3zXV8wlr149IfrojHr x+gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:reply-to:date:in-reply-to:message-id :mime-version:references:subject:from:to:cc; bh=S9jL8LBJWDSO1EwBcm6bNP8GuX6QWRTMXtWDTQ0GzAo=; b=0fGAR7lkxXl5Mris6qiRCKt5E70ViVq7sDYPaEwQ1fHjN42So+R9m7mPoiWxd29g+3 hq5RBIq5lawmoWKdz5d7LzAuI5XopXCcNyBsYeHmHpJ6gcz699gNN6AjdX9Xu6Btt2c1 /5371C+w7qQGC0p7kcNTo8wSeEXoBsD5niEPSoYwyr+gJ26BWfbp85zqKvjTN1U5m2O0 3Ess/st6ItDxuqUjZfgzTaTOBBIlCA9Qm3Pu3o+iobDpsRyks2Wm9qA5j0lIQ2ucdhi8 DbSfoknJMzmWIkTEPG6EfETSgJfPhh4egx6S/urEm+rBXzapukeOAAaMkzrStmK+zBhh rd8A== X-Gm-Message-State: AOAM532SSWpAesfV+iWE5on/k5gc94q+K2KyGxazDk0FSWLhCWWo7a5x W5hekQ17BkkC5Jr2nNlRpd25WnS7Dcs= X-Google-Smtp-Source: ABdhPJx4FSrwOTm1Aq60tRpUbAfQrDZRF2v7lCJ9pqZVoyCOxQHrcpb5/oFfRApzth+Q+noEmq2CmgpsFHY= X-Received: from seanjc.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:3e5]) (user=seanjc job=sendgmr) by 2002:a17:90a:c203:: with SMTP id e3mr739899pjt.0.1640298245502; Thu, 23 Dec 2021 14:24:05 -0800 (PST) Reply-To: Sean Christopherson <seanjc@google.com> Date: Thu, 23 Dec 2021 22:23:03 +0000 In-Reply-To: <20211223222318.1039223-1-seanjc@google.com> Message-Id: <20211223222318.1039223-16-seanjc@google.com> Mime-Version: 1.0 References: <20211223222318.1039223-1-seanjc@google.com> X-Mailer: git-send-email 2.34.1.448.ga2b2bfdf31-goog Subject: [PATCH v2 15/30] KVM: x86/mmu: WARN if old _or_ new SPTE is REMOVED in non-atomic path From: Sean Christopherson <seanjc@google.com> To: Paolo Bonzini <pbonzini@redhat.com> Cc: Sean Christopherson <seanjc@google.com>, Vitaly Kuznetsov <vkuznets@redhat.com>, Wanpeng Li <wanpengli@tencent.com>, Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Ben Gardon <bgardon@google.com>, David Matlack <dmatlack@google.com>, Mingwei Zhang <mizhang@google.com> Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: <kvm.vger.kernel.org> X-Mailing-List: kvm@vger.kernel.org |
Series |
KVM: x86/mmu: Overhaul TDP MMU zapping and flushing
|
expand
|
diff --git a/arch/x86/kvm/mmu/tdp_mmu.c b/arch/x86/kvm/mmu/tdp_mmu.c index 41c3a1cff3e7..e2d217cbeca3 100644 --- a/arch/x86/kvm/mmu/tdp_mmu.c +++ b/arch/x86/kvm/mmu/tdp_mmu.c @@ -634,13 +634,13 @@ static inline void __tdp_mmu_set_spte(struct kvm *kvm, struct tdp_iter *iter, lockdep_assert_held_write(&kvm->mmu_lock); /* - * No thread should be using this function to set SPTEs to the + * No thread should be using this function to set SPTEs to or from the * temporary removed SPTE value. * If operating under the MMU lock in read mode, tdp_mmu_set_spte_atomic * should be used. If operating under the MMU lock in write mode, the * use of the removed SPTE should not be necessary. */ - WARN_ON(is_removed_spte(iter->old_spte)); + WARN_ON(is_removed_spte(iter->old_spte) || is_removed_spte(new_spte)); kvm_tdp_mmu_write_spte(iter->sptep, new_spte);