[10/22] KVM: x86: Unexport kvm_x86_ops

Message ID	20220128005208.4008533-11-seanjc@google.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <kvm-owner@kernel.org> Reply-To: Sean Christopherson <seanjc@google.com> Date: Fri, 28 Jan 2022 00:51:56 +0000 In-Reply-To: <20220128005208.4008533-1-seanjc@google.com> Message-Id: <20220128005208.4008533-11-seanjc@google.com> Mime-Version: 1.0 References: <20220128005208.4008533-1-seanjc@google.com> Subject: [PATCH 10/22] KVM: x86: Unexport kvm_x86_ops From: Sean Christopherson <seanjc@google.com> To: Paolo Bonzini <pbonzini@redhat.com> Cc: Sean Christopherson <seanjc@google.com>, Vitaly Kuznetsov <vkuznets@redhat.com>, Wanpeng Li <wanpengli@tencent.com>, Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Like Xu <like.xu.linux@gmail.com> Content-Type: text/plain; charset="UTF-8" Precedence: bulk
Series	KVM: x86: Fill _x86_ops via kvm-x86-ops.h \| expand [00/22] KVM: x86: Fill _x86_ops via kvm-x86-ops.h [01/22] KVM: x86: Drop unnecessary and confusing KVM_X86_OP_NULL macro [02/22] KVM: x86: Move delivery of non-APICv interrupt into vendor code [03/22] KVM: x86: Drop export for .tlb_flush_current() static_call key [04/22] KVM: x86: Rename kvm_x86_ops pointers to align w/ preferred vendor names [05/22] KVM: x86: Use static_call() for .vcpu_deliver_sipi_vector() [06/22] KVM: VMX: Call vmx_get_cpl() directly in handle_dr() [07/22] KVM: xen: Use static_call() for invoking kvm_x86_ops hooks [08/22] KVM: nVMX: Refactor PMU refresh to avoid referencing kvm_x86_ops.pmu_ops [09/22] KVM: x86: Uninline and export hv_track_root_tdp() [10/22] KVM: x86: Unexport kvm_x86_ops [11/22] KVM: x86: Use static_call() for copy/move encryption context ioctls() [12/22] KVM: x86: Allow different macros for APICv, CVM, and Hyper-V kvm_x86_ops [13/22] KVM: VMX: Rename VMX functions to conform to kvm_x86_ops names [14/22] KVM: VMX: Use kvm-x86-ops.h to fill vmx_x86_ops [15/22] KVM: x86: Move get_cs_db_l_bits() helper to SVM [16/22] KVM: SVM: Rename svm_flush_tlb() to svm_flush_tlb_current() [17/22] KVM: SVM: Remove unused MAX_INST_SIZE #define [18/22] KVM: SVM: Rename AVIC helpers to use "avic" prefix instead of "svm" [19/22] KVM: x86: Use more verbose names for mem encrypt kvm_x86_ops hooks [20/22] KVM: SVM: Rename SEV implemenations to conform to kvm_x86_ops hooks [21/22] KVM: SVM: Rename hook implementations to conform to kvm_x86_ops' names [22/22] KVM: SVM: Use kvm-x86-ops.h to fill svm_x86_ops

Message ID

20220128005208.4008533-11-seanjc@google.com (mailing list archive)

State

New, archived

Headers

Reply-To: Sean Christopherson <seanjc@google.com>
Date: Fri, 28 Jan 2022 00:51:56 +0000
In-Reply-To: <20220128005208.4008533-1-seanjc@google.com>
Message-Id: <20220128005208.4008533-11-seanjc@google.com>
Mime-Version: 1.0
References: <20220128005208.4008533-1-seanjc@google.com>
Subject: [PATCH 10/22] KVM: x86: Unexport kvm_x86_ops
From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Like Xu <like.xu.linux@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Series

KVM: x86: Fill *_x86_ops via kvm-x86-ops.h | expand

Commit Message

Sean Christopherson Jan. 28, 2022, 12:51 a.m. UTC

Drop the export of kvm_x86_ops now it is no longer referenced by SVM or
VMX.  Disallowing access to kvm_x86_ops is very desirable as it prevents
vendor code from incorrectly modifying hooks after they have been set by
kvm_arch_hardware_setup(), and more importantly after each function's
associated static_call key has been updated.

No functional change intended.

Signed-off-by: Sean Christopherson <seanjc@google.com>
---
 arch/x86/kvm/x86.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index cc14f79c446c..a8ea1b212267 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -124,7 +124,6 @@  static int __set_sregs2(struct kvm_vcpu *vcpu, struct kvm_sregs2 *sregs2);
 static void __get_sregs2(struct kvm_vcpu *vcpu, struct kvm_sregs2 *sregs2);
 
 struct kvm_x86_ops kvm_x86_ops __read_mostly;
-EXPORT_SYMBOL_GPL(kvm_x86_ops);
 
 #define KVM_X86_OP(func)					     \
 	DEFINE_STATIC_CALL_NULL(kvm_x86_##func,			     \

[10/22] KVM: x86: Unexport kvm_x86_ops

Commit Message

Patch