| Message ID | 20220225012959.1554168-1-jmattson@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | KVM: VMX: Fix header file dependency of asm/vmx.h | expand |
On Thu, Feb 24, 2022, Jim Mattson wrote: > From: Jacob Xu <jacobhxu@google.com> > > Include a definition of WARN_ON_ONCE() before using it. > > Fixes: bb1fcc70d98f ("KVM: nVMX: Allow L1 to use 5-level page walks for nested EPT") > Cc: Sean Christopherson <seanjc@google.com> > Signed-off-by: Jacob Xu <jacobhxu@google.com> > [reworded commit message; changed <asm/bug.h> to <linux/bug.h>] > Signed-off-by: Jim Mattson <jmattson@google.com> > --- > arch/x86/include/asm/vmx.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h > index 0ffaa3156a4e..447b97296400 100644 > --- a/arch/x86/include/asm/vmx.h > +++ b/arch/x86/include/asm/vmx.h > @@ -14,6 +14,7 @@ > > #include <linux/bitops.h> > #include <linux/types.h> > +#include <linux/bug.h> Paolo, any chance you want to put these in alphabetical order when applying? :-) Reviewed-by: Sean Christopherson <seanjc@google.com> > #include <uapi/asm/vmx.h> > #include <asm/vmxfeatures.h> > > -- > 2.35.1.574.g5d30c73bfb-goog >
On Thu, Feb 24, 2022 at 5:32 PM Sean Christopherson <seanjc@google.com> wrote:
> Paolo, any chance you want to put these in alphabetical order when applying? :-)
Alphabetical?!? Not reverse fir tree?
On Thu, Feb 24, 2022 at 5:34 PM Jim Mattson <jmattson@google.com> wrote: > > On Thu, Feb 24, 2022 at 5:32 PM Sean Christopherson <seanjc@google.com> wrote: > > > Paolo, any chance you want to put these in alphabetical order when applying? :-) > > Alphabetical?!? Not reverse fir tree? Any order is fine with me, actually.
On Thu, Feb 24, 2022 at 5:32 PM Sean Christopherson <seanjc@google.com> wrote: > > On Thu, Feb 24, 2022, Jim Mattson wrote: > > From: Jacob Xu <jacobhxu@google.com> > > > > Include a definition of WARN_ON_ONCE() before using it. > > > > Fixes: bb1fcc70d98f ("KVM: nVMX: Allow L1 to use 5-level page walks for nested EPT") > > Cc: Sean Christopherson <seanjc@google.com> > > Signed-off-by: Jacob Xu <jacobhxu@google.com> > > [reworded commit message; changed <asm/bug.h> to <linux/bug.h>] > > Signed-off-by: Jim Mattson <jmattson@google.com> > > --- > > arch/x86/include/asm/vmx.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h > > index 0ffaa3156a4e..447b97296400 100644 > > --- a/arch/x86/include/asm/vmx.h > > +++ b/arch/x86/include/asm/vmx.h > > @@ -14,6 +14,7 @@ > > > > #include <linux/bitops.h> > > #include <linux/types.h> > > +#include <linux/bug.h> > > Paolo, any chance you want to put these in alphabetical order when applying? :-) > > Reviewed-by: Sean Christopherson <seanjc@google.com> > > > #include <uapi/asm/vmx.h> > > #include <asm/vmxfeatures.h> > > Ping.
On Tue, May 16, 2023, Jim Mattson wrote: > On Thu, Feb 24, 2022 at 5:32 PM Sean Christopherson <seanjc@google.com> wrote: > > > > On Thu, Feb 24, 2022, Jim Mattson wrote: > > > From: Jacob Xu <jacobhxu@google.com> > > > > > > Include a definition of WARN_ON_ONCE() before using it. > > > > > > Fixes: bb1fcc70d98f ("KVM: nVMX: Allow L1 to use 5-level page walks for nested EPT") > > > Cc: Sean Christopherson <seanjc@google.com> > > > Signed-off-by: Jacob Xu <jacobhxu@google.com> > > > [reworded commit message; changed <asm/bug.h> to <linux/bug.h>] > > > Signed-off-by: Jim Mattson <jmattson@google.com> > > > --- > > > arch/x86/include/asm/vmx.h | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h > > > index 0ffaa3156a4e..447b97296400 100644 > > > --- a/arch/x86/include/asm/vmx.h > > > +++ b/arch/x86/include/asm/vmx.h > > > @@ -14,6 +14,7 @@ > > > > > > #include <linux/bitops.h> > > > #include <linux/types.h> > > > +#include <linux/bug.h> > > > > Paolo, any chance you want to put these in alphabetical order when applying? :-) > > > > Reviewed-by: Sean Christopherson <seanjc@google.com> > > > > > #include <uapi/asm/vmx.h> > > > #include <asm/vmxfeatures.h> > > > > > Ping. I'll grab this for 6.5 unless Paolo beats me to the punch.
On 2/25/22 02:29, Jim Mattson wrote: > From: Jacob Xu <jacobhxu@google.com> > > Include a definition of WARN_ON_ONCE() before using it. > > Fixes: bb1fcc70d98f ("KVM: nVMX: Allow L1 to use 5-level page walks for nested EPT") > Cc: Sean Christopherson <seanjc@google.com> > Signed-off-by: Jacob Xu <jacobhxu@google.com> > [reworded commit message; changed <asm/bug.h> to <linux/bug.h>] > Signed-off-by: Jim Mattson <jmattson@google.com> > --- > arch/x86/include/asm/vmx.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h > index 0ffaa3156a4e..447b97296400 100644 > --- a/arch/x86/include/asm/vmx.h > +++ b/arch/x86/include/asm/vmx.h > @@ -14,6 +14,7 @@ > > #include <linux/bitops.h> > #include <linux/types.h> > +#include <linux/bug.h> > #include <uapi/asm/vmx.h> > #include <asm/vmxfeatures.h> > Queued, thanks. Paolo
diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h index 0ffaa3156a4e..447b97296400 100644 --- a/arch/x86/include/asm/vmx.h +++ b/arch/x86/include/asm/vmx.h @@ -14,6 +14,7 @@ #include <linux/bitops.h> #include <linux/types.h> +#include <linux/bug.h> #include <uapi/asm/vmx.h> #include <asm/vmxfeatures.h>