| Message ID | 20220405075225.15903-6-frankja@linux.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | s390x: Cleanup and maintenance 4 | expand |
On Tue, 5 Apr 2022 07:52:22 +0000 Janosch Frank <frankja@linux.ibm.com> wrote: > This file has way too much includes. Time to remove some. > > Signed-off-by: Janosch Frank <frankja@linux.ibm.com> Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com> > --- > s390x/pv-diags.c | 17 ++--------------- > 1 file changed, 2 insertions(+), 15 deletions(-) > > diff --git a/s390x/pv-diags.c b/s390x/pv-diags.c > index 6899b859..9ced68c7 100644 > --- a/s390x/pv-diags.c > +++ b/s390x/pv-diags.c > @@ -8,23 +8,10 @@ > * Janosch Frank <frankja@linux.ibm.com> > */ > #include <libcflat.h> > -#include <asm/asm-offsets.h> > -#include <asm-generic/barrier.h> > -#include <asm/interrupt.h> > -#include <asm/pgtable.h> > -#include <mmu.h> > -#include <asm/page.h> > -#include <asm/facility.h> > -#include <asm/mem.h> > -#include <asm/sigp.h> > -#include <smp.h> > -#include <alloc_page.h> > -#include <vmalloc.h> > -#include <sclp.h> > #include <snippet.h> > #include <sie.h> > -#include <uv.h> > -#include <asm/uv.h> > +#include <sclp.h> > +#include <asm/facility.h> > > static struct vm vm; >
On 05/04/2022 09.52, Janosch Frank wrote: > This file has way too much includes. Time to remove some. > > Signed-off-by: Janosch Frank <frankja@linux.ibm.com> > --- > s390x/pv-diags.c | 17 ++--------------- > 1 file changed, 2 insertions(+), 15 deletions(-) > > diff --git a/s390x/pv-diags.c b/s390x/pv-diags.c > index 6899b859..9ced68c7 100644 > --- a/s390x/pv-diags.c > +++ b/s390x/pv-diags.c > @@ -8,23 +8,10 @@ > * Janosch Frank <frankja@linux.ibm.com> > */ > #include <libcflat.h> > -#include <asm/asm-offsets.h> > -#include <asm-generic/barrier.h> > -#include <asm/interrupt.h> > -#include <asm/pgtable.h> > -#include <mmu.h> > -#include <asm/page.h> > -#include <asm/facility.h> > -#include <asm/mem.h> > -#include <asm/sigp.h> > -#include <smp.h> > -#include <alloc_page.h> > -#include <vmalloc.h> > -#include <sclp.h> > #include <snippet.h> > #include <sie.h> > -#include <uv.h> > -#include <asm/uv.h> > +#include <sclp.h> > +#include <asm/facility.h> Wow, how did we end up with that huge list? Copy-n-paste from other files? Reviewed-by: Thomas Huth <thuth@redhat.com>
On 4/6/22 08:50, Thomas Huth wrote: > On 05/04/2022 09.52, Janosch Frank wrote: >> This file has way too much includes. Time to remove some. >> >> Signed-off-by: Janosch Frank <frankja@linux.ibm.com> >> --- >> s390x/pv-diags.c | 17 ++--------------- >> 1 file changed, 2 insertions(+), 15 deletions(-) >> >> diff --git a/s390x/pv-diags.c b/s390x/pv-diags.c >> index 6899b859..9ced68c7 100644 >> --- a/s390x/pv-diags.c >> +++ b/s390x/pv-diags.c >> @@ -8,23 +8,10 @@ >> * Janosch Frank <frankja@linux.ibm.com> >> */ >> #include <libcflat.h> >> -#include <asm/asm-offsets.h> >> -#include <asm-generic/barrier.h> >> -#include <asm/interrupt.h> >> -#include <asm/pgtable.h> >> -#include <mmu.h> >> -#include <asm/page.h> >> -#include <asm/facility.h> >> -#include <asm/mem.h> >> -#include <asm/sigp.h> >> -#include <smp.h> >> -#include <alloc_page.h> >> -#include <vmalloc.h> >> -#include <sclp.h> >> #include <snippet.h> >> #include <sie.h> >> -#include <uv.h> >> -#include <asm/uv.h> >> +#include <sclp.h> >> +#include <asm/facility.h> > > Wow, how did we end up with that huge list? Copy-n-paste from other files? > Yes, and lots of work to get it working in the first place which pulled in headers which weren't removed later once they were unused. That's one of the reasons why I suggested the templates to you :-) > Reviewed-by: Thomas Huth <thuth@redhat.com> Thanks
diff --git a/s390x/pv-diags.c b/s390x/pv-diags.c index 6899b859..9ced68c7 100644 --- a/s390x/pv-diags.c +++ b/s390x/pv-diags.c @@ -8,23 +8,10 @@ * Janosch Frank <frankja@linux.ibm.com> */ #include <libcflat.h> -#include <asm/asm-offsets.h> -#include <asm-generic/barrier.h> -#include <asm/interrupt.h> -#include <asm/pgtable.h> -#include <mmu.h> -#include <asm/page.h> -#include <asm/facility.h> -#include <asm/mem.h> -#include <asm/sigp.h> -#include <smp.h> -#include <alloc_page.h> -#include <vmalloc.h> -#include <sclp.h> #include <snippet.h> #include <sie.h> -#include <uv.h> -#include <asm/uv.h> +#include <sclp.h> +#include <asm/facility.h> static struct vm vm;
This file has way too much includes. Time to remove some. Signed-off-by: Janosch Frank <frankja@linux.ibm.com> --- s390x/pv-diags.c | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-)