diff mbox series

[v2,1/2] KVM: VMX: Guest usage of IA32_SPEC_CTRL is likely

Message ID 20221019213620.1953281-2-jmattson@google.com (mailing list archive)
State New, archived
Headers show
Series KVM: nVMX: Add IBPB between L2 and L1 to | expand

Commit Message

Jim Mattson Oct. 19, 2022, 9:36 p.m. UTC 
At this point in time, most guests (in the default, out-of-the-box
configuration) are likely to use IA32_SPEC_CTRL.  Therefore, drop the
compiler hint that it is unlikely for KVM to be intercepting WRMSR of
IA32_SPEC_CTRL.

Signed-off-by: Jim Mattson <jmattson@google.com>
---
 arch/x86/kvm/vmx/vmx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sean Christopherson Nov. 1, 2022, 7:23 p.m. UTC | #1 
On Wed, Oct 19, 2022, Jim Mattson wrote:
> At this point in time, most guests (in the default, out-of-the-box
> configuration) are likely to use IA32_SPEC_CTRL.  Therefore, drop the
> compiler hint that it is unlikely for KVM to be intercepting WRMSR of
> IA32_SPEC_CTRL.
> 
> Signed-off-by: Jim Mattson <jmattson@google.com>
> ---

Reviewed-by: Sean Christopherson <seanjc@google.com>
diff mbox series

Patch

diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
index 9dba04b6b019..b092f61b8258 100644
--- a/arch/x86/kvm/vmx/vmx.c
+++ b/arch/x86/kvm/vmx/vmx.c
@@ -858,7 +858,7 @@  unsigned int __vmx_vcpu_run_flags(struct vcpu_vmx *vmx)
 	 * to change it directly without causing a vmexit.  In that case read
 	 * it after vmexit and store it in vmx->spec_ctrl.
 	 */
-	if (unlikely(!msr_write_intercepted(vmx, MSR_IA32_SPEC_CTRL)))
+	if (!msr_write_intercepted(vmx, MSR_IA32_SPEC_CTRL))
 		flags |= VMX_RUN_SAVE_SPEC_CTRL;
 
 	return flags;