| Message ID | 20221115111549.2784927-3-tabba@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Use memfd for guest vm memory allocation | expand |
On Tue, 15 Nov 2022 11:15:34 +0000 Fuad Tabba <tabba@google.com> wrote: > This function isn't used outside of util.c. > > No functional change intended. I am not sure if it was once intended to be public, but it's indeed not used outside, and it looks like we lose this function anyway, so: > Signed-off-by: Fuad Tabba <tabba@google.com> Reviewed-by: Andre Przywara <andre.przywara@arm.com> Cheers, Andre > --- > include/kvm/util.h | 1 - > util/util.c | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/kvm/util.h b/include/kvm/util.h > index b494548..b0c3684 100644 > --- a/include/kvm/util.h > +++ b/include/kvm/util.h > @@ -140,7 +140,6 @@ static inline int pow2_size(unsigned long x) > } > > struct kvm; > -void *mmap_hugetlbfs(struct kvm *kvm, const char *htlbfs_path, u64 size); > void *mmap_anon_or_hugetlbfs(struct kvm *kvm, const char *hugetlbfs_path, u64 size); > > #endif /* KVM__UTIL_H */ > diff --git a/util/util.c b/util/util.c > index 1877105..093bd3b 100644 > --- a/util/util.c > +++ b/util/util.c > @@ -81,7 +81,7 @@ void die_perror(const char *s) > exit(1); > } > > -void *mmap_hugetlbfs(struct kvm *kvm, const char *htlbfs_path, u64 size) > +static void *mmap_hugetlbfs(struct kvm *kvm, const char *htlbfs_path, u64 size) > { > char mpath[PATH_MAX]; > int fd;
diff --git a/include/kvm/util.h b/include/kvm/util.h index b494548..b0c3684 100644 --- a/include/kvm/util.h +++ b/include/kvm/util.h @@ -140,7 +140,6 @@ static inline int pow2_size(unsigned long x) } struct kvm; -void *mmap_hugetlbfs(struct kvm *kvm, const char *htlbfs_path, u64 size); void *mmap_anon_or_hugetlbfs(struct kvm *kvm, const char *hugetlbfs_path, u64 size); #endif /* KVM__UTIL_H */ diff --git a/util/util.c b/util/util.c index 1877105..093bd3b 100644 --- a/util/util.c +++ b/util/util.c @@ -81,7 +81,7 @@ void die_perror(const char *s) exit(1); } -void *mmap_hugetlbfs(struct kvm *kvm, const char *htlbfs_path, u64 size) +static void *mmap_hugetlbfs(struct kvm *kvm, const char *htlbfs_path, u64 size) { char mpath[PATH_MAX]; int fd;
This function isn't used outside of util.c. No functional change intended. Signed-off-by: Fuad Tabba <tabba@google.com> --- include/kvm/util.h | 1 - util/util.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-)