| Message ID | 20230203094230.266952-4-thuth@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | KVM: Standardize on "int" return types instead of "long" | expand |
On Fri Feb 3, 2023 at 7:42 PM AEST, Thomas Huth wrote: > The KVM_GET_NR_MMU_PAGES ioctl is quite questionable on 64-bit hosts > since it fails to return the full 64 bits of the value that can be > set with the corresponding KVM_SET_NR_MMU_PAGES call. This ioctl > likely has also never really been used by userspace applications > (at least not by QEMU and kvmtool which I checked), so it's better > to move it to the deprecation section in kvm.h to make it clear for > developers that this also should not be used in new code in the > future anymore. Did this get included in the series inadvertently? Thanks, Nick > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > include/uapi/linux/kvm.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h > index 55155e262646..f55965a4cec7 100644 > --- a/include/uapi/linux/kvm.h > +++ b/include/uapi/linux/kvm.h > @@ -83,6 +83,8 @@ struct kvm_debug_guest { > > #define __KVM_DEPRECATED_VCPU_W_0x87 _IOW(KVMIO, 0x87, struct kvm_debug_guest) > > +#define KVM_GET_NR_MMU_PAGES _IO(KVMIO, 0x45) > + > /* *** End of deprecated interfaces *** */ > > > @@ -1442,7 +1444,6 @@ struct kvm_vfio_spapr_tce { > #define KVM_CREATE_VCPU _IO(KVMIO, 0x41) > #define KVM_GET_DIRTY_LOG _IOW(KVMIO, 0x42, struct kvm_dirty_log) > #define KVM_SET_NR_MMU_PAGES _IO(KVMIO, 0x44) > -#define KVM_GET_NR_MMU_PAGES _IO(KVMIO, 0x45) > #define KVM_SET_USER_MEMORY_REGION _IOW(KVMIO, 0x46, \ > struct kvm_userspace_memory_region) > #define KVM_SET_TSS_ADDR _IO(KVMIO, 0x47) > -- > 2.31.1
On 03/02/2023 11.16, Nicholas Piggin wrote: > On Fri Feb 3, 2023 at 7:42 PM AEST, Thomas Huth wrote: >> The KVM_GET_NR_MMU_PAGES ioctl is quite questionable on 64-bit hosts >> since it fails to return the full 64 bits of the value that can be >> set with the corresponding KVM_SET_NR_MMU_PAGES call. This ioctl >> likely has also never really been used by userspace applications >> (at least not by QEMU and kvmtool which I checked), so it's better >> to move it to the deprecation section in kvm.h to make it clear for >> developers that this also should not be used in new code in the >> future anymore. > > Did this get included in the series inadvertently? No, it's here on purpose, as a second step to patch 2/7 (and a follow up from the discussion last year, see https://lore.kernel.org/kvm/YpZu6%2Fk+8EydfBKf@google.com/ ) ... sorry, I should have elaborated on this in the cover letter, too. Thomas
diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h index 55155e262646..f55965a4cec7 100644 --- a/include/uapi/linux/kvm.h +++ b/include/uapi/linux/kvm.h @@ -83,6 +83,8 @@ struct kvm_debug_guest { #define __KVM_DEPRECATED_VCPU_W_0x87 _IOW(KVMIO, 0x87, struct kvm_debug_guest) +#define KVM_GET_NR_MMU_PAGES _IO(KVMIO, 0x45) + /* *** End of deprecated interfaces *** */ @@ -1442,7 +1444,6 @@ struct kvm_vfio_spapr_tce { #define KVM_CREATE_VCPU _IO(KVMIO, 0x41) #define KVM_GET_DIRTY_LOG _IOW(KVMIO, 0x42, struct kvm_dirty_log) #define KVM_SET_NR_MMU_PAGES _IO(KVMIO, 0x44) -#define KVM_GET_NR_MMU_PAGES _IO(KVMIO, 0x45) #define KVM_SET_USER_MEMORY_REGION _IOW(KVMIO, 0x46, \ struct kvm_userspace_memory_region) #define KVM_SET_TSS_ADDR _IO(KVMIO, 0x47)
The KVM_GET_NR_MMU_PAGES ioctl is quite questionable on 64-bit hosts since it fails to return the full 64 bits of the value that can be set with the corresponding KVM_SET_NR_MMU_PAGES call. This ioctl likely has also never really been used by userspace applications (at least not by QEMU and kvmtool which I checked), so it's better to move it to the deprecation section in kvm.h to make it clear for developers that this also should not be used in new code in the future anymore. Signed-off-by: Thomas Huth <thuth@redhat.com> --- include/uapi/linux/kvm.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)