diff mbox series

selftests/kvm: Fix nsec to sec conversion in demand_paging_test.

Message ID 20230216202432.1033366-1-amoorthy@google.com (mailing list archive)
State New, archived
Headers show
Series selftests/kvm: Fix nsec to sec conversion in demand_paging_test. | expand

Commit Message

Anish Moorthy Feb. 16, 2023, 8:24 p.m. UTC 
demand_paging_test uses 1E8 as the denominator to convert nanoseconds to
seconds, which is wrong. Use NSEC_PER_SEC instead to fix the issue and
make the conversion obvious.

Reported-by: James Houghton <jthoughton@google.com>
Signed-off-by: Anish Moorthy <amoorthy@google.com>
Reviewed-by: Oliver Upton <oliver.upton@linux.dev>
Reviewed-by: Sean Christopherson <seanjc@google.com>
---
 tools/testing/selftests/kvm/demand_paging_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sean Christopherson Feb. 16, 2023, 8:33 p.m. UTC | #1 
"KVM: selftests:" please.

And when sending a new version, bump the version number, i.e. the subject should
read "[PATCH v2] ..."

On Thu, Feb 16, 2023, Anish Moorthy wrote:
> demand_paging_test uses 1E8 as the denominator to convert nanoseconds to
> seconds, which is wrong. Use NSEC_PER_SEC instead to fix the issue and
> make the conversion obvious.
> 
> Reported-by: James Houghton <jthoughton@google.com>
> Signed-off-by: Anish Moorthy <amoorthy@google.com>
> Reviewed-by: Oliver Upton <oliver.upton@linux.dev>
> Reviewed-by: Sean Christopherson <seanjc@google.com>
> ---
diff mbox series

Patch

diff --git a/tools/testing/selftests/kvm/demand_paging_test.c b/tools/testing/selftests/kvm/demand_paging_test.c
index b0e1fc4de9e29..2439c4043fed6 100644
--- a/tools/testing/selftests/kvm/demand_paging_test.c
+++ b/tools/testing/selftests/kvm/demand_paging_test.c
@@ -194,7 +194,7 @@  static void run_test(enum vm_guest_mode mode, void *arg)
 		ts_diff.tv_sec, ts_diff.tv_nsec);
 	pr_info("Overall demand paging rate: %f pgs/sec\n",
 		memstress_args.vcpu_args[0].pages * nr_vcpus /
-		((double)ts_diff.tv_sec + (double)ts_diff.tv_nsec / 100000000.0));
+		((double)ts_diff.tv_sec + (double)ts_diff.tv_nsec / NSEC_PER_SEC));
 
 	memstress_destroy_vm(vm);