diff mbox series

[v2,22/29] LoongArch: KVM: Implement handle idle exception

Message ID	20230220065735.1282809-23-zhaotianrui@loongson.cn (mailing list archive)
State	New, archived
Headers	show Return-Path: <kvm-owner@vger.kernel.org> From: Tianrui Zhao <zhaotianrui@loongson.cn> To: Paolo Bonzini <pbonzini@redhat.com> Cc: Huacai Chen <chenhuacai@kernel.org>, WANG Xuerui <kernel@xen0n.name>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, loongarch@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Jens Axboe <axboe@kernel.dk>, Mark Brown <broonie@kernel.org>, Alex Deucher <alexander.deucher@amd.com>, Oliver Upton <oliver.upton@linux.dev>, maobibo@loongson.cn Subject: [PATCH v2 22/29] LoongArch: KVM: Implement handle idle exception Date: Mon, 20 Feb 2023 14:57:28 +0800 Message-Id: <20230220065735.1282809-23-zhaotianrui@loongson.cn> In-Reply-To: <20230220065735.1282809-1-zhaotianrui@loongson.cn> References: <20230220065735.1282809-1-zhaotianrui@loongson.cn> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	Add KVM LoongArch support \| expand [v2,00/29] Add KVM LoongArch support [v2,01/29] LoongArch: KVM: Add kvm related header files [v2,02/29] LoongArch: KVM: Implement kvm module related interface [v2,03/29] LoongArch: KVM: Implement kvm hardware enable, disable interface [v2,04/29] LoongArch: KVM: Implement VM related functions [v2,05/29] LoongArch: KVM: Add vcpu related header files [v2,06/29] LoongArch: KVM: Implement vcpu create and destroy interface [v2,07/29] LoongArch: KVM: Implement vcpu run interface [v2,08/29] LoongArch: KVM: Implement vcpu handle exit interface [v2,09/29] LoongArch: KVM: Implement vcpu get, vcpu set registers [v2,10/29] LoongArch: KVM: Implement vcpu ENABLE_CAP, CHECK_EXTENSION ioctl interface [v2,11/29] LoongArch: KVM: Implement fpu related operations for vcpu [v2,12/29] LoongArch: KVM: Implement vcpu interrupt operations [v2,13/29] LoongArch: KVM: Implement misc vcpu related interfaces [v2,14/29] LoongArch: KVM: Implement vcpu load and vcpu put operations [v2,15/29] LoongArch: KVM: Implement vcpu status description [v2,16/29] LoongArch: KVM: Implement update VM id function [v2,17/29] LoongArch: KVM: Implement virtual machine tlb operations [v2,18/29] LoongArch: KVM: Implement vcpu timer operations [v2,19/29] LoongArch: KVM: Implement kvm mmu operations [v2,20/29] LoongArch: KVM: Implement handle csr excption [v2,21/29] LoongArch: KVM: Implement handle iocsr exception [v2,22/29] LoongArch: KVM: Implement handle idle exception [v2,23/29] LoongArch: KVM: Implement handle gspr exception [v2,24/29] LoongArch: KVM: Implement handle mmio exception [v2,25/29] LoongArch: KVM: Implement handle fpu exception [v2,26/29] LoongArch: KVM: Implement kvm exception vector [v2,27/29] LoongArch: KVM: Implement vcpu world switch [v2,28/29] LoongArch: KVM: Implement probe virtualization when loongarch cpu init [v2,29/29] LoongArch: KVM: Enable kvm config and add the makefile

Commit Message

zhaotianrui Feb. 20, 2023, 6:57 a.m. UTC

Implement kvm handle loongarch vcpu idle exception, using kvm_vcpu_block
to emulate it.

Signed-off-by: Tianrui Zhao <zhaotianrui@loongson.cn>
---
 arch/loongarch/kvm/exit.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Paolo Bonzini Feb. 20, 2023, 6:40 p.m. UTC | #1

On 2/20/23 07:57, Tianrui Zhao wrote:
> +int _kvm_emu_idle(struct kvm_vcpu *vcpu)
> +{
> +	++vcpu->stat.idle_exits;
> +	trace_kvm_exit(vcpu, KVM_TRACE_EXIT_IDLE);

Please add a separate tracepoint, don't overload trace_kvm_exit().

Likewise for _kvm_trap_handle_gspr().

I think _kvm_trap_handle_gspr() should have a tracepoint whose parameter 
is inst.word.

Paolo

> +	if (!vcpu->arch.irq_pending) {
> +		kvm_save_timer(vcpu);
> +		kvm_vcpu_block(vcpu);
> +	}
> +
> +	return EMULATE_DONE;

zhaotianrui Feb. 21, 2023, 9:48 a.m. UTC | #2

在 2023年02月21日 02:40, Paolo Bonzini 写道:
> On 2/20/23 07:57, Tianrui Zhao wrote:
>> +int _kvm_emu_idle(struct kvm_vcpu *vcpu)
>> +{
>> +    ++vcpu->stat.idle_exits;
>> +    trace_kvm_exit(vcpu, KVM_TRACE_EXIT_IDLE);
>
> Please add a separate tracepoint, don't overload trace_kvm_exit().
>
> Likewise for _kvm_trap_handle_gspr().
>
> I think _kvm_trap_handle_gspr() should have a tracepoint whose 
> parameter is inst.word.

Thanks, I will add the tracepoint for _kvm_emu_idle and 
_kvm_trap_handle_gspr.

Thanks
Tianrui Zhao

>
> Paolo
>
>> +    if (!vcpu->arch.irq_pending) {
>> +        kvm_save_timer(vcpu);
>> +        kvm_vcpu_block(vcpu);
>> +    }
>> +
>> +    return EMULATE_DONE;

diff mbox series

Patch

diff --git a/arch/loongarch/kvm/exit.c b/arch/loongarch/kvm/exit.c
index f02e2b940..a6beb83a0 100644
--- a/arch/loongarch/kvm/exit.c
+++ b/arch/loongarch/kvm/exit.c
@@ -191,3 +191,15 @@  int _kvm_complete_iocsr_read(struct kvm_vcpu *vcpu, struct kvm_run *run)
 
 	return er;
 }
+
+int _kvm_emu_idle(struct kvm_vcpu *vcpu)
+{
+	++vcpu->stat.idle_exits;
+	trace_kvm_exit(vcpu, KVM_TRACE_EXIT_IDLE);
+	if (!vcpu->arch.irq_pending) {
+		kvm_save_timer(vcpu);
+		kvm_vcpu_block(vcpu);
+	}
+
+	return EMULATE_DONE;
+}