From patchwork Wed Mar 8 05:24:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brett Creeley X-Patchwork-Id: 13165220 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EACBAC6FD20 for ; Wed, 8 Mar 2023 05:25:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229699AbjCHFZO (ORCPT ); Wed, 8 Mar 2023 00:25:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229668AbjCHFZK (ORCPT ); Wed, 8 Mar 2023 00:25:10 -0500 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EFC191B58; Tue, 7 Mar 2023 21:25:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bOAmTildjqbq67peX6R7Hu+d6ZDCFNpiH+n3VhsdjXp7IbkKQHbHo6S089rPAMcGVDZTePEWAiS9xfH4zCQIOwJ2j/ZsFmC9JcVxkZVNJ70aKCKCPWKUGCqjlC8vfVN7eSg1N/Oz7Pa6fpfQEvdWy5i8/LPRlP+kh/barBEulNRy0zmf39z3LBT6x9tlBqK+F6SWWlwqnE9QHy/5S5jPD+AWkvfRUbFQP0A5xTolPRWUA3I0GXK24IfeToeEOB1HrKIj3zynzXSTF2iWXZwZpSY9FWN5YTzPXXseatDZLbXkozMKFBCLkV8HWf0LQzaq7gWg81DX5rlcDOh+yT/keA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bkm5yh0mHvU+8zuMTjsQdO/pkdbEabFFsGDUghJFO0Q=; b=FfZorndKbkcJKaHB0S5CbhwiN2w/rdy3FOXrVr0RjcH1XD2QPxr2A5nIM/evgKuvH8Y8E/o70ndAY+VRLbBrv6zvjVQYm1r2vpM1iKULYoL2eFjnqmlxqPobP/2xjGMY5dthRDmya97OFHTawS7N32dFdkmr0ZHZD/RISl/5093ilbwbM9ByBOYnV7zSaTpaBQDYCzLBxcm7NpO0TjnWViEcCENYJ7K9/n/Foiu+LtHj9RCT9Fh8WkAYt/237kSAJRM1CnOCSelfmR8IRoSXqz/I+V+0BFQdxIvCwMcUErQt5i2TTiGB4wtRf00vM+8C90OTGURSdBpNnT4EomMRTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bkm5yh0mHvU+8zuMTjsQdO/pkdbEabFFsGDUghJFO0Q=; b=hmOHhub4q1Mla99zzl6ea24uIUyNA3M9/fkz5JYclGPvryH5n7hczfbDqw+midnIDZ8Ny0vk+v/jSbD4rv7VO17apmX5lOsQYzeHGkbm3NZyeF5LFxUh2LO/wz6IF0YAJo8ZlOHcbi8Ng57azFlwMVyJ4YdjqqkySw2Pycc1cqs= Received: from BN8PR07CA0029.namprd07.prod.outlook.com (2603:10b6:408:ac::42) by CY8PR12MB7361.namprd12.prod.outlook.com (2603:10b6:930:53::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.29; Wed, 8 Mar 2023 05:25:06 +0000 Received: from BN8NAM11FT035.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ac:cafe::44) by BN8PR07CA0029.outlook.office365.com (2603:10b6:408:ac::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.29 via Frontend Transport; Wed, 8 Mar 2023 05:25:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT035.mail.protection.outlook.com (10.13.177.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6178.17 via Frontend Transport; Wed, 8 Mar 2023 05:25:06 +0000 Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 7 Mar 2023 23:25:04 -0600 From: Brett Creeley To: , , , , , , CC: , , Subject: [RFC PATCH v4 1/7] vfio: Commonize combine_ranges for use in other VFIO drivers Date: Tue, 7 Mar 2023 21:24:44 -0800 Message-ID: <20230308052450.13421-2-brett.creeley@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230308052450.13421-1-brett.creeley@amd.com> References: <20230308052450.13421-1-brett.creeley@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT035:EE_|CY8PR12MB7361:EE_ X-MS-Office365-Filtering-Correlation-Id: 13365a44-14be-4a94-abce-08db1f957a43 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v+1x8Ec0lrWWAyVl3ne/cE91+FWuQV0SzVbVw9fl6m77zth8T4qsHkVXb948ngCJd3C8zpyfOm9fOcibZ5/xFgggGYLbfnGLJ5YPRJF4S9R6K3cGnyYavZYdTsoBVifkWvb1UsrHtDAl5Cg87qV2dT8GLh50lh3m8pazsH2WpLdikTUJRQDqf9CN6P7iZqt9XgH8lW1E8r6WF/fIZqzH2Y4cC/apK2uOD3aCXZItrTtG/7TzWR8+ajs0D/2HAqghVVB2TgImyhhUUwhNqz8NwGW4ZVly8+5r9q0eYZLu4rRx0ccf+OPmaFmlbpCEeCKDNjy4kAb5Jme45d48zKzDpZ6bXIzMS1RS0oxytK6PRZH+LaGJsjhlYbwvkVashIhvGZ54Mzhl8ze91o1472FfsmGjcqDLpxXSKuj39r+Av5UMm+AzAETKvLsq5BOAdWiBbYm4O2z+MDGnc7Vac+WMjh1Ip0Jj+wZGoEm0EkuzXap0SVvuHXxH+KvQtRHZjtXZfYdwMweklGRgiv+Wn9z3bSRN2eTizviT+kLTiuL2HdFNrTYlOkz5hIY2gNrYxennGV69tNd1Oue5SwcAbGy7T6pkKXM/QsOuCpEeig4/G2nu5/C8e02+dhSC1khEtF8AtJtLCAPE6Fk2WEgFkWYSeemNAyNTibLrfOLVqkJnlIFLXjWn6Frv1jKvE5mxyOabxIRTS0uzmmuwr5GS0qkZ00WCUIXgXnP+6WJq660LtSc= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(346002)(396003)(376002)(136003)(39860400002)(451199018)(40470700004)(36840700001)(46966006)(2616005)(336012)(426003)(82740400003)(2906002)(47076005)(83380400001)(86362001)(356005)(81166007)(36860700001)(40460700003)(16526019)(6666004)(66899018)(478600001)(316002)(54906003)(4326008)(8676002)(110136005)(70586007)(70206006)(41300700001)(5660300002)(26005)(186003)(1076003)(8936002)(36756003)(44832011)(40480700001)(82310400005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2023 05:25:06.4431 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 13365a44-14be-4a94-abce-08db1f957a43 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT035.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7361 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Currently only Mellanox uses the combine_ranges function. The new pds_vfio driver also needs this function. So, move it to a common location for other vendor drivers to use. Cc: Yishai Hadas Signed-off-by: Brett Creeley Signed-off-by: Shannon Nelson --- drivers/vfio/pci/mlx5/cmd.c | 48 +------------------------------------ drivers/vfio/vfio_main.c | 48 +++++++++++++++++++++++++++++++++++++ include/linux/vfio.h | 3 +++ 3 files changed, 52 insertions(+), 47 deletions(-) diff --git a/drivers/vfio/pci/mlx5/cmd.c b/drivers/vfio/pci/mlx5/cmd.c index deed156e6165..7f6c51992a15 100644 --- a/drivers/vfio/pci/mlx5/cmd.c +++ b/drivers/vfio/pci/mlx5/cmd.c @@ -732,52 +732,6 @@ void mlx5fv_cmd_clean_migf_resources(struct mlx5_vf_migration_file *migf) mlx5vf_cmd_dealloc_pd(migf); } -static void combine_ranges(struct rb_root_cached *root, u32 cur_nodes, - u32 req_nodes) -{ - struct interval_tree_node *prev, *curr, *comb_start, *comb_end; - unsigned long min_gap; - unsigned long curr_gap; - - /* Special shortcut when a single range is required */ - if (req_nodes == 1) { - unsigned long last; - - curr = comb_start = interval_tree_iter_first(root, 0, ULONG_MAX); - while (curr) { - last = curr->last; - prev = curr; - curr = interval_tree_iter_next(curr, 0, ULONG_MAX); - if (prev != comb_start) - interval_tree_remove(prev, root); - } - comb_start->last = last; - return; - } - - /* Combine ranges which have the smallest gap */ - while (cur_nodes > req_nodes) { - prev = NULL; - min_gap = ULONG_MAX; - curr = interval_tree_iter_first(root, 0, ULONG_MAX); - while (curr) { - if (prev) { - curr_gap = curr->start - prev->last; - if (curr_gap < min_gap) { - min_gap = curr_gap; - comb_start = prev; - comb_end = curr; - } - } - prev = curr; - curr = interval_tree_iter_next(curr, 0, ULONG_MAX); - } - comb_start->last = comb_end->last; - interval_tree_remove(comb_end, root); - cur_nodes--; - } -} - static int mlx5vf_create_tracker(struct mlx5_core_dev *mdev, struct mlx5vf_pci_core_device *mvdev, struct rb_root_cached *ranges, u32 nnodes) @@ -800,7 +754,7 @@ static int mlx5vf_create_tracker(struct mlx5_core_dev *mdev, int i; if (num_ranges > max_num_range) { - combine_ranges(ranges, nnodes, max_num_range); + vfio_combine_iova_ranges(ranges, nnodes, max_num_range); num_ranges = max_num_range; } diff --git a/drivers/vfio/vfio_main.c b/drivers/vfio/vfio_main.c index 43bd6b76e2b6..49f37c1b4932 100644 --- a/drivers/vfio/vfio_main.c +++ b/drivers/vfio/vfio_main.c @@ -864,6 +864,54 @@ static int vfio_ioctl_device_feature_migration(struct vfio_device *device, return 0; } +void vfio_combine_iova_ranges(struct rb_root_cached *root, u32 cur_nodes, + u32 req_nodes) +{ + struct interval_tree_node *prev, *curr, *comb_start, *comb_end; + unsigned long min_gap; + unsigned long curr_gap; + + /* Special shortcut when a single range is required */ + if (req_nodes == 1) { + unsigned long last; + + comb_start = interval_tree_iter_first(root, 0, ULONG_MAX); + curr = comb_start; + while (curr) { + last = curr->last; + prev = curr; + curr = interval_tree_iter_next(curr, 0, ULONG_MAX); + if (prev != comb_start) + interval_tree_remove(prev, root); + } + comb_start->last = last; + return; + } + + /* Combine ranges which have the smallest gap */ + while (cur_nodes > req_nodes) { + prev = NULL; + min_gap = ULONG_MAX; + curr = interval_tree_iter_first(root, 0, ULONG_MAX); + while (curr) { + if (prev) { + curr_gap = curr->start - prev->last; + if (curr_gap < min_gap) { + min_gap = curr_gap; + comb_start = prev; + comb_end = curr; + } + } + prev = curr; + curr = interval_tree_iter_next(curr, 0, ULONG_MAX); + } + comb_start->last = comb_end->last; + interval_tree_remove(comb_end, root); + cur_nodes--; + } +} +EXPORT_SYMBOL_GPL(vfio_combine_iova_ranges); + /* Ranges should fit into a single kernel page */ #define LOG_MAX_RANGES \ (PAGE_SIZE / sizeof(struct vfio_device_feature_dma_logging_range)) diff --git a/include/linux/vfio.h b/include/linux/vfio.h index 93134b023968..10db5aa3e985 100644 --- a/include/linux/vfio.h +++ b/include/linux/vfio.h @@ -241,6 +241,9 @@ int vfio_mig_get_next_state(struct vfio_device *device, enum vfio_device_mig_state new_fsm, enum vfio_device_mig_state *next_fsm); +void vfio_combine_iova_ranges(struct rb_root_cached *root, u32 cur_nodes, + u32 req_nodes); + /* * External user API */