diff mbox series

[RFC,V4,17/17] x86/sev: Remove restrict interrupt injection from SNP_FEATURES_IMPL_REQ

Message ID 20230403174406.4180472-18-ltykernel@gmail.com (mailing list archive)
State New, archived
Headers show
Series x86/hyperv/sev: Add AMD sev-snp enlightened guest support on hyperv | expand

Commit Message

Tianyu Lan April 3, 2023, 5:44 p.m. UTC
From: Tianyu Lan <tiala@microsoft.com>

Enabled restrict interrupt injection function. Remove MSR_AMD64_
SNP_RESTRICTED_INJ from SNP_FEATURES_IMPL_REQ to let kernel boot
up with this function.
---
 arch/x86/boot/compressed/sev.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Gupta, Pankaj April 4, 2023, 12:25 p.m. UTC | #1
> Enabled restrict interrupt injection function. Remove MSR_AMD64_
> SNP_RESTRICTED_INJ from SNP_FEATURES_IMPL_REQ to let kernel boot
> up with this function.
> ---
>   arch/x86/boot/compressed/sev.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/boot/compressed/sev.c b/arch/x86/boot/compressed/sev.c
> index d63ad8f99f83..a5f41301a600 100644
> --- a/arch/x86/boot/compressed/sev.c
> +++ b/arch/x86/boot/compressed/sev.c
> @@ -299,7 +299,6 @@ static void enforce_vmpl0(void)
>    */
>   #define SNP_FEATURES_IMPL_REQ	(MSR_AMD64_SNP_VTOM |			\
>   				 MSR_AMD64_SNP_REFLECT_VC |		\
> -				 MSR_AMD64_SNP_RESTRICTED_INJ |		\

Should we update the bit in "SNP_FEATURES_PRESENT" instead?

Thanks,
Pankaj	
>   				 MSR_AMD64_SNP_ALT_INJ |		\
>   				 MSR_AMD64_SNP_DEBUG_SWAP |		\
>   				 MSR_AMD64_SNP_VMPL_SSS |		\
Tianyu Lan April 4, 2023, 1:22 p.m. UTC | #2
On 4/4/2023 8:25 PM, Gupta, Pankaj wrote:
> 
>> Enabled restrict interrupt injection function. Remove MSR_AMD64_
>> SNP_RESTRICTED_INJ from SNP_FEATURES_IMPL_REQ to let kernel boot
>> up with this function.
>> ---
>>   arch/x86/boot/compressed/sev.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/x86/boot/compressed/sev.c 
>> b/arch/x86/boot/compressed/sev.c
>> index d63ad8f99f83..a5f41301a600 100644
>> --- a/arch/x86/boot/compressed/sev.c
>> +++ b/arch/x86/boot/compressed/sev.c
>> @@ -299,7 +299,6 @@ static void enforce_vmpl0(void)
>>    */
>>   #define SNP_FEATURES_IMPL_REQ    (MSR_AMD64_SNP_VTOM |            \
>>                    MSR_AMD64_SNP_REFLECT_VC |        \
>> -                 MSR_AMD64_SNP_RESTRICTED_INJ |        \
> 
> Should we update the bit in "SNP_FEATURES_PRESENT" instead?
> 

Nice cath! we should add the bit in the SNP_FEATURES_PRESENT.
diff mbox series

Patch

diff --git a/arch/x86/boot/compressed/sev.c b/arch/x86/boot/compressed/sev.c
index d63ad8f99f83..a5f41301a600 100644
--- a/arch/x86/boot/compressed/sev.c
+++ b/arch/x86/boot/compressed/sev.c
@@ -299,7 +299,6 @@  static void enforce_vmpl0(void)
  */
 #define SNP_FEATURES_IMPL_REQ	(MSR_AMD64_SNP_VTOM |			\
 				 MSR_AMD64_SNP_REFLECT_VC |		\
-				 MSR_AMD64_SNP_RESTRICTED_INJ |		\
 				 MSR_AMD64_SNP_ALT_INJ |		\
 				 MSR_AMD64_SNP_DEBUG_SWAP |		\
 				 MSR_AMD64_SNP_VMPL_SSS |		\