From patchwork Sat Apr 22 01:06:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brett Creeley X-Patchwork-Id: 13220856 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 974C5C77B7C for ; Sat, 22 Apr 2023 01:07:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234105AbjDVBHS (ORCPT ); Fri, 21 Apr 2023 21:07:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233235AbjDVBHO (ORCPT ); Fri, 21 Apr 2023 21:07:14 -0400 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2067.outbound.protection.outlook.com [40.107.243.67]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC4AB1725; Fri, 21 Apr 2023 18:07:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kTWfUbkZKNqUqnusPaHFvTa2CHhXdcemOQybda2wILxM1GXykiEhTpiqsFDzbR7ToNv5As9P7KqYj0Xr2URznNabEuzTf3nCf9FeF7q/NIXlKY3l1WOHly0gXUOoXSa4DcsZ4QER5qBxMRITRbHrPWZF9WSvifk3u071E88bSpoVIh/iX/xES/xrHWCFVlS73qEMHJA+9k8Uboyyn1Hg2iRWWEJxgZmJDEF+o8efWuN1+l5KmOo7BPdCxpQVzOLq9vmrRMeq6+zItbP177tufEX0GmUsiSyH//IjSfXqSmfkBQvYKoGyAvFEbw3bKvIwcz4hmMABR/SszZ9D+Eh33g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N6V1P9rkIbCpK8eONpnvUT7o85HvbP8W/SFqap/xVxM=; b=UthdQEPW4bQxKNHRiya09toAGOWZTenoWl2RyMBqQm0/GWWQ1tVOO6nDf0Yj4S6nEM4JqZbuuQVoz2xokSi4BdtoKIEpLRSQ2t7QSLQc1ckcc/4w8fqIySVJjOoEADiBrVcs241eqkFNU7zK8HSiN3ThzlVjygUYEWOO4YRcJqJ+yNdABa9uU9Sc5nDZejXTaOte6hwE0M8agOb5X5LqrYW3rK32UbViNdCHfR8BYinYQqLPJOWQQF2ODZDWDkuC7gZZpUsQlj1fFUCkU9uznRK9g9/NbgU8DA4qFWSRWiG1ojKhBeWZyYn3Zo8z29O6XGS0w0rGNdtsq4z0iFXB1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N6V1P9rkIbCpK8eONpnvUT7o85HvbP8W/SFqap/xVxM=; b=08LZTT6jiJKiNjWhXkhZ6DirYg4lgTPy+iGfY5DQXNgmzjTRqiT1+zGTLGQcLO0m+Q9V6vj9h96Rp//d2FkGqIqDkbT9VnMEN/xmoIVMk2T9qgViAcknPuObIE4ATQ2iC03oNq+GMI7nDh4ZmlTNO+nD6++rts15KDjWESSXjzc= Received: from BN9PR03CA0336.namprd03.prod.outlook.com (2603:10b6:408:f6::11) by MN2PR12MB4407.namprd12.prod.outlook.com (2603:10b6:208:260::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.21; Sat, 22 Apr 2023 01:07:08 +0000 Received: from BN8NAM11FT063.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f6:cafe::5e) by BN9PR03CA0336.outlook.office365.com (2603:10b6:408:f6::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.25 via Frontend Transport; Sat, 22 Apr 2023 01:07:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT063.mail.protection.outlook.com (10.13.177.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6319.27 via Frontend Transport; Sat, 22 Apr 2023 01:07:08 +0000 Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 21 Apr 2023 20:07:06 -0500 From: Brett Creeley To: , , , , , , CC: , , Subject: [PATCH v9 vfio 1/7] vfio: Commonize combine_ranges for use in other VFIO drivers Date: Fri, 21 Apr 2023 18:06:36 -0700 Message-ID: <20230422010642.60720-2-brett.creeley@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230422010642.60720-1-brett.creeley@amd.com> References: <20230422010642.60720-1-brett.creeley@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT063:EE_|MN2PR12MB4407:EE_ X-MS-Office365-Filtering-Correlation-Id: e80fa840-38f9-4350-f27f-08db42cde4ff X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fn7l4WWRHJsxXgxsaCl98YobxLCXDGZfD9fKyIRNZ7HhfF18+DWSeJv6VuAhqJVUSz1QsQ1mnANgodx+MgOOirIFr6etme/GLkGxJrCZaG3mDzls8ojrTZtn/x0R7Wz6RwGT5x+4SmzFR6gKutOjGLnzjhRaJlhYLJQKixAEtUtrndCLVfrTNUmb/bsXS/rddY5K6HeOU688Tp0bSJoZty/3+6kmDewzYKMwjDHs0+uRMzYfaEtIuh578LXvARDZETSqaKAI4fkufeHJgC2F86NAZBTWIySdmlhxm4bOTMnjrqDfL5agO8GFBWt+zvnID//FvYqxuYLi3X3wXi9VOBVC3pksxRhzaSOyLARsA6FZN2LpeYGaydp8beLCqPFuDX37LN823kJkfMqZmp5J0kTVb8uJx6eEZe4++JcGTFmjz6LenneFjrke71maqVcUjfjitfNN97xrnVg6I2LU2eRWLsJp5zxUnOHgIpYhSZg3vm7mgoZEjCxOBGrMMmalhs4JfCVy63wRW/EY2vfls+xd4F+/jKqUaKPGn51RRZgt6mIqDG8DRepTqz+MDOUB7Z5FL4oUS42XP/fK45DflrENYShuM2vZwM32Kw/pz/FZrfTCwaLtnsHQfkhX87aQgHgcgyzx/HmYgYg2r8N/VegG2RaOSGrHZn9Skm8QlUFzzmGCzNxqDxct3emtB5TIazfAuqHmoz/nBxKIzM5/CgF/Y+9xi92w7nhy75ZXASU= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(39860400002)(136003)(396003)(451199021)(46966006)(36840700001)(40470700004)(2616005)(82310400005)(66899021)(36756003)(336012)(426003)(47076005)(36860700001)(83380400001)(40480700001)(40460700003)(2906002)(54906003)(5660300002)(44832011)(8936002)(8676002)(6666004)(478600001)(316002)(4326008)(82740400003)(1076003)(26005)(81166007)(110136005)(41300700001)(356005)(70586007)(70206006)(86362001)(186003)(16526019)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2023 01:07:08.0296 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e80fa840-38f9-4350-f27f-08db42cde4ff X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT063.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4407 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Currently only Mellanox uses the combine_ranges function. The new pds_vfio driver also needs this function. So, move it to a common location for other vendor drivers to use. Also, Simon Harmon noticed that RCT ordering was not followed for vfio_combin_iova_ranges(), so fix that. Cc: Yishai Hadas Signed-off-by: Brett Creeley Signed-off-by: Shannon Nelson Reviewed-by: Jason Gunthorpe Reviewed-by: Simon Horman --- drivers/vfio/pci/mlx5/cmd.c | 48 +------------------------------------ drivers/vfio/vfio_main.c | 47 ++++++++++++++++++++++++++++++++++++ include/linux/vfio.h | 3 +++ 3 files changed, 51 insertions(+), 47 deletions(-) diff --git a/drivers/vfio/pci/mlx5/cmd.c b/drivers/vfio/pci/mlx5/cmd.c index deed156e6165..7f6c51992a15 100644 --- a/drivers/vfio/pci/mlx5/cmd.c +++ b/drivers/vfio/pci/mlx5/cmd.c @@ -732,52 +732,6 @@ void mlx5fv_cmd_clean_migf_resources(struct mlx5_vf_migration_file *migf) mlx5vf_cmd_dealloc_pd(migf); } -static void combine_ranges(struct rb_root_cached *root, u32 cur_nodes, - u32 req_nodes) -{ - struct interval_tree_node *prev, *curr, *comb_start, *comb_end; - unsigned long min_gap; - unsigned long curr_gap; - - /* Special shortcut when a single range is required */ - if (req_nodes == 1) { - unsigned long last; - - curr = comb_start = interval_tree_iter_first(root, 0, ULONG_MAX); - while (curr) { - last = curr->last; - prev = curr; - curr = interval_tree_iter_next(curr, 0, ULONG_MAX); - if (prev != comb_start) - interval_tree_remove(prev, root); - } - comb_start->last = last; - return; - } - - /* Combine ranges which have the smallest gap */ - while (cur_nodes > req_nodes) { - prev = NULL; - min_gap = ULONG_MAX; - curr = interval_tree_iter_first(root, 0, ULONG_MAX); - while (curr) { - if (prev) { - curr_gap = curr->start - prev->last; - if (curr_gap < min_gap) { - min_gap = curr_gap; - comb_start = prev; - comb_end = curr; - } - } - prev = curr; - curr = interval_tree_iter_next(curr, 0, ULONG_MAX); - } - comb_start->last = comb_end->last; - interval_tree_remove(comb_end, root); - cur_nodes--; - } -} - static int mlx5vf_create_tracker(struct mlx5_core_dev *mdev, struct mlx5vf_pci_core_device *mvdev, struct rb_root_cached *ranges, u32 nnodes) @@ -800,7 +754,7 @@ static int mlx5vf_create_tracker(struct mlx5_core_dev *mdev, int i; if (num_ranges > max_num_range) { - combine_ranges(ranges, nnodes, max_num_range); + vfio_combine_iova_ranges(ranges, nnodes, max_num_range); num_ranges = max_num_range; } diff --git a/drivers/vfio/vfio_main.c b/drivers/vfio/vfio_main.c index 43bd6b76e2b6..ad8a3f948f05 100644 --- a/drivers/vfio/vfio_main.c +++ b/drivers/vfio/vfio_main.c @@ -864,6 +864,53 @@ static int vfio_ioctl_device_feature_migration(struct vfio_device *device, return 0; } +void vfio_combine_iova_ranges(struct rb_root_cached *root, u32 cur_nodes, + u32 req_nodes) +{ + struct interval_tree_node *prev, *curr, *comb_start, *comb_end; + unsigned long min_gap, curr_gap; + + /* Special shortcut when a single range is required */ + if (req_nodes == 1) { + unsigned long last; + + comb_start = interval_tree_iter_first(root, 0, ULONG_MAX); + curr = comb_start; + while (curr) { + last = curr->last; + prev = curr; + curr = interval_tree_iter_next(curr, 0, ULONG_MAX); + if (prev != comb_start) + interval_tree_remove(prev, root); + } + comb_start->last = last; + return; + } + + /* Combine ranges which have the smallest gap */ + while (cur_nodes > req_nodes) { + prev = NULL; + min_gap = ULONG_MAX; + curr = interval_tree_iter_first(root, 0, ULONG_MAX); + while (curr) { + if (prev) { + curr_gap = curr->start - prev->last; + if (curr_gap < min_gap) { + min_gap = curr_gap; + comb_start = prev; + comb_end = curr; + } + } + prev = curr; + curr = interval_tree_iter_next(curr, 0, ULONG_MAX); + } + comb_start->last = comb_end->last; + interval_tree_remove(comb_end, root); + cur_nodes--; + } +} +EXPORT_SYMBOL_GPL(vfio_combine_iova_ranges); + /* Ranges should fit into a single kernel page */ #define LOG_MAX_RANGES \ (PAGE_SIZE / sizeof(struct vfio_device_feature_dma_logging_range)) diff --git a/include/linux/vfio.h b/include/linux/vfio.h index 93134b023968..10db5aa3e985 100644 --- a/include/linux/vfio.h +++ b/include/linux/vfio.h @@ -241,6 +241,9 @@ int vfio_mig_get_next_state(struct vfio_device *device, enum vfio_device_mig_state new_fsm, enum vfio_device_mig_state *next_fsm); +void vfio_combine_iova_ranges(struct rb_root_cached *root, u32 cur_nodes, + u32 req_nodes); + /* * External user API */