| Message ID | 20230531103227.1385324-1-nrb@linux.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [kvm-unit-tests,v1] runtime: don't run pv-host tests when gen-se-header is unavailable | expand |
On 31/05/2023 12.32, Nico Boehr wrote: > When the gen-se-header tool is not given as an argument to configure, > all tests which act as a PV host will not be built by the makefiles. > > run_tests.sh will fail when a test binary is missing. This means > when we add the pv-host tests to unittest.cfg we will have FAILs when > gen-se-header is missing. > > Since it is desirable to have the tests in unittest.cfg, add a new group > pv-host which designates tests that act as a PV host. These will only > run if the gen-se-header tool is available. > > The pv-host group is currently not used, but will be with Janoschs > series "s390x: Add PV SIE intercepts and ipl tests" here: > https://lore.kernel.org/all/20230502115931.86280-1-frankja@linux.ibm.com/ > > Signed-off-by: Nico Boehr <nrb@linux.ibm.com> > --- > scripts/runtime.bash | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/scripts/runtime.bash b/scripts/runtime.bash > index 07b62b0e1fe7..486dbeda8179 100644 > --- a/scripts/runtime.bash > +++ b/scripts/runtime.bash > @@ -98,6 +98,11 @@ function run() > return > fi > > + if [ -z "$GEN_SE_HEADER" ] && find_word "pv-host" "$groups"; then > + print_result "SKIP" $testname "" "no gen-se-header available for pv-host test" > + return > + fi Reviewed-by: Thomas Huth <thuth@redhat.com>
diff --git a/scripts/runtime.bash b/scripts/runtime.bash index 07b62b0e1fe7..486dbeda8179 100644 --- a/scripts/runtime.bash +++ b/scripts/runtime.bash @@ -98,6 +98,11 @@ function run() return fi + if [ -z "$GEN_SE_HEADER" ] && find_word "pv-host" "$groups"; then + print_result "SKIP" $testname "" "no gen-se-header available for pv-host test" + return + fi + if [ -z "$only_group" ] && find_word nodefault "$groups" && skip_nodefault; then print_result "SKIP" $testname "" "test marked as manual run only"
When the gen-se-header tool is not given as an argument to configure, all tests which act as a PV host will not be built by the makefiles. run_tests.sh will fail when a test binary is missing. This means when we add the pv-host tests to unittest.cfg we will have FAILs when gen-se-header is missing. Since it is desirable to have the tests in unittest.cfg, add a new group pv-host which designates tests that act as a PV host. These will only run if the gen-se-header tool is available. The pv-host group is currently not used, but will be with Janoschs series "s390x: Add PV SIE intercepts and ipl tests" here: https://lore.kernel.org/all/20230502115931.86280-1-frankja@linux.ibm.com/ Signed-off-by: Nico Boehr <nrb@linux.ibm.com> --- scripts/runtime.bash | 5 +++++ 1 file changed, 5 insertions(+)