diff mbox series

.debug ignore - to squash with efi:keep efi

Message ID 20230628001356.2706-1-namit@vmware.com (mailing list archive)
State New, archived
Headers show
Series .debug ignore - to squash with efi:keep efi | expand

Commit Message

Nadav Amit June 28, 2023, 12:13 a.m. UTC
From: Nadav Amit <namit@vmware.com>

---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

Comments

Andrew Jones June 28, 2023, 8:19 a.m. UTC | #1
On Wed, Jun 28, 2023 at 12:13:48AM +0000, Nadav Amit wrote:
> From: Nadav Amit <namit@vmware.com>

Missing s-o-b.

> 
> ---
>  .gitignore | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.gitignore b/.gitignore
> index 29f352c..2168e01 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -7,6 +7,7 @@ tags
>  *.flat
>  *.efi
>  *.elf
> +*.debug
>  *.patch
>  .pc
>  patches
> -- 
> 2.34.1
>

The patch threading is busted. Everything in the thread, including the
cover letter, is in reply to this patch.

Thanks,
drew
Andrew Jones June 28, 2023, 8:22 a.m. UTC | #2
On Wed, Jun 28, 2023 at 10:19:03AM +0200, Andrew Jones wrote:
> On Wed, Jun 28, 2023 at 12:13:48AM +0000, Nadav Amit wrote:
> > From: Nadav Amit <namit@vmware.com>
> 
> Missing s-o-b.
> 
> > 
> > ---
> >  .gitignore | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/.gitignore b/.gitignore
> > index 29f352c..2168e01 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -7,6 +7,7 @@ tags
> >  *.flat
> >  *.efi
> >  *.elf
> > +*.debug
> >  *.patch
> >  .pc
> >  patches
> > -- 
> > 2.34.1
> >
> 
> The patch threading is busted. Everything in the thread, including the
> cover letter, is in reply to this patch.
>

OK, I see the .gitignore hunk in patch 1, which is good, since it
certainly doesn't need its own patch. I'll just ignore this "patch".

Thanks,
drew
Nadav Amit June 28, 2023, 5:30 p.m. UTC | #3
> On Jun 28, 2023, at 1:22 AM, Andrew Jones <andrew.jones@linux.dev> wrote:
> 
> !! External Email
> 
> On Wed, Jun 28, 2023 at 10:19:03AM +0200, Andrew Jones wrote:
>> On Wed, Jun 28, 2023 at 12:13:48AM +0000, Nadav Amit wrote:
>>> From: Nadav Amit <namit@vmware.com>
>> 
>> Missing s-o-b.
>> 
>>> 
>>> ---
>>> .gitignore | 1 +
>>> 1 file changed, 1 insertion(+)
>>> 
>>> diff --git a/.gitignore b/.gitignore
>>> index 29f352c..2168e01 100644
>>> --- a/.gitignore
>>> +++ b/.gitignore
>>> @@ -7,6 +7,7 @@ tags
>>> *.flat
>>> *.efi
>>> *.elf
>>> +*.debug
>>> *.patch
>>> .pc
>>> patches
>>> --
>>> 2.34.1
>>> 
>> 
>> The patch threading is busted. Everything in the thread, including the
>> cover letter, is in reply to this patch.
>> 
> 
> OK, I see the .gitignore hunk in patch 1, which is good, since it
> certainly doesn't need its own patch. I'll just ignore this "patch”.

Embarrassing… Will send v4.
Nadav Amit June 28, 2023, 5:33 p.m. UTC | #4
> On Jun 28, 2023, at 10:30 AM, Nadav Amit <namit@vmware.com> wrote:
> 
> 
> 
>> On Jun 28, 2023, at 1:22 AM, Andrew Jones <andrew.jones@linux.dev> wrote:
>> 
>> OK, I see the .gitignore hunk in patch 1, which is good, since it
>> certainly doesn't need its own patch. I'll just ignore this "patch”.
> 
> Embarrassing… Will send v4.

My double mistake. So I see this patch was not supposed to be sent, but other
than that - you should have the series. Let me know if anything is wrong
(as otherwise I won’t send v4).
Andrew Jones June 29, 2023, 7:43 a.m. UTC | #5
On Wed, Jun 28, 2023 at 05:33:52PM +0000, Nadav Amit wrote:
> 
> 
> > On Jun 28, 2023, at 10:30 AM, Nadav Amit <namit@vmware.com> wrote:
> > 
> > 
> > 
> >> On Jun 28, 2023, at 1:22 AM, Andrew Jones <andrew.jones@linux.dev> wrote:
> >> 
> >> OK, I see the .gitignore hunk in patch 1, which is good, since it
> >> certainly doesn't need its own patch. I'll just ignore this "patch”.
> > 
> > Embarrassing… Will send v4.
> 
> My double mistake. So I see this patch was not supposed to be sent, but other
> than that - you should have the series. Let me know if anything is wrong
> (as otherwise I won’t send v4).

The series looks good. I plan to queue it, but was hoping to see some acks
from x86 and maybe ppc people first.

(I had to switch to this email address because I can't authenticate to
the mail service used for my @linux.dev address right now... Hopefully
that'll get resolved soon.)

Thanks,
drew
diff mbox series

Patch

diff --git a/.gitignore b/.gitignore
index 29f352c..2168e01 100644
--- a/.gitignore
+++ b/.gitignore
@@ -7,6 +7,7 @@  tags
 *.flat
 *.efi
 *.elf
+*.debug
 *.patch
 .pc
 patches