| Message ID | 20230630091752.67190-21-pmorel@linux.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | s390x: CPU Topology | expand |
On 30/06/2023 11.17, Pierre Morel wrote: > This test verifies that QEMU refuses to move a CPU to an > unexistant location. s/unexistant/nonexistent/ ? > Signed-off-by: Pierre Morel <pmorel@linux.ibm.com> > --- > tests/avocado/s390_topology.py | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/tests/avocado/s390_topology.py b/tests/avocado/s390_topology.py > index 99d9508cef..ea39168b53 100644 > --- a/tests/avocado/s390_topology.py > +++ b/tests/avocado/s390_topology.py > @@ -388,3 +388,28 @@ def test_dedicated_error(self): > res = self.vm.qmp('set-cpu-topology', > {'core-id': 0, 'entitlement': 'medium', 'dedicated': False}) > self.assertEqual(res['return'], {}) > + > + def test_move_error(self): > + """ > + This test verifies that QEMU refuses to move a CPU to an > + unexistant location s/unexistant/nonexistent/ ? With the words fixed: Reviewed-by: Thomas Huth <thuth@redhat.com>
On 7/5/23 12:32, Thomas Huth wrote: > On 30/06/2023 11.17, Pierre Morel wrote: >> This test verifies that QEMU refuses to move a CPU to an >> unexistant location. > > s/unexistant/nonexistent/ ? > >> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com> >> --- >> tests/avocado/s390_topology.py | 25 +++++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> >> diff --git a/tests/avocado/s390_topology.py >> b/tests/avocado/s390_topology.py >> index 99d9508cef..ea39168b53 100644 >> --- a/tests/avocado/s390_topology.py >> +++ b/tests/avocado/s390_topology.py >> @@ -388,3 +388,28 @@ def test_dedicated_error(self): >> res = self.vm.qmp('set-cpu-topology', >> {'core-id': 0, 'entitlement': 'medium', >> 'dedicated': False}) >> self.assertEqual(res['return'], {}) >> + >> + def test_move_error(self): >> + """ >> + This test verifies that QEMU refuses to move a CPU to an >> + unexistant location > > s/unexistant/nonexistent/ ? > > With the words fixed: > Reviewed-by: Thomas Huth <thuth@redhat.com> > I fix it, thanks, Regards, Pierre
diff --git a/tests/avocado/s390_topology.py b/tests/avocado/s390_topology.py index 99d9508cef..ea39168b53 100644 --- a/tests/avocado/s390_topology.py +++ b/tests/avocado/s390_topology.py @@ -388,3 +388,28 @@ def test_dedicated_error(self): res = self.vm.qmp('set-cpu-topology', {'core-id': 0, 'entitlement': 'medium', 'dedicated': False}) self.assertEqual(res['return'], {}) + + def test_move_error(self): + """ + This test verifies that QEMU refuses to move a CPU to an + unexistant location + + :avocado: tags=arch:s390x + :avocado: tags=machine:s390-ccw-virtio + """ + self.kernel_init() + self.vm.launch() + self.wait_until_booted() + + self.system_init() + + res = self.vm.qmp('set-cpu-topology', {'core-id': 0, 'drawer-id': 1}) + self.assertEqual(res['error']['class'], 'GenericError') + + res = self.vm.qmp('set-cpu-topology', {'core-id': 0, 'book-id': 1}) + self.assertEqual(res['error']['class'], 'GenericError') + + res = self.vm.qmp('set-cpu-topology', {'core-id': 0, 'socket-id': 1}) + self.assertEqual(res['error']['class'], 'GenericError') + + self.check_topology(0, 0, 0, 0, 'medium', False)
This test verifies that QEMU refuses to move a CPU to an unexistant location. Signed-off-by: Pierre Morel <pmorel@linux.ibm.com> --- tests/avocado/s390_topology.py | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+)