| Message ID | 20230725100844.3416164-1-foxywang@tencent.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | kvm: vmx: fix a trivial comment in vmx_vcpu_after_set_cpuid() | expand |
On Tue, Jul 25, 2023, Yi Wang wrote: > The commit b6247686b7571 ("KVM: VMX: Drop caching of KVM's desired > sec exec controls for vmcs01") renamed vmx_compute_secondary_exec_control() > to vmx_secondary_exec_control(), but forgot to modify the comment. > > Signed-off-by: Yi Wang <foxywang@tencent.com> > --- > arch/x86/kvm/vmx/vmx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c > index 0ecf4be2c6af..26d62990fea7 100644 > --- a/arch/x86/kvm/vmx/vmx.c > +++ b/arch/x86/kvm/vmx/vmx.c > @@ -7722,7 +7722,7 @@ static void vmx_vcpu_after_set_cpuid(struct kvm_vcpu *vcpu) > { > struct vcpu_vmx *vmx = to_vmx(vcpu); > > - /* xsaves_enabled is recomputed in vmx_compute_secondary_exec_control(). */ > + /* xsaves_enabled is recomputed in vmx_secondary_exec_control(). */ > vcpu->arch.xsaves_enabled = false; I have an in-progress patch[*] that reworks this code and wipes out the stale comment as a side effect. Thank you though! [*] https://lore.kernel.org/all/20230217231022.816138-4-seanjc@google.com
diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index 0ecf4be2c6af..26d62990fea7 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -7722,7 +7722,7 @@ static void vmx_vcpu_after_set_cpuid(struct kvm_vcpu *vcpu) { struct vcpu_vmx *vmx = to_vmx(vcpu); - /* xsaves_enabled is recomputed in vmx_compute_secondary_exec_control(). */ + /* xsaves_enabled is recomputed in vmx_secondary_exec_control(). */ vcpu->arch.xsaves_enabled = false; vmx_setup_uret_msrs(vmx);
The commit b6247686b7571 ("KVM: VMX: Drop caching of KVM's desired sec exec controls for vmcs01") renamed vmx_compute_secondary_exec_control() to vmx_secondary_exec_control(), but forgot to modify the comment. Signed-off-by: Yi Wang <foxywang@tencent.com> --- arch/x86/kvm/vmx/vmx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)