| Message ID | 20230906014942.1658769-1-oushixiong@kylinos.cn (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | vfio/pds: Add missing PCI_IOV depends | expand |
On Wed, Sep 06, 2023 at 09:49:42AM +0800, oushixiong wrote: > From: Shixiong Ou <oushixiong@kylinos.cn> > > If PCI_ATS isn't set, then pdev->physfn is not defined. > it causes a compilation issue: > > ../drivers/vfio/pci/pds/vfio_dev.c:165:30: error: ‘struct pci_dev’ has no member named ‘physfn’; did you mean ‘is_physfn’? > 165 | __func__, pci_dev_id(pdev->physfn), pci_id, vf_id, > | ^~~~~~ > > So adding PCI_IOV depends to select PCI_ATS. > > Signed-off-by: Shixiong Ou <oushixiong@kylinos.cn> > --- > drivers/vfio/pci/pds/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> Jason
On 9/5/2023 6:49 PM, oushixiong wrote: > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > From: Shixiong Ou <oushixiong@kylinos.cn> > > If PCI_ATS isn't set, then pdev->physfn is not defined. > it causes a compilation issue: > > ../drivers/vfio/pci/pds/vfio_dev.c:165:30: error: ‘struct pci_dev’ has no member named ‘physfn’; did you mean ‘is_physfn’? > 165 | __func__, pci_dev_id(pdev->physfn), pci_id, vf_id, > | ^~~~~~ > > So adding PCI_IOV depends to select PCI_ATS. > > Signed-off-by: Shixiong Ou <oushixiong@kylinos.cn> > --- > drivers/vfio/pci/pds/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vfio/pci/pds/Kconfig b/drivers/vfio/pci/pds/Kconfig > index 407b3fd32733..6eceef7b028a 100644 > --- a/drivers/vfio/pci/pds/Kconfig > +++ b/drivers/vfio/pci/pds/Kconfig > @@ -3,7 +3,7 @@ > > config PDS_VFIO_PCI > tristate "VFIO support for PDS PCI devices" > - depends on PDS_CORE > + depends on PDS_CORE && PCI_IOV > select VFIO_PCI_CORE > help > This provides generic PCI support for PDS devices using the VFIO > -- > 2.25.1 > LGTM! Thanks for fixing this. Reviewed-by: Brett Creeley <brett.creeley@amd.com>
> From: oushixiong <oushixiong@kylinos.cn> > Sent: Wednesday, September 6, 2023 9:50 AM > > From: Shixiong Ou <oushixiong@kylinos.cn> > > If PCI_ATS isn't set, then pdev->physfn is not defined. > it causes a compilation issue: > > ../drivers/vfio/pci/pds/vfio_dev.c:165:30: error: ‘struct pci_dev’ has no > member named ‘physfn’; did you mean ‘is_physfn’? > 165 | __func__, pci_dev_id(pdev->physfn), pci_id, vf_id, > | ^~~~~~ > Use pci_physfn()
On Wed, 6 Sep 2023 09:49:42 +0800 oushixiong <oushixiong@kylinos.cn> wrote: > From: Shixiong Ou <oushixiong@kylinos.cn> > > If PCI_ATS isn't set, then pdev->physfn is not defined. > it causes a compilation issue: > > ../drivers/vfio/pci/pds/vfio_dev.c:165:30: error: ‘struct pci_dev’ has no member named ‘physfn’; did you mean ‘is_physfn’? > 165 | __func__, pci_dev_id(pdev->physfn), pci_id, vf_id, > | ^~~~~~ > > So adding PCI_IOV depends to select PCI_ATS. > > Signed-off-by: Shixiong Ou <oushixiong@kylinos.cn> > --- > drivers/vfio/pci/pds/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to vfio for-linus branch for v6.6. Thanks, Alex > > diff --git a/drivers/vfio/pci/pds/Kconfig b/drivers/vfio/pci/pds/Kconfig > index 407b3fd32733..6eceef7b028a 100644 > --- a/drivers/vfio/pci/pds/Kconfig > +++ b/drivers/vfio/pci/pds/Kconfig > @@ -3,7 +3,7 @@ > > config PDS_VFIO_PCI > tristate "VFIO support for PDS PCI devices" > - depends on PDS_CORE > + depends on PDS_CORE && PCI_IOV > select VFIO_PCI_CORE > help > This provides generic PCI support for PDS devices using the VFIO
diff --git a/drivers/vfio/pci/pds/Kconfig b/drivers/vfio/pci/pds/Kconfig index 407b3fd32733..6eceef7b028a 100644 --- a/drivers/vfio/pci/pds/Kconfig +++ b/drivers/vfio/pci/pds/Kconfig @@ -3,7 +3,7 @@ config PDS_VFIO_PCI tristate "VFIO support for PDS PCI devices" - depends on PDS_CORE + depends on PDS_CORE && PCI_IOV select VFIO_PCI_CORE help This provides generic PCI support for PDS devices using the VFIO