| Message ID | 20231112041643.2868316-7-jacob.jun.pan@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Coalesced Interrupt Delivery with posted MSI | expand |
On Sat, Nov 11 2023 at 20:16, Jacob Pan wrote: > Make PIR field into u64 such that atomic xchg64 can be used without ugly > casting. Make PIR field into... That's not a sentence. > Suggested-by: Thomas Gleixner <tglx@linutronix.de> > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com> > --- > arch/x86/include/asm/posted_intr.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/include/asm/posted_intr.h b/arch/x86/include/asm/posted_intr.h > index 2cd9ac1af835..3af00f5395e4 100644 > --- a/arch/x86/include/asm/posted_intr.h > +++ b/arch/x86/include/asm/posted_intr.h > @@ -9,7 +9,10 @@ > > /* Posted-Interrupt Descriptor */ > struct pi_desc { > - u32 pir[8]; /* Posted interrupt requested */ > + union { > + u32 pir[8]; /* Posted interrupt requested */ > + u64 pir_l[4]; pir_l is really not intuitive. What's wrong with spelling the type out in the name: pir64[4] ? > + }; > union { > struct { > /* bit 256 - Outstanding Notification */
diff --git a/arch/x86/include/asm/posted_intr.h b/arch/x86/include/asm/posted_intr.h index 2cd9ac1af835..3af00f5395e4 100644 --- a/arch/x86/include/asm/posted_intr.h +++ b/arch/x86/include/asm/posted_intr.h @@ -9,7 +9,10 @@ /* Posted-Interrupt Descriptor */ struct pi_desc { - u32 pir[8]; /* Posted interrupt requested */ + union { + u32 pir[8]; /* Posted interrupt requested */ + u64 pir_l[4]; + }; union { struct { /* bit 256 - Outstanding Notification */
Make PIR field into u64 such that atomic xchg64 can be used without ugly casting. Suggested-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com> --- arch/x86/include/asm/posted_intr.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)