| Message ID | 20240116065847.71623-2-shahuang@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: runtime scripts improvements on efi | expand |
On Tue, Jan 16, 2024 at 01:58:44AM -0500, Shaoqin Huang wrote: > The last_line is deleted by the 2607d2d6 ("arm64: Add an efi/run script"). > This lead to when SKIP test, the reason is missing. Fix the problem by > adding last_line back. > > Fixes: 2607d2d6 ("arm64: Add an efi/run script") > Reviewed-by: Andrew Jones <andrew.jones@linux.dev> > Signed-off-by: Shaoqin Huang <shahuang@redhat.com> > --- > scripts/runtime.bash | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/runtime.bash b/scripts/runtime.bash > index fc156f2f..c73fb024 100644 > --- a/scripts/runtime.bash > +++ b/scripts/runtime.bash > @@ -149,7 +149,7 @@ function run() > fi > > if [ ${skip} == true ]; then > - print_result "SKIP" $testname "" "$last_line" > + print_result "SKIP" $testname "" "$(tail -1 <<<"$log")" > return 77 > fi > } > -- > 2.40.1 > Pushing this patch now, but holding off on patch 2 of this series for now and patch 3 will go through the arm branch with some other arm efi changes. Thanks, drew
diff --git a/scripts/runtime.bash b/scripts/runtime.bash index fc156f2f..c73fb024 100644 --- a/scripts/runtime.bash +++ b/scripts/runtime.bash @@ -149,7 +149,7 @@ function run() fi if [ ${skip} == true ]; then - print_result "SKIP" $testname "" "$last_line" + print_result "SKIP" $testname "" "$(tail -1 <<<"$log")" return 77 fi }
The last_line is deleted by the 2607d2d6 ("arm64: Add an efi/run script"). This lead to when SKIP test, the reason is missing. Fix the problem by adding last_line back. Fixes: 2607d2d6 ("arm64: Add an efi/run script") Reviewed-by: Andrew Jones <andrew.jones@linux.dev> Signed-off-by: Shaoqin Huang <shahuang@redhat.com> --- scripts/runtime.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)