From patchwork Thu Feb 29 06:36:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiaoyao Li X-Patchwork-Id: 13576554 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C8913C697 for ; Thu, 29 Feb 2024 06:41:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709188865; cv=none; b=DZIRXv4eS8NSteEyhlYnXjKYAE1A11qGDDN+fMv4/jlH1sXqOQpTq8ACRPNSsbWhhhwp/tR7VSRcXPan7XaFrUrXA/wh00xO/40kCxyu0iUY/bCUfDy+t3OBeWVJrprl0+wdgQtlngvxBxaMMr8OAbDFNEIMkD4gYZJRMN9l01o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709188865; c=relaxed/simple; bh=cmbU3tDF03XHOgSHO4OovN27gl27DdI5rmRqf4cj0uY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=DL6/XMqE9o+6fWZ3SelrcRK/Gi3GVM4A6xi6EpCfhcotrKBlNXb3Y0g+0B71E1ypkevRtrPzeOt1Ldqu34qPHGbWxbkdhYd+tJ/ecOi5c8bemxipDSnnVtpUaBgrxJO0nnWNfCuW3NF6cZPzpVen78DOyXt3nGTN65Lhi1oyc+A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=oHBPiwT+; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="oHBPiwT+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709188864; x=1740724864; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=cmbU3tDF03XHOgSHO4OovN27gl27DdI5rmRqf4cj0uY=; b=oHBPiwT+CZbTeD8mdazdXEvbOK6xVdjYkJuSxlNkSQD1deLrzuExkKR0 6L80p2AOvPaTgyNwVxQckn7H69fxvfklQGAIFyRUrb5grq88tdc4Uc1t2 THpTIV8IgKP0HaZXEsltNppKZBF9oqBzx8RcbiWRReFwiDiPp5VLMez9i sadlSMCBlfPaZD1xDefCPClEExrEkTZrrKzR5VyCaNeclwm2mT5LwwTFw NyZFQFM70kG2N45fi8T+lemldutHtwEFIFwFec4Z4RGzD7Lxr7Osn5qQS MGNU6hhMlmQr1xZIljbeGx+AtVBPlTCwHJbh6GI4xlS2i6aNSdxTO4TbU Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10998"; a="3802837" X-IronPort-AV: E=Sophos;i="6.06,192,1705392000"; d="scan'208";a="3802837" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2024 22:41:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,192,1705392000"; d="scan'208";a="8075600" Received: from lxy-clx-4s.sh.intel.com ([10.239.48.52]) by orviesa007.jf.intel.com with ESMTP; 28 Feb 2024 22:40:58 -0800 From: Xiaoyao Li To: Paolo Bonzini , David Hildenbrand , Igor Mammedov , Eduardo Habkost , Marcel Apfelbaum , =?utf-8?q?Philippe_Mathieu-D?= =?utf-8?q?aud=C3=A9?= , Yanan Wang , "Michael S. Tsirkin" , Richard Henderson , Ani Sinha , Peter Xu , Cornelia Huck , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Eric Blake , Markus Armbruster , Marcelo Tosatti Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, Michael Roth , Claudio Fontana , Gerd Hoffmann , Isaku Yamahata , Chenyi Qiang , xiaoyao.li@intel.com Subject: [PATCH v5 32/65] i386/tdx: Set kvm_readonly_mem_enabled to false for TDX VM Date: Thu, 29 Feb 2024 01:36:53 -0500 Message-Id: <20240229063726.610065-33-xiaoyao.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240229063726.610065-1-xiaoyao.li@intel.com> References: <20240229063726.610065-1-xiaoyao.li@intel.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 TDX only supports readonly for shared memory but not for private memory. In the view of QEMU, it has no idea whether a memslot is used as shared memory of private. Thus just mark kvm_readonly_mem_enabled to false to TDX VM for simplicity. Signed-off-by: Xiaoyao Li Acked-by: Gerd Hoffmann --- target/i386/kvm/tdx.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/target/i386/kvm/tdx.c b/target/i386/kvm/tdx.c index 42dbb5ce5c15..13f069171db7 100644 --- a/target/i386/kvm/tdx.c +++ b/target/i386/kvm/tdx.c @@ -480,6 +480,15 @@ static int tdx_kvm_init(ConfidentialGuestSupport *cgs, Error **errp) update_tdx_cpuid_lookup_by_tdx_caps(); + /* + * Set kvm_readonly_mem_allowed to false, because TDX only supports readonly + * memory for shared memory but not for private memory. Besides, whether a + * memslot is private or shared is not determined by QEMU. + * + * Thus, just mark readonly memory not supported for simplicity. + */ + kvm_readonly_mem_allowed = false; + tdx_guest = tdx; return 0; }