From patchwork Thu Feb 29 06:37:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiaoyao Li X-Patchwork-Id: 13576608 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8695E15B1 for ; Thu, 29 Feb 2024 06:44:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709189055; cv=none; b=qc5xDTdo+o/YQA2fPTUFu9ZY1ktt4QogyRT2AVJJs1XcYhYfJ3keXnlvE566EsCKmgzh7ozOvZK96hr/sr6LWaWsC2caD48nIdeGVbrM9CXKDw/sZfVsZGoQRDEXUoJS1LCJMfnRovCRG/TK6ExltiFsAh1+KoCsnTmmu3HZvKI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709189055; c=relaxed/simple; bh=RrzkhDw1VtDi2hKo7a+7rAJ71YA5KKx9qyDrNK94Sdk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CLlr4jCt6XijvLxmcTy5sKGFNWyiduEjGLWQpXbT7KoIK3QUUX77paME50qejMsLhgXMPZ6PkvVNg5XStkaTagtyM8kGleBuR8LgQ58iOcJW+WSRX0MtPzYxxcyqqnexdGQhzKmX0BPhWpselqByyHkOkYXwmBAorg0Tp4/+cy4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=UdTav59X; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="UdTav59X" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709189053; x=1740725053; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=RrzkhDw1VtDi2hKo7a+7rAJ71YA5KKx9qyDrNK94Sdk=; b=UdTav59XzbwfOaKILbLdmb0WfjOy2+9/SDSNzUSYwoKEz5Z+eHMRBjfc wZIYewpJIN1YGvsEeN9Lu56S6zFbHE862s4Jhieq604tlgSxprUDDYlEg ei8fiTqr1+ni9KLOERJu4eKIy5DCexIjWpOLWrHF5L6S3KqgOAFvFI/5m Qcw9ayEqopzltl5EBcyH/0nJSP7szD5xV934jBkux/Bg8bWWdmyXtUAr9 SaiU0UNZv8rOgPrpyEG+meVLcDVE1cofJvqb0Sr4WlGM1gqLaXZ3HxmaZ KYg3+anFHydZMswfsx7cuf2CGto7IHuoe/qVuvo6taKKP9ajx9Ih2QHlW w==; X-IronPort-AV: E=McAfee;i="6600,9927,10998"; a="3803304" X-IronPort-AV: E=Sophos;i="6.06,192,1705392000"; d="scan'208";a="3803304" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2024 22:44:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,192,1705392000"; d="scan'208";a="8076514" Received: from lxy-clx-4s.sh.intel.com ([10.239.48.52]) by orviesa007.jf.intel.com with ESMTP; 28 Feb 2024 22:44:07 -0800 From: Xiaoyao Li To: Paolo Bonzini , David Hildenbrand , Igor Mammedov , Eduardo Habkost , Marcel Apfelbaum , =?utf-8?q?Philippe_Mathieu-D?= =?utf-8?q?aud=C3=A9?= , Yanan Wang , "Michael S. Tsirkin" , Richard Henderson , Ani Sinha , Peter Xu , Cornelia Huck , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Eric Blake , Markus Armbruster , Marcelo Tosatti Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, Michael Roth , Claudio Fontana , Gerd Hoffmann , Isaku Yamahata , Chenyi Qiang , xiaoyao.li@intel.com Subject: [PATCH v5 61/65] i386/tdx: Don't synchronize guest tsc for TDs Date: Thu, 29 Feb 2024 01:37:22 -0500 Message-Id: <20240229063726.610065-62-xiaoyao.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240229063726.610065-1-xiaoyao.li@intel.com> References: <20240229063726.610065-1-xiaoyao.li@intel.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Isaku Yamahata TSC of TDs is not accessible and KVM doesn't allow access of MSR_IA32_TSC for TDs. To avoid the assert() in kvm_get_tsc, make kvm_synchronize_all_tsc() noop for TDs, Signed-off-by: Isaku Yamahata Reviewed-by: Connor Kuehl Signed-off-by: Xiaoyao Li Acked-by: Gerd Hoffmann --- target/i386/kvm/kvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index b1b0384b0c5c..83276e23b19f 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -277,7 +277,7 @@ void kvm_synchronize_all_tsc(void) { CPUState *cpu; - if (kvm_enabled()) { + if (kvm_enabled() && !is_tdx_vm()) { CPU_FOREACH(cpu) { run_on_cpu(cpu, do_kvm_synchronize_tsc, RUN_ON_CPU_NULL); }