Message ID | 20240405090052.375599-17-npiggin@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | add shellcheck support | expand |
On Fri, Apr 05, 2024 at 07:00:48PM +1000, Nicholas Piggin wrote: > SC2153 (info): Possible misspelling: ACCEL may not be assigned. Did > you mean accel? > > Looks like a bug? Agreed. > > Signed-off-by: Nicholas Piggin <npiggin@gmail.com> > --- > scripts/s390x/func.bash | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/s390x/func.bash b/scripts/s390x/func.bash > index 6c75e89ae..fa47d0191 100644 > --- a/scripts/s390x/func.bash > +++ b/scripts/s390x/func.bash > @@ -21,7 +21,7 @@ function arch_cmd_s390x() > "$cmd" "$testname" "$groups" "$smp" "$kernel" "$opts" "$arch" "$check" "$accel" "$timeout" > > # run PV test case > - if [ "$ACCEL" = 'tcg' ] || grep -q "migration" <<< "$groups"; then > + if [ "$accel" = 'tcg' ] || grep -q "migration" <<< "$groups"; then > return > fi > kernel=${kernel%.elf}.pv.bin > -- > 2.43.0 > Reviewed-by: Andrew Jones <andrew.jones@linux.dev>
diff --git a/scripts/s390x/func.bash b/scripts/s390x/func.bash index 6c75e89ae..fa47d0191 100644 --- a/scripts/s390x/func.bash +++ b/scripts/s390x/func.bash @@ -21,7 +21,7 @@ function arch_cmd_s390x() "$cmd" "$testname" "$groups" "$smp" "$kernel" "$opts" "$arch" "$check" "$accel" "$timeout" # run PV test case - if [ "$ACCEL" = 'tcg' ] || grep -q "migration" <<< "$groups"; then + if [ "$accel" = 'tcg' ] || grep -q "migration" <<< "$groups"; then return fi kernel=${kernel%.elf}.pv.bin
SC2153 (info): Possible misspelling: ACCEL may not be assigned. Did you mean accel? Looks like a bug? Signed-off-by: Nicholas Piggin <npiggin@gmail.com> --- scripts/s390x/func.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)