| Message ID | 20240406122456.405139-2-npiggin@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | s390x: run script fixes for PV tests | expand |
On 4/6/24 14:24, Nicholas Piggin wrote: > The if statement is intended to run non-migration tests with PV on KVM. > With the misspelling, they are run on KVM or TCG. > It's not misspelt, is it? It's in the wrong case. I'm fine with the code though.
On Mon Apr 8, 2024 at 9:59 PM AEST, Janosch Frank wrote: > On 4/6/24 14:24, Nicholas Piggin wrote: > > The if statement is intended to run non-migration tests with PV on KVM. > > With the misspelling, they are run on KVM or TCG. > > > > It's not misspelt, is it? > It's in the wrong case. Yes, that's the right word. > > > I'm fine with the code though. Thanks, I'll take that as an Acked-by: you Thanks, Nick
On 4/10/24 06:35, Nicholas Piggin wrote: > On Mon Apr 8, 2024 at 9:59 PM AEST, Janosch Frank wrote: >> On 4/6/24 14:24, Nicholas Piggin wrote: >>> The if statement is intended to run non-migration tests with PV on KVM. >>> With the misspelling, they are run on KVM or TCG. >>> >> >> It's not misspelt, is it? >> It's in the wrong case. > > Yes, that's the right word. > >> >> >> I'm fine with the code though. > > Thanks, I'll take that as an Acked-by: you Could you send out a fixed version that I can pick or do you want me to fix that up?
On Thu Apr 11, 2024 at 7:40 PM AEST, Janosch Frank wrote: > On 4/10/24 06:35, Nicholas Piggin wrote: > > On Mon Apr 8, 2024 at 9:59 PM AEST, Janosch Frank wrote: > >> On 4/6/24 14:24, Nicholas Piggin wrote: > >>> The if statement is intended to run non-migration tests with PV on KVM. > >>> With the misspelling, they are run on KVM or TCG. > >>> > >> > >> It's not misspelt, is it? > >> It's in the wrong case. > > > > Yes, that's the right word. > > > >> > >> > >> I'm fine with the code though. > > > > Thanks, I'll take that as an Acked-by: you > > Could you send out a fixed version that I can pick or do you want me to > fix that up? I was going to at some point, but was juggling a bunch of other things and have some travel and vacation. You are welcome to take over them if you like it would be helpful. Thanks, Nick
On 4/16/24 04:29, Nicholas Piggin wrote: > On Thu Apr 11, 2024 at 7:40 PM AEST, Janosch Frank wrote: >> On 4/10/24 06:35, Nicholas Piggin wrote: >>> On Mon Apr 8, 2024 at 9:59 PM AEST, Janosch Frank wrote: >>>> On 4/6/24 14:24, Nicholas Piggin wrote: >>>>> The if statement is intended to run non-migration tests with PV on KVM. >>>>> With the misspelling, they are run on KVM or TCG. >>>>> >>>> >>>> It's not misspelt, is it? >>>> It's in the wrong case. >>> >>> Yes, that's the right word. >>> >>>> >>>> >>>> I'm fine with the code though. >>> >>> Thanks, I'll take that as an Acked-by: you >> >> Could you send out a fixed version that I can pick or do you want me to >> fix that up? > > I was going to at some point, but was juggling a bunch of other > things and have some travel and vacation. You are welcome to take > over them if you like it would be helpful. > Same here, I'll be on vacation starting next week so I've prepared a branch with your patches for Nico and Claudio which they can send out when I'm on vacation. https://gitlab.com/frankja/kvm-unit-tests/-/commits/queue/?ref_type=heads
diff --git a/scripts/s390x/func.bash b/scripts/s390x/func.bash index 6c75e89ae..fa47d0191 100644 --- a/scripts/s390x/func.bash +++ b/scripts/s390x/func.bash @@ -21,7 +21,7 @@ function arch_cmd_s390x() "$cmd" "$testname" "$groups" "$smp" "$kernel" "$opts" "$arch" "$check" "$accel" "$timeout" # run PV test case - if [ "$ACCEL" = 'tcg' ] || grep -q "migration" <<< "$groups"; then + if [ "$accel" = 'tcg' ] || grep -q "migration" <<< "$groups"; then return fi kernel=${kernel%.elf}.pv.bin