diff mbox series

[kvm-unit-tests] gitlab-ci: Fix the cirrus pipelines

Message ID 20240415130321.149890-1-thuth@redhat.com (mailing list archive)
State New, archived
Headers show
Series [kvm-unit-tests] gitlab-ci: Fix the cirrus pipelines | expand

Commit Message

Thomas Huth April 15, 2024, 1:03 p.m. UTC
Pulling the "master" libvirt-ci containers does not work anymore,
so we have to switch to the "latest" instead. See also:
https://gitlab.com/libvirt/libvirt/-/commit/5d591421220c850aa64a640

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 .gitlab-ci.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Daniel P. Berrangé April 15, 2024, 1:22 p.m. UTC | #1
On Mon, Apr 15, 2024 at 03:03:21PM +0200, Thomas Huth wrote:
> Pulling the "master" libvirt-ci containers does not work anymore,
> so we have to switch to the "latest" instead. See also:

We explicitly changed to publish under the 'latest' tag.

> https://gitlab.com/libvirt/libvirt/-/commit/5d591421220c850aa64a640

This commit is the root cause:

  https://gitlab.com/libvirt/libvirt-ci/-/commit/6e3c5ccac77714be70c0dc52c5210c7cda8fe40f

The effects were dormant for a year as I didn't delete the old
':master' tags until two weeks ago.

> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


> ---
>  .gitlab-ci.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index ff34b1f5..98177cdb 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -308,7 +308,7 @@ build-centos7:
>  #   https://gitlab.com/libvirt/libvirt/-/blob/v7.0.0/ci/README.rst
>  #
>  .cirrus_build_job_template: &cirrus_build_job_definition
> - image: registry.gitlab.com/libvirt/libvirt-ci/cirrus-run:master
> + image: registry.gitlab.com/libvirt/libvirt-ci/cirrus-run:latest
>   before_script:
>    - sed -e "s|[@]CI_REPOSITORY_URL@|$CI_REPOSITORY_URL|g"
>          -e "s|[@]CI_COMMIT_REF_NAME@|$CI_COMMIT_REF_NAME|g"
> -- 
> 2.44.0
> 

With regards,
Daniel
Thomas Huth April 15, 2024, 1:44 p.m. UTC | #2
On 15/04/2024 15.22, Daniel P. Berrangé wrote:
> On Mon, Apr 15, 2024 at 03:03:21PM +0200, Thomas Huth wrote:
>> Pulling the "master" libvirt-ci containers does not work anymore,
>> so we have to switch to the "latest" instead. See also:
> 
> We explicitly changed to publish under the 'latest' tag.
> 
>> https://gitlab.com/libvirt/libvirt/-/commit/5d591421220c850aa64a640
> 
> This commit is the root cause:
> 
>    https://gitlab.com/libvirt/libvirt-ci/-/commit/6e3c5ccac77714be70c0dc52c5210c7cda8fe40f
> 
> The effects were dormant for a year as I didn't delete the old
> ':master' tags until two weeks ago.

Thanks! I added that information to the commit message and pushed the patch 
to the repository.

  Thomas
diff mbox series

Patch

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index ff34b1f5..98177cdb 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -308,7 +308,7 @@  build-centos7:
 #   https://gitlab.com/libvirt/libvirt/-/blob/v7.0.0/ci/README.rst
 #
 .cirrus_build_job_template: &cirrus_build_job_definition
- image: registry.gitlab.com/libvirt/libvirt-ci/cirrus-run:master
+ image: registry.gitlab.com/libvirt/libvirt-ci/cirrus-run:latest
  before_script:
   - sed -e "s|[@]CI_REPOSITORY_URL@|$CI_REPOSITORY_URL|g"
         -e "s|[@]CI_COMMIT_REF_NAME@|$CI_COMMIT_REF_NAME|g"