| Message ID | 20240702155606.71398-1-imbrenda@linux.ibm.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v1,1/1] KVM: s390: remove useless include | expand |
Quoting Claudio Imbrenda (2024-07-02 17:56:06) > arch/s390/include/asm/kvm_host.h includes linux/kvm_host.h, but > linux/kvm_host.h includes asm/kvm_host.h . > > It turns out that arch/s390/include/asm/kvm_host.h only needs > linux/kvm_types.h, which it already includes. > > Stop including linux/kvm_host.h from arch/s390/include/asm/kvm_host.h . > > Due to the #ifdef guards, the code works as it is today, but it's ugly > and it will get in the way of future patches. > > Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com> Reviewed-by: Nico Boehr <nrb@linux.ibm.com>
On 7/2/24 17:56, Claudio Imbrenda wrote: > arch/s390/include/asm/kvm_host.h includes linux/kvm_host.h, but > linux/kvm_host.h includes asm/kvm_host.h . > > It turns out that arch/s390/include/asm/kvm_host.h only needs > linux/kvm_types.h, which it already includes. > > Stop including linux/kvm_host.h from arch/s390/include/asm/kvm_host.h . > > Due to the #ifdef guards, the code works as it is today, but it's ugly > and it will get in the way of future patches. Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
diff --git a/arch/s390/include/asm/kvm_host.h b/arch/s390/include/asm/kvm_host.h index 95990461888f..736cc88f497d 100644 --- a/arch/s390/include/asm/kvm_host.h +++ b/arch/s390/include/asm/kvm_host.h @@ -15,7 +15,6 @@ #include <linux/hrtimer.h> #include <linux/interrupt.h> #include <linux/kvm_types.h> -#include <linux/kvm_host.h> #include <linux/kvm.h> #include <linux/seqlock.h> #include <linux/module.h>
arch/s390/include/asm/kvm_host.h includes linux/kvm_host.h, but linux/kvm_host.h includes asm/kvm_host.h . It turns out that arch/s390/include/asm/kvm_host.h only needs linux/kvm_types.h, which it already includes. Stop including linux/kvm_host.h from arch/s390/include/asm/kvm_host.h . Due to the #ifdef guards, the code works as it is today, but it's ugly and it will get in the way of future patches. Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com> --- arch/s390/include/asm/kvm_host.h | 1 - 1 file changed, 1 deletion(-)