| Message ID | 20240826053309.10802-1-cade.richard@berkeley.edu (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [kvm-unit-tests] Added prefix pop at bottom of DBCN test function. | expand |
On Sun, Aug 25, 2024 at 10:33:09PM GMT, Cade Richard wrote: > Added report prefix pop at bottom of DBCN test function. > > Fixes: https://lore.kernel.org/kvm/20240812141354.119889-10-andrew.jones@linux.dev/#t This should be Fixes: ce58d3a45d96 ("riscv: sbi: Add dbcn write test") and without a space before the s-o-b. I've fixed it up while queuing. Thanks, drew > > Signed-off-by: Cade Richard <cade.richard@berkeley.edu> > --- > riscv/sbi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/riscv/sbi.c b/riscv/sbi.c > index 36ddfd48..01697aed 100644 > --- a/riscv/sbi.c > +++ b/riscv/sbi.c > @@ -418,6 +418,7 @@ static void check_dbcn(void) > report(ret.value == 0, "expected ret.value (%ld)", ret.value); > > report_prefix_pop(); > + report_prefix_pop(); > } > > int main(int argc, char **argv) > -- > 2.43.0 > > > -- > kvm-riscv mailing list > kvm-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kvm-riscv
This patch summary has a period. I've removed it. I also rewrote the
commit message. Just repeating the summary isn't helpful. I wrote
The number of pops needs to balance the number of pushes, but
check_dbcn was missing a pop, resulting in a dbcn prefix being output
on following non-dbcn tests. Add the pop.
Thanks,
drew
On Sun, Aug 25, 2024 at 10:33:09PM GMT, Cade Richard wrote:
> Added report prefix pop at bottom of DBCN test function.
>
> Fixes: https://lore.kernel.org/kvm/20240812141354.119889-10-andrew.jones@linux.dev/#t
>
> Signed-off-by: Cade Richard <cade.richard@berkeley.edu>
> ---
> riscv/sbi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/riscv/sbi.c b/riscv/sbi.c
> index 36ddfd48..01697aed 100644
> --- a/riscv/sbi.c
> +++ b/riscv/sbi.c
> @@ -418,6 +418,7 @@ static void check_dbcn(void)
> report(ret.value == 0, "expected ret.value (%ld)", ret.value);
>
> report_prefix_pop();
> + report_prefix_pop();
> }
>
> int main(int argc, char **argv)
> --
> 2.43.0
>
>
> --
> kvm-riscv mailing list
> kvm-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kvm-riscv
diff --git a/riscv/sbi.c b/riscv/sbi.c index 36ddfd48..01697aed 100644 --- a/riscv/sbi.c +++ b/riscv/sbi.c @@ -418,6 +418,7 @@ static void check_dbcn(void) report(ret.value == 0, "expected ret.value (%ld)", ret.value); report_prefix_pop(); + report_prefix_pop(); } int main(int argc, char **argv)
Added report prefix pop at bottom of DBCN test function. Fixes: https://lore.kernel.org/kvm/20240812141354.119889-10-andrew.jones@linux.dev/#t Signed-off-by: Cade Richard <cade.richard@berkeley.edu> --- riscv/sbi.c | 1 + 1 file changed, 1 insertion(+)