| Message ID | 20240908114256.979518-2-yi.l.liu@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iommufd: Misc cleanups per iommufd iopf merging | expand |
On 2024/9/8 19:42, Yi Liu wrote: > For the fault-capable hwpts, the iommufd_hwpt_detach_device() calls both > iommufd_fault_domain_detach_dev() and iommu_detach_group(). This would have > duplicated __iommu_group_set_core_domain() call since both functions call > it in the end. This looks no harm as the __iommu_group_set_core_domain() > returns if the new domain equals to the existing one. But it makes sense to > avoid such duplicated calls in caller side. > > Signed-off-by: Yi Liu<yi.l.liu@intel.com> > --- > drivers/iommu/iommufd/iommufd_private.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com> Thanks, baolu
> From: Liu, Yi L <yi.l.liu@intel.com> > Sent: Sunday, September 8, 2024 7:43 PM > > For the fault-capable hwpts, the iommufd_hwpt_detach_device() calls both > iommufd_fault_domain_detach_dev() and iommu_detach_group(). This > would have > duplicated __iommu_group_set_core_domain() call since both functions call > it in the end. This looks no harm as the __iommu_group_set_core_domain() > returns if the new domain equals to the existing one. But it makes sense to > avoid such duplicated calls in caller side. > > Signed-off-by: Yi Liu <yi.l.liu@intel.com> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
diff --git a/drivers/iommu/iommufd/iommufd_private.h b/drivers/iommu/iommufd/iommufd_private.h index 92efe30a8f0d..1141c0633dc9 100644 --- a/drivers/iommu/iommufd/iommufd_private.h +++ b/drivers/iommu/iommufd/iommufd_private.h @@ -490,8 +490,10 @@ static inline int iommufd_hwpt_attach_device(struct iommufd_hw_pagetable *hwpt, static inline void iommufd_hwpt_detach_device(struct iommufd_hw_pagetable *hwpt, struct iommufd_device *idev) { - if (hwpt->fault) + if (hwpt->fault) { iommufd_fault_domain_detach_dev(hwpt, idev); + return; + } iommu_detach_group(hwpt->domain, idev->igroup->group); }
For the fault-capable hwpts, the iommufd_hwpt_detach_device() calls both iommufd_fault_domain_detach_dev() and iommu_detach_group(). This would have duplicated __iommu_group_set_core_domain() call since both functions call it in the end. This looks no harm as the __iommu_group_set_core_domain() returns if the new domain equals to the existing one. But it makes sense to avoid such duplicated calls in caller side. Signed-off-by: Yi Liu <yi.l.liu@intel.com> --- drivers/iommu/iommufd/iommufd_private.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)