Message ID | 20240910221606.1817478-22-pierrick.bouvier@linaro.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04D141ABED0 for <kvm@vger.kernel.org>; Tue, 10 Sep 2024 22:17:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726006622; cv=none; b=oKq+as9ERoVcAIC3ZNlF4E53iF7vyC4dfO7SQrefq0qe8dd/cbJrGhTpfCho/L2vZCexC0ryDmbnNlgkE83I/zMp0pqndG6ietUEPGmmPJ1QuhwOY5JmUcVY2Cv92gXAS9t7bJqmfHJdSR4oGOp7wGVWRLjrnGhZ3oVXH/kbazE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726006622; c=relaxed/simple; bh=BHiveNNh/+ZUzo2p1aHpWD6DvNiQeilcG4h9ygwW7Wo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=OFZzzcHdLqnWGQxfmGSbrIgHFrTMVEI/rg4MqstAgpvMZRF9qf03S8QWEBO5C4jJUp6y/mqJ54OnehsPUcpusQQH4lCI9+vpUsd9l0P8S4xwAgOuf0NjwZrAU8rabl9N4GKLuozgv0967HF2pjDCWYIEvZIGWYmjEjQ9TNkhsyI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xZF6u/FH; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xZF6u/FH" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-718e11e4186so1244593b3a.2 for <kvm@vger.kernel.org>; Tue, 10 Sep 2024 15:17:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726006620; x=1726611420; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KGbjDOKJ1fKYY1uGWKFY9+QMWL7t/3O1ImqR91k5f0Q=; b=xZF6u/FHxobbeaFgdOXiS+odSqPZRnvdfTxoqbyT/wu0+jT6qWYEut5haPnincjet1 02Gx31gguE+Ucm9b0WwvWFo06oXYaaBtoUQ1tUVOKFFdPan182AKdXZhcEWVEN76+Et2 OyB9IGOTf9D+dv9YPu8CYzZEL6ZjfaoUI2MR7TMwqWDxbpjX2RzOj5bVmQiw+t6xD7eH +3Il2cYNJk90+d7BMpS2BQos+X7Rd5mWqDjdnD2lmfuSkf87uKK/3E9dNO6iIzjN1q6J O/fmEUZ7XmFB4v/dHvPbUTH7MwA5btuiGFKTgWsh2Mukh2e5nSW2Wm6rsPw0WZnOT2Kk OcMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726006620; x=1726611420; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KGbjDOKJ1fKYY1uGWKFY9+QMWL7t/3O1ImqR91k5f0Q=; b=LNrOLHkKqHNkqelFiLrYOT3M3i8KAmpAFqg25e6AKCAMjnWaw4iW0ixOx/+9mL9HO4 oxT8TK/YeH+4nTjFMfZpKngu/s1zoqpvTQwOrhtR4xq4OvQGDs78MJf20/Xs4PMOCbzB wO5ExeOXF/icN9TyTbcwDn1ZSjBnYBwcPl6H+gbdz43izB1X1YJXWm3jjtRIHT/TMEZF lwjTsOsG35BG5C86bM8H8LlAqei1sx3iCuBwxfeQp2Lt/WcELOMUZXogkFvpzrCEqCaA DLTU19tyJ4dLFWQEPLpo821nqha4sPD0lUDZy7ohAyoDYMdykqXO6BD18w/FBoh8fwr5 /qig== X-Forwarded-Encrypted: i=1; AJvYcCXCg8n0KGoRDrmuxSq8c8dvmoxCnNcuqWFoAq3ayZf17A7llAru2jDkgLYXXDLH9DoS1eY=@vger.kernel.org X-Gm-Message-State: AOJu0YzVzvmof9pp3BSPq4DVPEbvArVgB31cVHwNn/ZnlChq2iJofjFh jgEHeRcHwlKK3i+77aRfC3t+si4GGAjDihWl3ISPl03ExJ0y4+vB/A486ihyBSw= X-Google-Smtp-Source: AGHT+IEmi5bmB0qNS+mpiVKXRllZgpf/ZuOjLIu6c1N2HyHg/D6mILGOlbKUYizy2HbzFdbDzqq34Q== X-Received: by 2002:a05:6a21:38a:b0:1cf:397f:b69 with SMTP id adf61e73a8af0-1cf62cc1d32mr1586618637.13.1726006620331; Tue, 10 Sep 2024 15:17:00 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71909003d0esm1884055b3a.93.2024.09.10.15.16.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Sep 2024 15:16:59 -0700 (PDT) From: Pierrick Bouvier <pierrick.bouvier@linaro.org> To: qemu-devel@nongnu.org Cc: Zhao Liu <zhao1.liu@intel.com>, "Richard W.M. Jones" <rjones@redhat.com>, Joel Stanley <joel@jms.id.au>, Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-arm@nongnu.org, Corey Minyard <minyard@acm.org>, Eric Farman <farman@linux.ibm.com>, Thomas Huth <thuth@redhat.com>, Keith Busch <kbusch@kernel.org>, WANG Xuerui <git@xen0n.name>, Hyman Huang <yong.huang@smartx.com>, Stefan Berger <stefanb@linux.vnet.ibm.com>, Michael Rolnik <mrolnik@gmail.com>, Alistair Francis <alistair.francis@wdc.com>, =?utf-8?q?Marc-Andr=C3=A9_Lure?= =?utf-8?q?au?= <marcandre.lureau@redhat.com>, Markus Armbruster <armbru@redhat.com>, Sriram Yagnaraman <sriram.yagnaraman@ericsson.com>, Palmer Dabbelt <palmer@dabbelt.com>, qemu-riscv@nongnu.org, Ani Sinha <anisinha@redhat.com>, Halil Pasic <pasic@linux.ibm.com>, Jesper Devantier <foss@defmacro.it>, Laurent Vivier <laurent@vivier.eu>, Peter Maydell <peter.maydell@linaro.org>, Igor Mammedov <imammedo@redhat.com>, kvm@vger.kernel.org, =?utf-8?q?Alex_Be?= =?utf-8?q?nn=C3=A9e?= <alex.bennee@linaro.org>, Richard Henderson <richard.henderson@linaro.org>, Fam Zheng <fam@euphon.net>, qemu-s390x@nongnu.org, Hanna Reitz <hreitz@redhat.com>, Nicholas Piggin <npiggin@gmail.com>, Eduardo Habkost <eduardo@habkost.net>, Laurent Vivier <lvivier@redhat.com>, Rob Herring <robh@kernel.org>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, qemu-block@nongnu.org, "Maciej S. Szmigiero" <maciej.szmigiero@oracle.com>, qemu-ppc@nongnu.org, Daniel Henrique Barboza <danielhb413@gmail.com>, Christian Borntraeger <borntraeger@linux.ibm.com>, Harsh Prateek Bora <harshpb@linux.ibm.com>, =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= <philmd@linaro.org>, Nina Schoetterl-Glausch <nsg@linux.ibm.com>, "Michael S. Tsirkin" <mst@redhat.com>, Fabiano Rosas <farosas@suse.de>, Helge Deller <deller@gmx.de>, Dmitry Fleytman <dmitry.fleytman@gmail.com>, Daniel Henrique Barboza <dbarboza@ventanamicro.com>, Akihiko Odaki <akihiko.odaki@daynix.com>, Marcelo Tosatti <mtosatti@redhat.com>, David Gibson <david@gibson.dropbear.id.au>, Aurelien Jarno <aurelien@aurel32.net>, Liu Zhiwei <zhiwei_liu@linux.alibaba.com>, Yanan Wang <wangyanan55@huawei.com>, Peter Xu <peterx@redhat.com>, Bin Meng <bmeng.cn@gmail.com>, Weiwei Li <liwei1518@gmail.com>, Klaus Jensen <its@irrelevant.dk>, Jean-Christophe Dubois <jcd@tribudubois.net>, Jason Wang <jasowang@redhat.com>, Pierrick Bouvier <pierrick.bouvier@linaro.org> Subject: [PATCH 21/39] migration: replace assert(false) with g_assert_not_reached() Date: Tue, 10 Sep 2024 15:15:48 -0700 Message-Id: <20240910221606.1817478-22-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240910221606.1817478-1-pierrick.bouvier@linaro.org> References: <20240910221606.1817478-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: <kvm.vger.kernel.org> List-Subscribe: <mailto:kvm+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:kvm+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit |
Series |
Use g_assert_not_reached instead of (g_)assert(0,false)
|
expand
|
Pierrick Bouvier <pierrick.bouvier@linaro.org> writes: > Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> > --- > migration/dirtyrate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c > index 1d9db812990..a28c07327e8 100644 > --- a/migration/dirtyrate.c > +++ b/migration/dirtyrate.c > @@ -228,7 +228,7 @@ static int time_unit_to_power(TimeUnit time_unit) > case TIME_UNIT_MILLISECOND: > return -3; > default: > - assert(false); /* unreachable */ > + g_assert_not_reached(); /* unreachable */ > return 0; > } > } You could drop the comment that's now redundant. Reviewed-by: Fabiano Rosas <farosas@suse.de>
On Tue, Sep 10, 2024 at 03:15:48PM -0700, Pierrick Bouvier wrote: > Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> Reviewed-by: Peter Xu <peterx@redhat.com>
diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c index 1d9db812990..a28c07327e8 100644 --- a/migration/dirtyrate.c +++ b/migration/dirtyrate.c @@ -228,7 +228,7 @@ static int time_unit_to_power(TimeUnit time_unit) case TIME_UNIT_MILLISECOND: return -3; default: - assert(false); /* unreachable */ + g_assert_not_reached(); /* unreachable */ return 0; } }
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> --- migration/dirtyrate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)