From patchwork Thu Sep 12 07:38:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801595 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 455DF19048D for ; Thu, 12 Sep 2024 07:40:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126812; cv=none; b=DJ8ufb2sfyYMbhSYHfuFqV23H+JbaAMxRR0P0X4xQ9FZsF/0No+9GMA0OU7ZDCMkxerxEy2tgdSZba+l+AzxKk9nBuot2Io+4D9Q1BbDkZYJn5+piRB5VKt4hbhrJqrf1ooORPN3qDvxIue++hPiQI+JVng8KU9R3PEdAJBlvzE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126812; c=relaxed/simple; bh=63qh8GTjzyrgkl1pmQ7psE/kkGXVQaBj7lRwT0hNclQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=F1dS3f0jkTw1+Ysotzu/KmhFeMTaQlepl9mlq8PJfHGSrGoSIZvko5j9lx3yWb2+sG58tCGJEwH/KCMXzVxTFCPOqK+PSGiJZe367QS+MzKD9VmO2djTmHPg0ecSc8UM3qxB35Ocggzp+jZ1pR20Eb8zJGQuBJul5Ny2oC9ekaE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=k4/oJj10; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="k4/oJj10" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-718e9c8bd83so1274151b3a.1 for ; Thu, 12 Sep 2024 00:40:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126810; x=1726731610; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LUkTeAVAzR9AYc2U0wxTWgfR6a0KVPFNlmWMjsS+ujQ=; b=k4/oJj103LDiC4rKtR4+i0/eZy7b4eGCSl03N1HuGLJvcv5LBN92cAeJTQWd99/v0I AOnRSuT1VIy/RFNiT0Ib3GB1AlqmjQZaAnykWV5/2V5BATvun/KPDInJkcetoQb2vyCj sA5VfbU7gQjGcpXU5pNvX0xw1ns4ghvNOMLEviPyr5kvdZdzHhZ+vluN8EZy/cb5B29z 7srC50n6sOF+hQR7zMtDWNLX2Q330VnkwaIVo/doXTS2lNrPotcy2yEVSs56FLslmZFf qbU2+GFE3VHz366VMs/00+EHg3s7dR0LjwLWwEilaxphbcAjurvtzfGJHLgQTnwc9OQU luhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126810; x=1726731610; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LUkTeAVAzR9AYc2U0wxTWgfR6a0KVPFNlmWMjsS+ujQ=; b=AeWDOCibEbnFwtQmm2Ur23WuGTB3DyzMfQVm6nhOZlDXPC+wlP5DLDN5Z1A62B/cK7 S5t1geZv6Ng2KUiyYcrBtK88PHKKGOLGF9K0A3792nVxBuCkVncIK9tj9Sz46NWShx1A l+UpvTcj0EHQuYmWVgtSiVGqy9c7PKql0xZqVulfDQMovb46tshrRFtkA8u94hLQMOkk oRmTrznHB4g62wkOlylX3/EKfblezwT2LlGgkjwrRwNxFzK45LyYCQkcVr8fyzNS0IIj gr2EP/uxkkT2jnITG3ltv/G04AuRUT4fc7ECbj/MD2r6G1OspZQyXAgsulu+KtqXF43/ M0+w== X-Forwarded-Encrypted: i=1; AJvYcCUnr2wnFQDIKDuoNegmT9lrFHGFL4hJNFUSqVWFovdSubJzCzbYTV3iLQrnFltgAEWZ5Bo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0N3vZITNN5vnSsQQVjrYzHh/XwfO95IfsJjXktOB8QMUL6nhR AZujduLMWXsLKc7u6pRfJ54LN9HDNgidqcXvJnv1ICXCygoK9pvSq33l3aiDfBA= X-Google-Smtp-Source: AGHT+IEm1qfoJyiyuz3pPbRbsIvSjDeyET4AF6g6lnz2NNR0EVNyE3b7nhPetB5baWbyDfCovyWvGg== X-Received: by 2002:a05:6a21:1798:b0:1c8:de01:e7e5 with SMTP id adf61e73a8af0-1cf75616bffmr2800213637.15.1726126810532; Thu, 12 Sep 2024 00:40:10 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.40.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:40:10 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 17/48] hw/net: replace assert(false) with g_assert_not_reached() Date: Thu, 12 Sep 2024 00:38:50 -0700 Message-Id: <20240912073921.453203-18-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/net/e1000e_core.c | 2 +- hw/net/igb_core.c | 2 +- hw/net/net_rx_pkt.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c index 3ae2a184d5d..248381f9766 100644 --- a/hw/net/e1000e_core.c +++ b/hw/net/e1000e_core.c @@ -561,7 +561,7 @@ e1000e_rss_calc_hash(E1000ECore *core, type = NetPktRssIpV6Ex; break; default: - assert(false); + g_assert_not_reached(); return 0; } diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index bcd5f6cd9cd..6be61407715 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -397,7 +397,7 @@ igb_rss_calc_hash(IGBCore *core, struct NetRxPkt *pkt, E1000E_RSSInfo *info) type = NetPktRssIpV6Udp; break; default: - assert(false); + g_assert_not_reached(); return 0; } diff --git a/hw/net/net_rx_pkt.c b/hw/net/net_rx_pkt.c index 32e5f3f9cf7..6b9c4c9559d 100644 --- a/hw/net/net_rx_pkt.c +++ b/hw/net/net_rx_pkt.c @@ -375,7 +375,7 @@ net_rx_pkt_calc_rss_hash(struct NetRxPkt *pkt, _net_rx_rss_prepare_udp(&rss_input[0], pkt, &rss_length); break; default: - assert(false); + g_assert_not_reached(); break; }