From patchwork Thu Sep 19 04:46:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807336 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E37EA25779 for ; Thu, 19 Sep 2024 04:47:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721228; cv=none; b=jrn6Em3vWgPG0QFJJfrMsH7uDFU9QNK4dFb4BqfskI8WDbWHMPNMmOfB4Ro1QA3RHHUuPZxLjcNr8LyoBvKu3/B7U+4JKvMzEzYzOTqIqTVQx0tIc/Y6hSO1taLbTKHGSoS0RGePgmoEcGygBz+K/g1VVhTNKjn5tFj4HNP9zKE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721228; c=relaxed/simple; bh=RNTk/qmECFkTEx44xc+gELcnq0ftFvyRfHIqoob3R6c=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=M+sVued0TkZgSrgrNccuOuAc25y/COeUD9ckKKmUBZFXxNQ9APT1EoGtEMOR77WW0eOD59fITHF1uraKS9W0dAdGIA0LbbIuFbmn6oXk7V2QVg/O4D6xWmNCRkMWZ7vjHbBFaFsSa1V1Sz1/BcT912Ud122FBIF5PgHp7pP1NPQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mRiMs6MP; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mRiMs6MP" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-7198de684a7so265083b3a.2 for ; Wed, 18 Sep 2024 21:47:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721226; x=1727326026; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J91xisxxghHlg97TfgBUUF7cBAztIX0LnTXW2HtCgj8=; b=mRiMs6MPAejFODSnFf12DHDUfIccdOn8ZTs3QcDwet5bTQVCEe4nDvyLfAOKXHYAt4 YmXeQY/pzuhhdJEmyUTuDFUvzibiK/vklAF4dUF6m4uAbO+hIQSECqEAjDFP69FFGh3R Gpj02WtuoHf6se1E2fzR/itzJURFLiILBFCrf4mVWg65ta54ZHhiP1hp3y7V8ELMd3gm v2r7/cIcSto/URxFLvWLlNxVDyhC/pszSOvGVDexlTlzmerBOfX84dyIBYlFF12r6C7k LWTJbdD8vwvUzedB/YhIE4hCmRnio1OiAVaBT9USIVaaPL+YHlDRs7+diyrqRVqQ54Wp QW0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721226; x=1727326026; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J91xisxxghHlg97TfgBUUF7cBAztIX0LnTXW2HtCgj8=; b=S2RXPCM4dkL0wUrtM+jE5SYzthMm9V1iazCMRywvuizACIoPVRViAZFOYhkyCxOGO+ WbOBT4vmIrw1fivK0FEBKQFTfTgrUFVrddz1McJFr95bJJOHIKNWwqDy2OL/ig1W2bSu +ot9i+KeeCnigvvKSNG2rcrNX1DA2RtCBxWEuo3UmonJMC047aKC56eXA6UWPryAqWSw TM+EZBJCf5oNW0gkkAKS8F1RIjGlSioQAkdJ/DX/QqKGiBCl+LDwGIsMZfMLLoHr4mv3 nmxWKIOwK5iG3cOHjlwDjg/Qffkt1IcucPpO8zH1oGtsaLSFiWfUKX0YzSgVlYW/KrSP 40hg== X-Forwarded-Encrypted: i=1; AJvYcCVTQGIeKrUOittwtghWt+HuEY+gSkmQExnXGzlojKMOA1LNkOJ57rDy0RFz3DrPkZtUljA=@vger.kernel.org X-Gm-Message-State: AOJu0YydHAqKmwPD8/2P4vWHNJLNikBlaqxtjVKPoJmO0+fHSSR0mJYH 4wfSqUhKXv6nnkc60DWWuISw3NYZjyVxzZaPAIwmh9HVOqTtLqSFhVfX3raOKuA= X-Google-Smtp-Source: AGHT+IGCW5jSj35sH5O5IBgPKf4Npc1WOdLbOOxXHUFlvIY40aSfwB5Uf2VB8797RC2mgCqAOWZcNQ== X-Received: by 2002:a05:6a21:3947:b0:1cf:27bf:8e03 with SMTP id adf61e73a8af0-1cf75efd46amr36339625637.26.1726721226274; Wed, 18 Sep 2024 21:47:06 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:05 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier , Klaus Jensen Subject: [PATCH v3 10/34] hw/nvme: replace assert(false) with g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:17 -0700 Message-Id: <20240919044641.386068-11-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Klaus Jensen Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/nvme/ctrl.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index 9e94a240540..2589e1968ea 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -1816,7 +1816,7 @@ static uint16_t nvme_check_zone_state_for_write(NvmeZone *zone) trace_pci_nvme_err_zone_is_read_only(zslba); return NVME_ZONE_READ_ONLY; default: - assert(false); + g_assert_not_reached(); } return NVME_INTERNAL_DEV_ERROR; @@ -1870,7 +1870,7 @@ static uint16_t nvme_check_zone_state_for_read(NvmeZone *zone) trace_pci_nvme_err_zone_is_offline(zone->d.zslba); return NVME_ZONE_OFFLINE; default: - assert(false); + g_assert_not_reached(); } return NVME_INTERNAL_DEV_ERROR; @@ -4654,7 +4654,7 @@ static uint16_t nvme_io_cmd(NvmeCtrl *n, NvmeRequest *req) case NVME_CMD_IO_MGMT_SEND: return nvme_io_mgmt_send(n, req); default: - assert(false); + g_assert_not_reached(); } return NVME_INVALID_OPCODE | NVME_DNR; @@ -7205,7 +7205,7 @@ static uint16_t nvme_admin_cmd(NvmeCtrl *n, NvmeRequest *req) case NVME_ADM_CMD_DIRECTIVE_RECV: return nvme_directive_receive(n, req); default: - assert(false); + g_assert_not_reached(); } return NVME_INVALID_OPCODE | NVME_DNR;