From patchwork Thu Sep 19 04:46:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807329 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B0A81CD15 for ; Thu, 19 Sep 2024 04:46:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721215; cv=none; b=XYkYMPkD4rqmYGbfLSv6N3oW/HK/5uaL/6z882Bp3nkJ49DPkHpYrNL2LrHHQI8u6XNzrgicrzC6y/riOzwbNm3F+Uh1CqNEcdPbuyJJOmQNiIwq1tMxcfv/A7pP6xwV29lpTw/JG6ZIpQ8+yDAZrWbc9ivVEnqvOTOUycX12Q0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721215; c=relaxed/simple; bh=W5aWB2iyXXQuxV7o2KmXYYCNiRPnXk067barVEYx0UI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BpJqUDU9TK7A+wdz4WMitIQbhSwhY9f5+y6LUrwZzdTIXhnfJN9vQDB30fhlmXBEVnUfQcwrAZLQz1X2Tx1uL3o0RRhjJDKXe/Nez+pIKcnR6KuHeHMSXlTgtIb4g5/yPxryb0NP5Ilh6ak8esyeKEHRErdOBt0cULLeCZdtyfc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=chOe7lzQ; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="chOe7lzQ" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-718e56d7469so301340b3a.0 for ; Wed, 18 Sep 2024 21:46:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721213; x=1727326013; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0/2IU4UYdfrAjMX4NizJG5E5V51UHXtFH8CwKGzIrQ0=; b=chOe7lzQeMQ+Gvnukn5Zcm48jaeUc1pqvnXT96Zc30bB0aslyo3SvzXcSxrPIx19XI 0u+jBV73MOxDs7arVQIz5eJx/c9RD4oWRY5LuWlASbrJSOGpQUyI6vJj9DhQE8V1KGw+ oSJjXnTC+EyspO9zue48+WmMeCkXODCSzsNaMdGXw/0ZwZQU147kIuwTvzLi5qhr43Jz CNDeEF7I/hFkIrpdHPbfViG7fyVchGYU2hUFD78w7haELatY5jpHySiuPm54QSwJaDHL xK1yCudFORPbkOYScv/vkHs+9LE8QxkdgUrg3sqpxkhBlwq5IUNTKeejGt5B8do6n94g bhjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721213; x=1727326013; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0/2IU4UYdfrAjMX4NizJG5E5V51UHXtFH8CwKGzIrQ0=; b=Ue/YYzXQNvbP2U6Xmjn7J+oKmD9KtmnxF3QndKozLpcMh3VyvXqQ95uBydvXMsQxU6 0Jlol4mjWCLuLpUQVymSWeLLogQupI6iLVmZPbgonjUv8EjW0J4KMzpEbtQXQW0PdJyV 8ixFN/+iPJRemEW48v2iI3+OAOfoN+VOWAq3txh9lYxW2ircJ5a+Ibv+j57vD/hYzz5J QcNQuSFi1JEBkGTwTA9BrvABfUkof6N+DP9NKsSZ5zTpu3ge9JWt1yWUWL6LyAcjpjmw grxv6J6yQUBuxBs9ySdZRpgJYKeTLOXE8dlVN7xqbSJPzJ5OiFGUYOuK3iD7mFXU9TOF DU3g== X-Forwarded-Encrypted: i=1; AJvYcCV3oAyeLQPTfUqf4w8oIZjUSZpl3wcH8EcpIOoRrzzTpngcB3FYPJAKzhxIV8a0q6PhT/o=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5TWNoNeJIyIubYgDdXEpDXLR1DI607uOMYMVRD8KFbM5z07Mp hFdF0j6Y6lUpI6tAzty4/nfY0uGuizPleKUj+8vs2VYtBuLhpSXDKPQabpzbHP8= X-Google-Smtp-Source: AGHT+IEcE62Tv8QknJc8pTjVPHSXUbymb6AaYmeRJfTOhBz1uvzhH2wZstAOj+tMDYx/X/qUzXsWew== X-Received: by 2002:a05:6a00:3c73:b0:718:ea84:3e50 with SMTP id d2e1a72fcca58-71936afb98cmr25001957b3a.22.1726721212760; Wed, 18 Sep 2024 21:46:52 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.46.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:46:52 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 03/34] hw/net: replace assert(0) with g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:10 -0700 Message-Id: <20240919044641.386068-4-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/net/i82596.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/i82596.c b/hw/net/i82596.c index 6cc8292a65a..cd416a00ffa 100644 --- a/hw/net/i82596.c +++ b/hw/net/i82596.c @@ -282,7 +282,7 @@ static void command_loop(I82596State *s) case CmdDump: case CmdDiagnose: printf("FIXME Command %d !!\n", cmd & 7); - assert(0); + g_assert_not_reached(); } /* update status */