From patchwork Thu Sep 19 04:46:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807334 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3236B1DA5F for ; Thu, 19 Sep 2024 04:47:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721224; cv=none; b=RuBVEMB915KPAjtSrxN567UMZCeYl5CqSLyaolA+E3TJozNt7W2kl/ryh/T+NJM6OEr+GvDaQ0mXC5RkkI2reeA9Q8PSexwL4WD/VWxKHTPR8YlpI00uNzLciESjzy5OJj6Kt+70+xesr9BGD5UJhd6H+brAFiRWwfsRSVlvVmo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721224; c=relaxed/simple; bh=+1cxAY4vPUO2qYxMtKRnkMQkjtL/nq8N06784vwiWEM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=pQ0si0a330X234/w749WDNbZIWRudIT8nUiPSN+LWw76AzW1RaLO5CvlScxks4HaCuzwE0OSfRASv5Y59CQmlOqRUP2wFwP7Evhtv34pNwgZ/WXxBLepmCF0+snS5UCo+KLBCI9DTCJ29m7fl9lNjI/KoJkVs54NXsoDBaEhvZY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=BN2+yPI3; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BN2+yPI3" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-7d4fbe62bf5so218891a12.0 for ; Wed, 18 Sep 2024 21:47:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721222; x=1727326022; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=De4sKLPybVhT2+Pc9xtI+CTmpF8ivUBlmtwhnsMRIOQ=; b=BN2+yPI3ajWSrDko5uylqj/ZzvTWkhW2ImKK8OsGqpIdQKulw/cdSuEt1TvCBflGWS LMYnNYtFyEWGi0uwdX+nEpYNGbe6Zwn0MgS7/NTRN52peR5XSX1CO2y05Uz9U3pHQtIT KjN88em/Oo+aiW/IR9TfhMM/aeEFkpC2VjrwKsaTl/V/AhNPv4D6GBWF4bNyJR/UB0f2 xc/fEWXdVTrr/HfFfKcEXpQE8PidzOxE52RZPf6Y+Pk5NACdheGsaCf5RKvazbJM52Hp i1qHo/AGBhUSXzJ1SQ0tDRMzgrdF0HEMXZgec0IttXY/vItpDL8Udu2O23ZMqr/HsOWb SRjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721222; x=1727326022; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=De4sKLPybVhT2+Pc9xtI+CTmpF8ivUBlmtwhnsMRIOQ=; b=ZFdRLMZBC1tLfXAHiAkRUcYVmAzX873/o9i7Q5C8U5UbiBymZ4+NHZlnk+CVgKu7qT DKrnKNg+czF96QwOOX6jb37s7TBdiEXr8PG1Vf8sYxyo236i3y47CvoxYTMJelWvYBmu fLHRz3scaeko67njdPxO4jUVZFsNQb5lbMT2IfBUwdmwH803I8wwSSlf96ItYS///N+k uzJWq3/Phrozvt4DhB3AnOLBfAk/jMOwyCobp86/u1LeNFoJeuh++KI9rnXa/QVScbFI iH6IrRzL4b4Jzfk2/Pgo03x87yIpe/gC3CwO+EyJYSmx1LUCAOWEe79Wq2ADUCHBP0QK 8NLA== X-Forwarded-Encrypted: i=1; AJvYcCVqF1EzPF2qXvpOi8mlV+dGo2u+p6biRS3hdNvbpEizdQdNlINXGCgik4o1dTimL+l9ANw=@vger.kernel.org X-Gm-Message-State: AOJu0YyFt1zuD/UAjr/97LO6d9JmbDokhizuZYd3k4lr3IjYt/SkBuhT VHRj+pNiWwlFJ585bfm7viaaOaDRTWxjuoelQuHetD+nhC63PVeZCRLwZdt9TgI= X-Google-Smtp-Source: AGHT+IE2Y81B/LKedghyO/XIB5KqiZokca4F2Biq0KEcZsGPJCLDi0vE6MjHgWLkzwtVTNzR2l7/8A== X-Received: by 2002:a05:6a21:3a87:b0:1cf:4326:5602 with SMTP id adf61e73a8af0-1d112e8bf15mr31788153637.36.1726721222472; Wed, 18 Sep 2024 21:47:02 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:01 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 08/34] hw/hyperv: replace assert(false) with g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:15 -0700 Message-Id: <20240919044641.386068-9-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Maciej S. Szmigiero Signed-off-by: Pierrick Bouvier --- hw/hyperv/hyperv_testdev.c | 6 +++--- hw/hyperv/vmbus.c | 12 ++++++------ 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/hyperv/hyperv_testdev.c b/hw/hyperv/hyperv_testdev.c index 9a56ddf83fe..ef50e490c4e 100644 --- a/hw/hyperv/hyperv_testdev.c +++ b/hw/hyperv/hyperv_testdev.c @@ -88,7 +88,7 @@ static TestSintRoute *sint_route_find(HypervTestDev *dev, return sint_route; } } - assert(false); + g_assert_not_reached(); return NULL; } @@ -187,7 +187,7 @@ static void msg_conn_destroy(HypervTestDev *dev, uint8_t conn_id) return; } } - assert(false); + g_assert_not_reached(); } static void evt_conn_handler(EventNotifier *notifier) @@ -237,7 +237,7 @@ static void evt_conn_destroy(HypervTestDev *dev, uint8_t conn_id) return; } } - assert(false); + g_assert_not_reached(); } static uint64_t hv_test_dev_read(void *opaque, hwaddr addr, unsigned size) diff --git a/hw/hyperv/vmbus.c b/hw/hyperv/vmbus.c index 15e0d600c7f..03f415bf226 100644 --- a/hw/hyperv/vmbus.c +++ b/hw/hyperv/vmbus.c @@ -1874,7 +1874,7 @@ static void send_create_gpadl(VMBus *vmbus) } } - assert(false); + g_assert_not_reached(); } static bool complete_create_gpadl(VMBus *vmbus) @@ -1889,7 +1889,7 @@ static bool complete_create_gpadl(VMBus *vmbus) } } - assert(false); + g_assert_not_reached(); return false; } @@ -1931,7 +1931,7 @@ static void send_teardown_gpadl(VMBus *vmbus) } } - assert(false); + g_assert_not_reached(); } static bool complete_teardown_gpadl(VMBus *vmbus) @@ -1946,7 +1946,7 @@ static bool complete_teardown_gpadl(VMBus *vmbus) } } - assert(false); + g_assert_not_reached(); return false; } @@ -1996,7 +1996,7 @@ static void send_open_channel(VMBus *vmbus) } } - assert(false); + g_assert_not_reached(); } static bool complete_open_channel(VMBus *vmbus) @@ -2020,7 +2020,7 @@ static bool complete_open_channel(VMBus *vmbus) } } - assert(false); + g_assert_not_reached(); return false; }