| Message ID | 20240923062820.319308-3-nrb@linux.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | s390x: add tests for diag258 | expand |
On Mon, 23 Sep 2024 08:26:04 +0200 Nico Boehr <nrb@linux.ibm.com> wrote: > struct lowcore is defined in arch_def.h and LC_SIZE is useful to other > tests as well, therefore move it to arch_def.h. > > Signed-off-by: Nico Boehr <nrb@linux.ibm.com> I find this patch a little weird here, since it's not used for the previous patch, and doesn't seem to have anything to do with it either. the patch itself is otherwise good, I'm just a little puzzled. nonetheless: Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com> > --- > lib/s390x/asm/arch_def.h | 1 + > s390x/edat.c | 1 - > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/s390x/asm/arch_def.h b/lib/s390x/asm/arch_def.h > index 745a33878de5..5574a45156a9 100644 > --- a/lib/s390x/asm/arch_def.h > +++ b/lib/s390x/asm/arch_def.h > @@ -119,6 +119,7 @@ enum address_space { > > #define CTL2_GUARDED_STORAGE (63 - 59) > > +#define LC_SIZE (2 * PAGE_SIZE) > struct lowcore { > uint8_t pad_0x0000[0x0080 - 0x0000]; /* 0x0000 */ > uint32_t ext_int_param; /* 0x0080 */ > diff --git a/s390x/edat.c b/s390x/edat.c > index 16138397017c..e664b09d9633 100644 > --- a/s390x/edat.c > +++ b/s390x/edat.c > @@ -17,7 +17,6 @@ > > #define PGD_PAGE_SHIFT (REGION1_SHIFT - PAGE_SHIFT) > > -#define LC_SIZE (2 * PAGE_SIZE) > #define VIRT(x) ((void *)((unsigned long)(x) + (unsigned long)mem)) > > static uint8_t prefix_buf[LC_SIZE] __attribute__((aligned(LC_SIZE)));
diff --git a/lib/s390x/asm/arch_def.h b/lib/s390x/asm/arch_def.h index 745a33878de5..5574a45156a9 100644 --- a/lib/s390x/asm/arch_def.h +++ b/lib/s390x/asm/arch_def.h @@ -119,6 +119,7 @@ enum address_space { #define CTL2_GUARDED_STORAGE (63 - 59) +#define LC_SIZE (2 * PAGE_SIZE) struct lowcore { uint8_t pad_0x0000[0x0080 - 0x0000]; /* 0x0000 */ uint32_t ext_int_param; /* 0x0080 */ diff --git a/s390x/edat.c b/s390x/edat.c index 16138397017c..e664b09d9633 100644 --- a/s390x/edat.c +++ b/s390x/edat.c @@ -17,7 +17,6 @@ #define PGD_PAGE_SHIFT (REGION1_SHIFT - PAGE_SHIFT) -#define LC_SIZE (2 * PAGE_SIZE) #define VIRT(x) ((void *)((unsigned long)(x) + (unsigned long)mem)) static uint8_t prefix_buf[LC_SIZE] __attribute__((aligned(LC_SIZE)));
struct lowcore is defined in arch_def.h and LC_SIZE is useful to other tests as well, therefore move it to arch_def.h. Signed-off-by: Nico Boehr <nrb@linux.ibm.com> --- lib/s390x/asm/arch_def.h | 1 + s390x/edat.c | 1 - 2 files changed, 1 insertion(+), 1 deletion(-)