| Message ID | 20241206093312.57588-5-liulongfang@huawei.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | bugfix some driver issues | expand |
On Fri, Dec 06, 2024 at 05:33:11PM +0800, Longfang Liu wrote: > In a live migration scenario. If the number of VFs at the > destination is greater than the source, the recovery operation > will fail and qemu will not be able to complete the process and > exit after shutting down the device FD. > > This will cause the driver to be unable to be unloaded normally due > to abnormal reference counting of the live migration driver caused > by the abnormal closing operation of fd. > > Signed-off-by: Longfang Liu <liulongfang@huawei.com> > --- > drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c | 1 + > 1 file changed, 1 insertion(+) This one needs a fixes line and probably cc stable Jason
On 2024/12/9 21:49, Jason Gunthorpe wrote: > On Fri, Dec 06, 2024 at 05:33:11PM +0800, Longfang Liu wrote: >> In a live migration scenario. If the number of VFs at the >> destination is greater than the source, the recovery operation >> will fail and qemu will not be able to complete the process and >> exit after shutting down the device FD. >> >> This will cause the driver to be unable to be unloaded normally due >> to abnormal reference counting of the live migration driver caused >> by the abnormal closing operation of fd. >> >> Signed-off-by: Longfang Liu <liulongfang@huawei.com> >> --- >> drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c | 1 + >> 1 file changed, 1 insertion(+) > > This one needs a fixes line and probably cc stable > OK. Thanks. Longfang > Jason > > . >
diff --git a/drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c b/drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c index c057c0e24693..8d9e07ebf4fd 100644 --- a/drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c +++ b/drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c @@ -1501,6 +1501,7 @@ static void hisi_acc_vfio_pci_close_device(struct vfio_device *core_vdev) struct hisi_acc_vf_core_device *hisi_acc_vdev = hisi_acc_get_vf_dev(core_vdev); struct hisi_qm *vf_qm = &hisi_acc_vdev->vf_qm; + hisi_acc_vf_disable_fds(hisi_acc_vdev); mutex_lock(&hisi_acc_vdev->open_mutex); hisi_acc_vdev->dev_opened = false; iounmap(vf_qm->io_base);
In a live migration scenario. If the number of VFs at the destination is greater than the source, the recovery operation will fail and qemu will not be able to complete the process and exit after shutting down the device FD. This will cause the driver to be unable to be unloaded normally due to abnormal reference counting of the live migration driver caused by the abnormal closing operation of fd. Signed-off-by: Longfang Liu <liulongfang@huawei.com> --- drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c | 1 + 1 file changed, 1 insertion(+)