From patchwork Wed Jan 22 00:13:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Loughlin X-Patchwork-Id: 13946716 Received: from mail-il1-f202.google.com (mail-il1-f202.google.com [209.85.166.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39D9114AA9 for ; Wed, 22 Jan 2025 00:14:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737504856; cv=none; b=QDuLEEwYQWJIbTZpny6AyeK01IuGP90mNndT+6KBELbf7z76ryCmWpPxWGWjf6+w22ezZpZDoqGcDKoCNkjUgMMXlofcUMlHRXrtyCEMQoVZtSfLke7nkuG5UkEduOWwmgR2gF8ZRK1Ocm78+Q11YvAnVAJiNjLTRA6rMdhx5IU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737504856; c=relaxed/simple; bh=yPf27K03/uVqqrLt0hh23/xHA+vw8UXWLwpu1KmsK20=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Ee2uXqypgmG7NQeuEl+kAM4hYyti0+5oh7M/Khy9Hj6qO6iwPyjMk827gSD9/jPFw4MWyWy12DQL67F0kHHhF7trs0u2uOpEEzLUOBqu2xQIPvejj3/kGMZ2bZVjjXGZKdgfvWuHCujIVG7iG3Pmzm4QPfDmxA82lpdKtpCEzTs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--kevinloughlin.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Mz/txDfB; arc=none smtp.client-ip=209.85.166.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--kevinloughlin.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Mz/txDfB" Received: by mail-il1-f202.google.com with SMTP id e9e14a558f8ab-3cfb11f46a5so7347435ab.2 for ; Tue, 21 Jan 2025 16:14:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1737504854; x=1738109654; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=o1kWLqC/0VVh3Ec7HiMF8h2C2kgo4gHLLUGbm+ZaoH4=; b=Mz/txDfBCfH3IfImCF+OCNlvZD4Oktau31dKrcg6QN1E/MOQiUdkBwL7TOSzntGWe+ OO3mJLhxfXvYgwZj+8N3hTNidNNhN3F0qkP9gzuijKBNHydyYsrgE2Prhm0VtpwrferM 0Zq9Hy4BGydH61MtDmNAnAYS17rfArYDWe6M2TfXUL9AhT/B4H1DtWs3UNhXqzcfYb8J Q3hsR/X1FFS7X8s4dpJdeibndmdQR+0kl2RotDGiA9kWAYXRMrYJh8r8QCBFy7Q3Uwmw 0UZgdHovTOS8pNZigXYLR8aFTEA+wV3+X7zUi6IOzteTQZ0MHfw9da80/lVUctaMA3P5 6VmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737504854; x=1738109654; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=o1kWLqC/0VVh3Ec7HiMF8h2C2kgo4gHLLUGbm+ZaoH4=; b=mIQm1U4IUbwjWU4pWaPM5P9kcfpJ+XrcCBw9dBidKmZa9U5z4Q1T+lpW4nLdg84Qlq Q90+hG9JcOHXhRSIF2ZRQB3/OSrnHIyDPh1FFJrjwQF5CNVqTO9qZnvC+Gl0xArAKJLU d4qVY6/6S1gPx9hzQTnwP4VRySLgL3yGqhfuPgMm8/yE65qr/ExmVKkgzgJWdyFav68i euB3NdeIDNYNOHhZFMfbhOTCKkPMvqBYpZ7COWehTwdkrgnEtDSUihHHSHZSpZy02g7N L4BzJJHZAbL1jBj9nfLj7HRT9TWhQjDzhzYvrUZ61UyXBnOW3pAwAFhSBD7x9qrZtq42 iDSA== X-Forwarded-Encrypted: i=1; AJvYcCU3GEHc4Z+gRRx25M9e4Fj5ZuShjqYKupZqJZlrPve6JhgOnw/E71R6QxN+s+njeHqTIBw=@vger.kernel.org X-Gm-Message-State: AOJu0YyZvc3J4Jw2TZ4UqUFqzhs+0deuShA7sOrqOjsNWbuRb/5pHPzv CSmtphMPnTOh0QXHE1kCMkRSnklgGZek8vaFjvCgZrqaFg0in9CpK/hwAn4PV98QNHfPjgHc8QS XGYRlJJJfaJCHqjOUI8rhjDgVqPtnDA== X-Google-Smtp-Source: AGHT+IG305xU5CD0b2jVDKdRvmBdRl1YZXRs3dTwFnmSMf0/bvpcEMobbX1Bp+YetUiisp6N5NyrhFzXMOPYd/tSNjeP X-Received: from ilbcr4.prod.google.com ([2002:a05:6e02:3a84:b0:3ce:8579:c1eb]) (user=kevinloughlin job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6e02:1789:b0:3ce:8e89:90c2 with SMTP id e9e14a558f8ab-3cf7443c362mr158017415ab.13.1737504854292; Tue, 21 Jan 2025 16:14:14 -0800 (PST) Date: Wed, 22 Jan 2025 00:13:29 +0000 In-Reply-To: <20250122001329.647970-1-kevinloughlin@google.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250109225533.1841097-1-kevinloughlin@google.com> <20250122001329.647970-1-kevinloughlin@google.com> X-Mailer: git-send-email 2.48.1.262.g85cc9f2d1e-goog Message-ID: <20250122001329.647970-3-kevinloughlin@google.com> Subject: [PATCH v3 2/2] KVM: SEV: Prefer WBNOINVD over WBINVD for cache maintenance efficiency From: Kevin Loughlin To: linux-kernel@vger.kernel.org Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, seanjc@google.com, pbonzini@redhat.com, kevinloughlin@google.com, kirill.shutemov@linux.intel.com, kai.huang@intel.com, ubizjak@gmail.com, jgross@suse.com, kvm@vger.kernel.org, thomas.lendacky@amd.com, pgonda@google.com, sidtelang@google.com, mizhang@google.com, rientjes@google.com, manalinandan@google.com, szy0127@sjtu.edu.cn AMD CPUs currently execute WBINVD in the host when unregistering SEV guest memory or when deactivating SEV guests. Such cache maintenance is performed to prevent data corruption, wherein the encrypted (C=1) version of a dirty cache line might otherwise only be written back after the memory is written in a different context (ex: C=0), yielding corruption. However, WBINVD is performance-costly, especially because it invalidates processor caches. Strictly-speaking, unless the SEV ASID is being recycled (meaning the SNP firmware requires the use of WBINVD prior to DF_FLUSH), the cache invalidation triggered by WBINVD is unnecessary; only the writeback is needed to prevent data corruption in remaining scenarios. To improve performance in these scenarios, use WBNOINVD when available instead of WBINVD. WBNOINVD still writes back all dirty lines (preventing host data corruption by SEV guests) but does *not* invalidate processor caches. Note that the implementation of wbnoinvd() ensures fall back to WBINVD if WBNOINVD is unavailable. In anticipation of forthcoming optimizations to limit the WBNOINVD only to physical CPUs that have executed SEV guests, place the call to wbnoinvd_on_all_cpus() in a wrapper function sev_writeback_caches(). Signed-off-by: Kevin Loughlin Reviewed-by: Mingwei Zhang --- arch/x86/kvm/svm/sev.c | 41 +++++++++++++++++++++-------------------- 1 file changed, 21 insertions(+), 20 deletions(-) diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c index fe6cc763fd51..f10f1c53345e 100644 --- a/arch/x86/kvm/svm/sev.c +++ b/arch/x86/kvm/svm/sev.c @@ -116,6 +116,7 @@ static int sev_flush_asids(unsigned int min_asid, unsigned int max_asid) */ down_write(&sev_deactivate_lock); + /* SNP firmware requires use of WBINVD for ASID recycling. */ wbinvd_on_all_cpus(); if (sev_snp_enabled) @@ -710,6 +711,16 @@ static void sev_clflush_pages(struct page *pages[], unsigned long npages) } } +static inline void sev_writeback_caches(void) +{ + /* + * Ensure that all dirty guest tagged cache entries are written back + * before releasing the pages back to the system for use. CLFLUSH will + * not do this without SME_COHERENT, so issue a WBNOINVD. + */ + wbnoinvd_on_all_cpus(); +} + static unsigned long get_num_contig_pages(unsigned long idx, struct page **inpages, unsigned long npages) { @@ -2773,12 +2784,7 @@ int sev_mem_enc_unregister_region(struct kvm *kvm, goto failed; } - /* - * Ensure that all guest tagged cache entries are flushed before - * releasing the pages back to the system for use. CLFLUSH will - * not do this, so issue a WBINVD. - */ - wbinvd_on_all_cpus(); + sev_writeback_caches(); __unregister_enc_region_locked(kvm, region); @@ -2899,12 +2905,7 @@ void sev_vm_destroy(struct kvm *kvm) return; } - /* - * Ensure that all guest tagged cache entries are flushed before - * releasing the pages back to the system for use. CLFLUSH will - * not do this, so issue a WBINVD. - */ - wbinvd_on_all_cpus(); + sev_writeback_caches(); /* * if userspace was terminated before unregistering the memory regions @@ -3126,16 +3127,16 @@ static void sev_flush_encrypted_page(struct kvm_vcpu *vcpu, void *va) /* * VM Page Flush takes a host virtual address and a guest ASID. Fall - * back to WBINVD if this faults so as not to make any problems worse + * back to WBNOINVD if this faults so as not to make any problems worse * by leaving stale encrypted data in the cache. */ if (WARN_ON_ONCE(wrmsrl_safe(MSR_AMD64_VM_PAGE_FLUSH, addr | asid))) - goto do_wbinvd; + goto do_sev_writeback_caches; return; -do_wbinvd: - wbinvd_on_all_cpus(); +do_sev_writeback_caches: + sev_writeback_caches(); } void sev_guest_memory_reclaimed(struct kvm *kvm) @@ -3144,12 +3145,12 @@ void sev_guest_memory_reclaimed(struct kvm *kvm) * With SNP+gmem, private/encrypted memory is unreachable via the * hva-based mmu notifiers, so these events are only actually * pertaining to shared pages where there is no need to perform - * the WBINVD to flush associated caches. + * the WBNOINVD to flush associated caches. */ if (!sev_guest(kvm) || sev_snp_guest(kvm)) return; - wbinvd_on_all_cpus(); + sev_writeback_caches(); } void sev_free_vcpu(struct kvm_vcpu *vcpu) @@ -3858,7 +3859,7 @@ static int __sev_snp_update_protected_guest_state(struct kvm_vcpu *vcpu) * guest-mapped page rather than the initial one allocated * by KVM in svm->sev_es.vmsa. In theory, svm->sev_es.vmsa * could be free'd and cleaned up here, but that involves - * cleanups like wbinvd_on_all_cpus() which would ideally + * cleanups like sev_writeback_caches() which would ideally * be handled during teardown rather than guest boot. * Deferring that also allows the existing logic for SEV-ES * VMSAs to be re-used with minimal SNP-specific changes. @@ -4910,7 +4911,7 @@ void sev_gmem_invalidate(kvm_pfn_t start, kvm_pfn_t end) /* * SEV-ES avoids host/guest cache coherency issues through - * WBINVD hooks issued via MMU notifiers during run-time, and + * WBNOINVD hooks issued via MMU notifiers during run-time, and * KVM's VM destroy path at shutdown. Those MMU notifier events * don't cover gmem since there is no requirement to map pages * to a HVA in order to use them for a running guest. While the