| Message ID | 20250308230917.18907-2-philmd@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | hw/vfio: Build various objects once | expand |
On 3/9/25 12:08 AM, Philippe Mathieu-Daudé wrote: > Always include necessary headers explicitly, to avoid > when refactoring unrelated ones: > > hw/vfio/common.c:1176:45: error: implicit declaration of function ‘tcg_enabled’; > 1176 | tcg_enabled() ? DIRTY_CLIENTS_ALL : > | ^~~~~~~~~~~ > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> > Reviewed-by: Richard Henderson <richard.henderson@linaro.org> > Reviewed-by: Cédric Le Goater <clg@redhat.com> Reviewed-by: Eric Auger <eric.auger@redhat.com> Eric > --- > hw/vfio/common.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/vfio/common.c b/hw/vfio/common.c > index 7a4010ef4ee..b1596b6bf64 100644 > --- a/hw/vfio/common.c > +++ b/hw/vfio/common.c > @@ -42,6 +42,7 @@ > #include "migration/misc.h" > #include "migration/blocker.h" > #include "migration/qemu-file.h" > +#include "system/tcg.h" > #include "system/tpm.h" > > VFIODeviceList vfio_device_list =
diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 7a4010ef4ee..b1596b6bf64 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -42,6 +42,7 @@ #include "migration/misc.h" #include "migration/blocker.h" #include "migration/qemu-file.h" +#include "system/tcg.h" #include "system/tpm.h" VFIODeviceList vfio_device_list =
Always include necessary headers explicitly, to avoid when refactoring unrelated ones: hw/vfio/common.c:1176:45: error: implicit declaration of function ‘tcg_enabled’; 1176 | tcg_enabled() ? DIRTY_CLIENTS_ALL : | ^~~~~~~~~~~ Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Cédric Le Goater <clg@redhat.com> --- hw/vfio/common.c | 1 + 1 file changed, 1 insertion(+)