| Message ID | 20250314154904.3946484-3-jean-philippe@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: Change the default QEMU CPU type to "max" | expand |
Hi Jean-Philippe, On 3/14/25 4:49 PM, Jean-Philippe Brucker wrote: > From: Alexandru Elisei <alexandru.elisei@arm.com> > > --arch=aarch64, intentional or not, has been supported since the initial > arm64 support, commit 39ac3f8494be ("arm64: initial drop"). However, > "aarch64" does not show up in the list of supported architectures, but > it's displayed as the default architecture if doing ./configure --help > on an arm64 machine. > > Keep everything consistent and make sure that the default value for > $arch is "arm64", but still allow --arch=aarch64, in case they are users there > that use this configuration for kvm-unit-tests. > > The help text for --arch changes from: > > --arch=ARCH architecture to compile for (aarch64). ARCH can be one of: > arm, arm64, i386, ppc64, riscv32, riscv64, s390x, x86_64 > > to: > > --arch=ARCH architecture to compile for (arm64). ARCH can be one of: > arm, arm64, i386, ppc64, riscv32, riscv64, s390x, x86_64 > > Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com> > --- > configure | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index 06532a89..dc3413fc 100755 > --- a/configure > +++ b/configure > @@ -15,8 +15,9 @@ objdump=objdump > readelf=readelf > ar=ar > addr2line=addr2line > -arch=$(uname -m | sed -e 's/i.86/i386/;s/arm64/aarch64/;s/arm.*/arm/;s/ppc64.*/ppc64/') > -host=$arch > +host=$(uname -m | sed -e 's/i.86/i386/;s/arm64/aarch64/;s/arm.*/arm/;s/ppc64.*/ppc64/') > +arch=$host > +[ "$arch" = "aarch64" ] && arch="arm64" Looks the same it done again below arch_name=$arch [ "$arch" = "aarch64" ] && arch="arm64" [ "$arch_name" = "arm64" ] && arch_name="aarch64" <--- arch_libdir=$arch maybe we could move all arch settings at the same location so that it becomes clearer? Thanks Eric > cross_prefix= > endian="" > pretty_print_stacks=yes
On 3/17/25 9:19 AM, Eric Auger wrote: > Hi Jean-Philippe, > > > On 3/14/25 4:49 PM, Jean-Philippe Brucker wrote: >> From: Alexandru Elisei <alexandru.elisei@arm.com> >> >> --arch=aarch64, intentional or not, has been supported since the initial >> arm64 support, commit 39ac3f8494be ("arm64: initial drop"). However, >> "aarch64" does not show up in the list of supported architectures, but >> it's displayed as the default architecture if doing ./configure --help >> on an arm64 machine. >> >> Keep everything consistent and make sure that the default value for >> $arch is "arm64", but still allow --arch=aarch64, in case they are users > there >> that use this configuration for kvm-unit-tests. >> >> The help text for --arch changes from: >> >> --arch=ARCH architecture to compile for (aarch64). ARCH can be one of: >> arm, arm64, i386, ppc64, riscv32, riscv64, s390x, x86_64 >> >> to: >> >> --arch=ARCH architecture to compile for (arm64). ARCH can be one of: >> arm, arm64, i386, ppc64, riscv32, riscv64, s390x, x86_64 >> >> Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com> >> --- >> configure | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/configure b/configure >> index 06532a89..dc3413fc 100755 >> --- a/configure >> +++ b/configure >> @@ -15,8 +15,9 @@ objdump=objdump >> readelf=readelf >> ar=ar >> addr2line=addr2line >> -arch=$(uname -m | sed -e 's/i.86/i386/;s/arm64/aarch64/;s/arm.*/arm/;s/ppc64.*/ppc64/') >> -host=$arch >> +host=$(uname -m | sed -e 's/i.86/i386/;s/arm64/aarch64/;s/arm.*/arm/;s/ppc64.*/ppc64/') >> +arch=$host >> +[ "$arch" = "aarch64" ] && arch="arm64" > Looks the same it done again below Ignore this. This is done again after explicit arch setting :-/ Need another coffee So looks good to me Reviewed-by: Eric Auger <eric.auger@redhat.com> Eric > > arch_name=$arch > [ "$arch" = "aarch64" ] && arch="arm64" > [ "$arch_name" = "arm64" ] && arch_name="aarch64" <--- > arch_libdir=$arch > > maybe we could move all arch settings at the same location so that it > becomes clearer? > > Thanks > > Eric > >> cross_prefix= >> endian="" >> pretty_print_stacks=yes >
On Fri, Mar 14, 2025 at 03:49:01PM +0000, Jean-Philippe Brucker wrote: > From: Alexandru Elisei <alexandru.elisei@arm.com> > > --arch=aarch64, intentional or not, has been supported since the initial > arm64 support, commit 39ac3f8494be ("arm64: initial drop"). However, > "aarch64" does not show up in the list of supported architectures, but > it's displayed as the default architecture if doing ./configure --help > on an arm64 machine. > > Keep everything consistent and make sure that the default value for > $arch is "arm64", but still allow --arch=aarch64, in case they are users > that use this configuration for kvm-unit-tests. > > The help text for --arch changes from: > > --arch=ARCH architecture to compile for (aarch64). ARCH can be one of: > arm, arm64, i386, ppc64, riscv32, riscv64, s390x, x86_64 > > to: > > --arch=ARCH architecture to compile for (arm64). ARCH can be one of: > arm, arm64, i386, ppc64, riscv32, riscv64, s390x, x86_64 > > Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com> > --- > configure | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index 06532a89..dc3413fc 100755 > --- a/configure > +++ b/configure > @@ -15,8 +15,9 @@ objdump=objdump > readelf=readelf > ar=ar > addr2line=addr2line > -arch=$(uname -m | sed -e 's/i.86/i386/;s/arm64/aarch64/;s/arm.*/arm/;s/ppc64.*/ppc64/') > -host=$arch > +host=$(uname -m | sed -e 's/i.86/i386/;s/arm64/aarch64/;s/arm.*/arm/;s/ppc64.*/ppc64/') > +arch=$host > +[ "$arch" = "aarch64" ] && arch="arm64" I'd prefer we keep our block of assignments a block of assignments. We can put this at the bottom of the block, or, since the whole point of this is to make sure help text looks right, then just put it in usage() at the top. Thanks, drew > cross_prefix= > endian="" > pretty_print_stacks=yes > -- > 2.48.1 > > > -- > kvm-riscv mailing list > kvm-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kvm-riscv
On Mon, Mar 17, 2025 at 09:27:32AM +0100, Eric Auger wrote: > > > On 3/17/25 9:19 AM, Eric Auger wrote: > > Hi Jean-Philippe, > > > > > > On 3/14/25 4:49 PM, Jean-Philippe Brucker wrote: > >> From: Alexandru Elisei <alexandru.elisei@arm.com> > >> > >> --arch=aarch64, intentional or not, has been supported since the initial > >> arm64 support, commit 39ac3f8494be ("arm64: initial drop"). However, > >> "aarch64" does not show up in the list of supported architectures, but > >> it's displayed as the default architecture if doing ./configure --help > >> on an arm64 machine. > >> > >> Keep everything consistent and make sure that the default value for > >> $arch is "arm64", but still allow --arch=aarch64, in case they are users > > there > >> that use this configuration for kvm-unit-tests. > >> > >> The help text for --arch changes from: > >> > >> --arch=ARCH architecture to compile for (aarch64). ARCH can be one of: > >> arm, arm64, i386, ppc64, riscv32, riscv64, s390x, x86_64 > >> > >> to: > >> > >> --arch=ARCH architecture to compile for (arm64). ARCH can be one of: > >> arm, arm64, i386, ppc64, riscv32, riscv64, s390x, x86_64 > >> > >> Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com> > >> --- > >> configure | 5 +++-- > >> 1 file changed, 3 insertions(+), 2 deletions(-) > >> > >> diff --git a/configure b/configure > >> index 06532a89..dc3413fc 100755 > >> --- a/configure > >> +++ b/configure > >> @@ -15,8 +15,9 @@ objdump=objdump > >> readelf=readelf > >> ar=ar > >> addr2line=addr2line > >> -arch=$(uname -m | sed -e 's/i.86/i386/;s/arm64/aarch64/;s/arm.*/arm/;s/ppc64.*/ppc64/') > >> -host=$arch > >> +host=$(uname -m | sed -e 's/i.86/i386/;s/arm64/aarch64/;s/arm.*/arm/;s/ppc64.*/ppc64/') > >> +arch=$host > >> +[ "$arch" = "aarch64" ] && arch="arm64" > > Looks the same it done again below > > Ignore this. This is done again after explicit arch setting :-/ Need > another coffee > > So looks good to me > Reviewed-by: Eric Auger <eric.auger@redhat.com> Thanks for the review! Jean
diff --git a/configure b/configure index 06532a89..dc3413fc 100755 --- a/configure +++ b/configure @@ -15,8 +15,9 @@ objdump=objdump readelf=readelf ar=ar addr2line=addr2line -arch=$(uname -m | sed -e 's/i.86/i386/;s/arm64/aarch64/;s/arm.*/arm/;s/ppc64.*/ppc64/') -host=$arch +host=$(uname -m | sed -e 's/i.86/i386/;s/arm64/aarch64/;s/arm.*/arm/;s/ppc64.*/ppc64/') +arch=$host +[ "$arch" = "aarch64" ] && arch="arm64" cross_prefix= endian="" pretty_print_stacks=yes