| Message ID | 20250318045125.759259-2-pierrick.bouvier@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | single-binary: start make hw/arm/ common (boot.c) | expand |
On 3/17/25 21:51, Pierrick Bouvier wrote: > This identifier is already poisoned, so it can't be used from common > code anyway. > > Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> > --- > include/exec/cpu-all.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) I'll give you a Reviewed-by: Richard Henderson <richard.henderson@linaro.org> because it's quick and correct. However, there are only 8 actual uses within the entire tree (discounting comments), and all could be replaced by > +# if HOST_BIG_ENDIAN != TARGET_BIG_ENDIAN r~
On 3/18/25 14:41, Richard Henderson wrote: > On 3/17/25 21:51, Pierrick Bouvier wrote: >> This identifier is already poisoned, so it can't be used from common >> code anyway. >> >> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> >> --- >> include/exec/cpu-all.h | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) > > I'll give you a > Reviewed-by: Richard Henderson <richard.henderson@linaro.org> > > because it's quick and correct. However, there are only 8 actual uses within the entire > tree (discounting comments), and all could be replaced by > I hesitated to do it and get rid of BSWAP_NEEDED completely, so I'll do the replace. >> +# if HOST_BIG_ENDIAN != TARGET_BIG_ENDIAN > > > r~
diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h index 902ca1f3c7b..6dd71eb0de9 100644 --- a/include/exec/cpu-all.h +++ b/include/exec/cpu-all.h @@ -34,8 +34,10 @@ * TARGET_BIG_ENDIAN : same for the target cpu */ -#if HOST_BIG_ENDIAN != TARGET_BIG_ENDIAN -#define BSWAP_NEEDED +#ifdef COMPILING_PER_TARGET +# if HOST_BIG_ENDIAN != TARGET_BIG_ENDIAN +# define BSWAP_NEEDED +# endif #endif /* page related stuff */
This identifier is already poisoned, so it can't be used from common code anyway. Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> --- include/exec/cpu-all.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)