diff mbox series

[01/67] KVM: SVM: Allocate IR data using atomic allocation

Message ID	20250404193923.1413163-2-seanjc@google.com (mailing list archive)
State	New
Headers	show Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2F4A21D581 for <kvm@vger.kernel.org>; Fri, 4 Apr 2025 19:39:49 +0000 (UTC) Reply-To: Sean Christopherson <seanjc@google.com> Date: Fri, 4 Apr 2025 12:38:16 -0700 In-Reply-To: <20250404193923.1413163-1-seanjc@google.com> Precedence: bulk Mime-Version: 1.0 References: <20250404193923.1413163-1-seanjc@google.com> Message-ID: <20250404193923.1413163-2-seanjc@google.com> Subject: [PATCH 01/67] KVM: SVM: Allocate IR data using atomic allocation From: Sean Christopherson <seanjc@google.com> To: Sean Christopherson <seanjc@google.com>, Paolo Bonzini <pbonzini@redhat.com>, Joerg Roedel <joro@8bytes.org>, David Woodhouse <dwmw2@infradead.org>, Lu Baolu <baolu.lu@linux.intel.com> Cc: kvm@vger.kernel.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Maxim Levitsky <mlevitsk@redhat.com>, Joao Martins <joao.m.martins@oracle.com>, David Matlack <dmatlack@google.com> Content-Type: text/plain; charset="UTF-8"
Series	KVM: iommu: Overhaul device posted IRQs support \| expand [00/67] KVM: iommu: Overhaul device posted IRQs support [01/67] KVM: SVM: Allocate IR data using atomic allocation [02/67] KVM: x86: Reset IRTE to host control if new route isn't postable [03/67] KVM: x86: Explicitly treat routing entry type changes as changes [04/67] KVM: x86: Take irqfds.lock when adding/deleting IRQ bypass producer [05/67] iommu/amd: Return an error if vCPU affinity is set for non-vCPU IRTE [06/67] iommu/amd: WARN if KVM attempts to set vCPU affinity without posted intrrupts [07/67] KVM: SVM: WARN if an invalid posted interrupt IRTE entry is added [08/67] KVM: x86: Pass new routing entries and irqfd when updating IRTEs [09/67] KVM: SVM: Track per-vCPU IRTEs using kvm_kernel_irqfd structure [10/67] KVM: SVM: Delete IRTE link from previous vCPU before setting new IRTE [11/67] KVM: SVM: Delete IRTE link from previous vCPU irrespective of new routing [12/67] KVM: SVM: Drop pointless masking of default APIC base when setting V_APIC_BAR [13/67] KVM: SVM: Drop pointless masking of kernel page pa's with AVIC HPA masks [14/67] KVM: SVM: Add helper to deduplicate code for getting AVIC backing page [15/67] KVM: SVM: Drop vcpu_svm's pointless avic_backing_page field [16/67] KVM: SVM: Inhibit AVIC if ID is too big instead of rejecting vCPU creation [17/67] KVM: SVM: Drop redundant check in AVIC code on ID during vCPU creation [18/67] KVM: SVM: Track AVIC tables as natively sized pointers, not "struct pages" [19/67] KVM: SVM: Drop superfluous "cache" of AVIC Physical ID entry pointer [20/67] KVM: VMX: Move enable_ipiv knob to common x86 [21/67] KVM: SVM: Add enable_ipiv param, never set IsRunning if disabled [22/67] KVM: SVM: Disable (x2)AVIC IPI virtualization if CPU has erratum #1235 [23/67] KVM: VMX: Suppress PI notifications whenever the vCPU is put [24/67] KVM: SVM: Add a comment to explain why avic_vcpu_blocking() ignores IRQ blocking [25/67] iommu/amd: KVM: SVM: Use pi_desc_addr to derive ga_root_ptr [26/67] iommu/amd: KVM: SVM: Delete now-unused cached/previous GA tag fields [27/67] iommu/amd: KVM: SVM: Pass NULL @vcpu_info to indicate "not guest mode" [28/67] KVM: SVM: Get vCPU info for IRTE using new routing entry [29/67] KVM: SVM: Stop walking list of routing table entries when updating IRTE [30/67] KVM: VMX: Stop walking list of routing table entries when updating IRTE [31/67] KVM: SVM: Extract SVM specific code out of get_pi_vcpu_info() [32/67] KVM: x86: Nullify irqfd->producer after updating IRTEs [33/67] KVM: x86: Dedup AVIC vs. PI code for identifying target vCPU [34/67] KVM: x86: Move posted interrupt tracepoint to common code [35/67] KVM: SVM: Clean up return handling in avic_pi_update_irte() [36/67] iommu: KVM: Split "struct vcpu_data" into separate AMD vs. Intel structs [37/67] KVM: Don't WARN if updating IRQ bypass route fails [38/67] KVM: Fold kvm_arch_irqfd_route_changed() into kvm_arch_update_irqfd_routing() [39/67] KVM: x86: Track irq_bypass_vcpu in common x86 code [40/67] KVM: x86: Skip IOMMU IRTE updates if there's no old or new vCPU being targeted [41/67] KVM: x86: Don't update IRTE entries when old and new routes were !MSI [42/67] KVM: SVM: Revert IRTE to legacy mode if IOMMU doesn't provide IR metadata [43/67] KVM: SVM: Take and hold ir_list_lock across IRTE updates in IOMMU [44/67] iommu/amd: KVM: SVM: Infer IsRun from validity of pCPU destination [45/67] iommu/amd: Factor out helper for manipulating IRTE GA/CPU info [46/67] iommu/amd: KVM: SVM: Set pCPU info in IRTE when setting vCPU affinity [47/67] iommu/amd: KVM: SVM: Add IRTE metadata to affined vCPU's list if AVIC is inhibited [48/67] KVM: SVM: Don't check for assigned device(s) when updating affinity [49/67] KVM: SVM: Don't check for assigned device(s) when activating AVIC [50/67] KVM: SVM: WARN if (de)activating guest mode in IOMMU fails [51/67] KVM: SVM: Process all IRTEs on affinity change even if one update fails [52/67] KVM: SVM: WARN if updating IRTE GA fields in IOMMU fails [53/67] KVM: x86: Drop superfluous "has assigned device" check in kvm_pi_update_irte() [54/67] KVM: x86: WARN if IRQ bypass isn't supported in kvm_pi_update_irte() [55/67] KVM: x86: WARN if IRQ bypass routing is updated without in-kernel local APIC [56/67] KVM: SVM: WARN if ir_list is non-empty at vCPU free [57/67] KVM: x86: Decouple device assignment from IRQ bypass [58/67] KVM: VMX: WARN if VT-d Posted IRQs aren't possible when starting IRQ bypass [59/67] KVM: SVM: Use vcpu_idx, not vcpu_id, for GA log tag/metadata [60/67] iommu/amd: WARN if KVM calls GA IRTE helpers without virtual APIC support [61/67] KVM: SVM: Fold avic_set_pi_irte_mode() into its sole caller [62/67] KVM: SVM: Don't check vCPU's blocking status when toggling AVIC on/off [63/67] KVM: SVM: Consolidate IRTE update when toggling AVIC on/off [64/67] iommu/amd: KVM: SVM: Allow KVM to control need for GA log interrupts [65/67] KVM: SVM: Generate GA log IRQs only if the associated vCPUs is blocking [66/67] * DO NOT MERGE * iommu/amd: Hack to fake IRQ posting support [67/67] * DO NOT MERGE * KVM: selftests: WIP posted interrupts test

Commit Message

Sean Christopherson April 4, 2025, 7:38 p.m. UTC

Allocate SVM's interrupt remapping metadata using GFP_ATOMIC as
svm_ir_list_add() is called with IRQs are disabled and irqfs.lock held
when kvm_irq_routing_update() reacts to GSI routing changes.

Fixes: 411b44ba80ab ("svm: Implements update_pi_irte hook to setup posted interrupt")
Cc: stable@vger.kernel.org
Signed-off-by: Sean Christopherson <seanjc@google.com>
---
 arch/x86/kvm/svm/avic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

Patch

diff --git a/arch/x86/kvm/svm/avic.c b/arch/x86/kvm/svm/avic.c
index 901d8d2dc169..a961e6e67050 100644
--- a/arch/x86/kvm/svm/avic.c
+++ b/arch/x86/kvm/svm/avic.c
@@ -820,7 +820,7 @@  static int svm_ir_list_add(struct vcpu_svm *svm, struct amd_iommu_pi_data *pi)
 	 * Allocating new amd_iommu_pi_data, which will get
 	 * add to the per-vcpu ir_list.
 	 */
-	ir = kzalloc(sizeof(struct amd_svm_iommu_ir), GFP_KERNEL_ACCOUNT);
+	ir = kzalloc(sizeof(struct amd_svm_iommu_ir), GFP_ATOMIC | __GFP_ACCOUNT);
 	if (!ir) {
 		ret = -ENOMEM;
 		goto out;