diff mbox

[kvm-unit-tests,v7,03/13] pci: Add 'extern' to public function declarations

Message ID 2a9fe06d195e139e0fecaf990ef2c2a8a579a15f.1471434672.git.agordeev@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Alexander Gordeev Aug. 17, 2016, 12:07 p.m. UTC 
Cc: Thomas Huth <thuth@redhat.com>
Cc: Andrew Jones <drjones@redhat.com>
Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
---
 lib/pci.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Andrew Jones Aug. 17, 2016, 1:49 p.m. UTC | #1 
On Wed, Aug 17, 2016 at 02:07:04PM +0200, Alexander Gordeev wrote:
> Cc: Thomas Huth <thuth@redhat.com>
> Cc: Andrew Jones <drjones@redhat.com>
> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> ---
>  lib/pci.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Andrew Jones <drjones@redhat.com>

> 
> diff --git a/lib/pci.h b/lib/pci.h
> index 54fbf22d634a..066fac77b237 100644
> --- a/lib/pci.h
> +++ b/lib/pci.h
> @@ -15,10 +15,10 @@ enum {
>  	PCIDEVADDR_INVALID = 0xffff,
>  };
>  
> -pcidevaddr_t pci_find_dev(uint16_t vendor_id, uint16_t device_id);
> -unsigned long pci_bar_addr(pcidevaddr_t dev, int bar_num);
> -bool pci_bar_is_memory(pcidevaddr_t dev, int bar_num);
> -bool pci_bar_is_valid(pcidevaddr_t dev, int bar_num);
> +extern pcidevaddr_t pci_find_dev(uint16_t vendor_id, uint16_t device_id);
> +extern unsigned long pci_bar_addr(pcidevaddr_t dev, int bar_num);
> +extern bool pci_bar_is_memory(pcidevaddr_t dev, int bar_num);
> +extern bool pci_bar_is_valid(pcidevaddr_t dev, int bar_num);
>  
>  /*
>   * pci-testdev is a driver for the pci-testdev qemu pci device. The
> -- 
> 1.8.3.1
> 
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/lib/pci.h b/lib/pci.h
index 54fbf22d634a..066fac77b237 100644
--- a/lib/pci.h
+++ b/lib/pci.h
@@ -15,10 +15,10 @@  enum {
 	PCIDEVADDR_INVALID = 0xffff,
 };
 
-pcidevaddr_t pci_find_dev(uint16_t vendor_id, uint16_t device_id);
-unsigned long pci_bar_addr(pcidevaddr_t dev, int bar_num);
-bool pci_bar_is_memory(pcidevaddr_t dev, int bar_num);
-bool pci_bar_is_valid(pcidevaddr_t dev, int bar_num);
+extern pcidevaddr_t pci_find_dev(uint16_t vendor_id, uint16_t device_id);
+extern unsigned long pci_bar_addr(pcidevaddr_t dev, int bar_num);
+extern bool pci_bar_is_memory(pcidevaddr_t dev, int bar_num);
+extern bool pci_bar_is_valid(pcidevaddr_t dev, int bar_num);
 
 /*
  * pci-testdev is a driver for the pci-testdev qemu pci device. The