diff mbox series

[-next] s390/protvirt: fix error return code in uv_info_init()

Message ID 2f7d62a4-3e75-b2b4-951b-75ef8ef59d16@huawei.com (mailing list archive)
State New
Headers show
Series [-next] s390/protvirt: fix error return code in uv_info_init() | expand

Commit Message

zhongbaisong April 7, 2021, 12:38 p.m. UTC
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Baisong Zhong <zhongbaisong@huawei.com>
---
  arch/s390/kernel/uv.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Wei Yongjun April 7, 2021, 12:45 p.m. UTC | #1
格式不对,不要用outlook发

在 2021/4/7 20:38, zhongbaisong 写道:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Baisong Zhong <zhongbaisong@huawei.com>
> ---
>  arch/s390/kernel/uv.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/s390/kernel/uv.c b/arch/s390/kernel/uv.c
> index cbfbeab57c3b..370f664580af 100644
> --- a/arch/s390/kernel/uv.c
> +++ b/arch/s390/kernel/uv.c
> @@ -460,8 +460,10 @@ static int __init uv_info_init(void)
>          goto out_kobj;
>
>      uv_query_kset = kset_create_and_add("query", NULL, uv_kobj);
> -    if (!uv_query_kset)
> +    if (!uv_query_kset) {
> +        rc = -ENOMEM;
>          goto out_ind_files;
> +    }
>
>      rc = sysfs_create_group(&uv_query_kset->kobj, &uv_query_attr_group);
>      if (!rc)
>
Wei Yongjun April 7, 2021, 12:48 p.m. UTC | #2
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Baisong Zhong <zhongbaisong@huawei.com>
> ---
>  arch/s390/kernel/uv.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/s390/kernel/uv.c b/arch/s390/kernel/uv.c
> index cbfbeab57c3b..370f664580af 100644
> --- a/arch/s390/kernel/uv.c
> +++ b/arch/s390/kernel/uv.c
> @@ -460,8 +460,10 @@ static int __init uv_info_init(void)
>          goto out_kobj;
>
>      uv_query_kset = kset_create_and_add("query", NULL, uv_kobj);
> -    if (!uv_query_kset)
> +    if (!uv_query_kset) {
> +        rc = -ENOMEM;
>          goto out_ind_files;
> +    }


Your patch is corrupted, please resend with correct format.


>
>      rc = sysfs_create_group(&uv_query_kset->kobj, &uv_query_attr_group);
>      if (!rc)
>
Heiko Carstens April 7, 2021, 1:06 p.m. UTC | #3
On Wed, Apr 07, 2021 at 08:48:19PM +0800, weiyongjun (A) wrote:
> > Fix to return a negative error code from the error handling
> > case instead of 0, as done elsewhere in this function.
> > 
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Baisong Zhong <zhongbaisong@huawei.com>
> > ---
> >  arch/s390/kernel/uv.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/s390/kernel/uv.c b/arch/s390/kernel/uv.c
> > index cbfbeab57c3b..370f664580af 100644
> > --- a/arch/s390/kernel/uv.c
> > +++ b/arch/s390/kernel/uv.c
> > @@ -460,8 +460,10 @@ static int __init uv_info_init(void)
> >          goto out_kobj;
> > 
> >      uv_query_kset = kset_create_and_add("query", NULL, uv_kobj);
> > -    if (!uv_query_kset)
> > +    if (!uv_query_kset) {
> > +        rc = -ENOMEM;
> >          goto out_ind_files;
> > +    }
> 
> Your patch is corrupted, please resend with correct format.

Fixed up, and applied anyway. Thanks.
Dan Carpenter April 13, 2021, 2:15 p.m. UTC | #4
On Wed, Apr 07, 2021 at 08:38:55PM +0800, zhongbaisong wrote:
                                          ^^^^^^^^^^^^

Heiko Carstens already fixed and applied the patch but it's best to fix
this From line so it says "Baisong Zhong" like your Signed-off-by line.

regards,
dan carpenter
diff mbox series

Patch

diff --git a/arch/s390/kernel/uv.c b/arch/s390/kernel/uv.c
index cbfbeab57c3b..370f664580af 100644
--- a/arch/s390/kernel/uv.c
+++ b/arch/s390/kernel/uv.c
@@ -460,8 +460,10 @@  static int __init uv_info_init(void)
  		goto out_kobj;

  	uv_query_kset = kset_create_and_add("query", NULL, uv_kobj);
-	if (!uv_query_kset)
+	if (!uv_query_kset) {
+		rc = -ENOMEM;
  		goto out_ind_files;
+	}

  	rc = sysfs_create_group(&uv_query_kset->kobj, &uv_query_attr_group);
  	if (!rc)