From patchwork Sat Apr 23 10:05:34 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 728971 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p3NA5unM011441 for ; Sat, 23 Apr 2011 10:05:57 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752778Ab1DWKFl (ORCPT ); Sat, 23 Apr 2011 06:05:41 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:60366 "EHLO fmmailgate01.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751223Ab1DWKFl (ORCPT ); Sat, 23 Apr 2011 06:05:41 -0400 Received: from smtp05.web.de ( [172.20.4.166]) by fmmailgate01.web.de (Postfix) with ESMTP id AB26218C816C8; Sat, 23 Apr 2011 12:05:39 +0200 (CEST) Received: from [88.64.17.9] (helo=localhost.localdomain) by smtp05.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.110 #2) id 1QDZid-0003aW-01; Sat, 23 Apr 2011 12:05:39 +0200 From: Jan Kiszka To: Avi Kivity , Marcelo Tosatti Cc: kvm@vger.kernel.org, Alex Williamson Subject: [PATCH 2/3] qemu-kvm: pci-assign: Remove dead code from assigned_dev_iomem_map Date: Sat, 23 Apr 2011 12:05:34 +0200 Message-Id: <428886b04273d68e0a2cc402be1ff6fa15241c73.1303553132.git.jan.kiszka@web.de> X-Mailer: git-send-email 1.7.1 In-Reply-To: References: In-Reply-To: References: X-Sender: jan.kiszka@web.de X-Provags-ID: V01U2FsdGVkX1+akIjRfcdDWt0PeFlgKcsIOTftM1KoQHhKqS4c HKWkO33dVyoSNR7Zxw11TI+JXuCRufrAjpCNcXVtU/Uokl+QRk fnHdz4xkg= Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Sat, 23 Apr 2011 10:05:57 +0000 (UTC) From: Jan Kiszka ret is only set to 0 and then left untouched. Signed-off-by: Jan Kiszka --- hw/device-assignment.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/hw/device-assignment.c b/hw/device-assignment.c index 50a7485..8a7cfcf 100644 --- a/hw/device-assignment.c +++ b/hw/device-assignment.c @@ -273,7 +273,6 @@ static void assigned_dev_iomem_map(PCIDevice *pci_dev, int region_num, AssignedDevice *r_dev = DO_UPCAST(AssignedDevice, dev, pci_dev); AssignedDevRegion *region = &r_dev->v_addrs[region_num]; PCIRegion *real_region = &r_dev->real_device.regions[region_num]; - int ret = 0; DEBUG("e_phys=%08" FMT_PCIBUS " r_virt=%p type=%d len=%08" FMT_PCIBUS " region_num=%d \n", e_phys, region->u.r_virtbase, type, e_size, region_num); @@ -294,11 +293,6 @@ static void assigned_dev_iomem_map(PCIDevice *pci_dev, int region_num, TARGET_PAGE_SIZE, r_dev->mmio_index); } } - - if (ret != 0) { - fprintf(stderr, "%s: Error: create new mapping failed\n", __func__); - exit(1); - } } static void assigned_dev_ioport_map(PCIDevice *pci_dev, int region_num,