From patchwork Tue Mar 31 15:00:32 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Theurer X-Patchwork-Id: 15395 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n2VF0seF009652 for ; Tue, 31 Mar 2009 15:00:54 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760793AbZCaPAx (ORCPT ); Tue, 31 Mar 2009 11:00:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760641AbZCaPAx (ORCPT ); Tue, 31 Mar 2009 11:00:53 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:42632 "EHLO e9.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758826AbZCaPAw (ORCPT ); Tue, 31 Mar 2009 11:00:52 -0400 Received: from d01relay06.pok.ibm.com (d01relay06.pok.ibm.com [9.56.227.116]) by e9.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n2VEpKIB027907 for ; Tue, 31 Mar 2009 10:51:20 -0400 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n2VF0huV3432514 for ; Tue, 31 Mar 2009 11:00:43 -0400 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n2VF0Xkq028277 for ; Tue, 31 Mar 2009 09:00:33 -0600 Received: from twinturbo.austin.ibm.com (twinturbo.austin.ibm.com [9.41.41.35]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n2VF0XH4028157 for ; Tue, 31 Mar 2009 09:00:33 -0600 Message-ID: <49D23010.9010408@linux.vnet.ibm.com> Date: Tue, 31 Mar 2009 10:00:32 -0500 From: Andrew Theurer User-Agent: Thunderbird 2.0.0.18 (X11/20081119) MIME-Version: 1.0 To: kvm@vger.kernel.org Subject: EPT support breakage on: KVM: VMX: Zero ept module parameter if ept is not present Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org I cannot get EPT support to work on commit: 21f65ab2c582594a69dcb1484afa9f88b3414b4f KVM: VMX: Zero ept module parameter if ept is not present I see tons of pf_guest from kvm_stat, where as the previous commit has none. I am using "ept=1" module option for kvm-intel. This is on Nehalem processors. -Andrew commit diff: min |= VM_EXIT_HOST_ADDR_SPACE_SIZE; --- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 8b1b9b8..96a19f8 100644 (file) --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -265,7 +265,7 @@ static inline int cpu_has_vmx_ept(void) static inline int vm_need_ept(void) { - return (cpu_has_vmx_ept() && enable_ept); + return enable_ept; } static inline int vm_need_virtualize_apic_accesses(struct kvm *kvm) @@ -1205,6 +1205,9 @@ static __init int setup_vmcs_config(struct vmcs_config *vmcs_conf) if (!cpu_has_vmx_vpid()) enable_vpid = 0; + if (!cpu_has_vmx_ept()) + enable_ept = 0; + min = 0; #ifdef CONFIG_X86_64