From patchwork Thu May  7 09:26:42 2009
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Avi Kivity <avi@redhat.com>
X-Patchwork-Id: 22280
Received: from vger.kernel.org (vger.kernel.org [209.132.176.167])
	by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n479TFIh025875
	for <patchwork-kvm@patchwork.kernel.org>; Thu, 7 May 2009 09:29:15 GMT
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932119AbZEGJ0s (ORCPT
	<rfc822;patchwork-kvm@patchwork.kernel.org>);
	Thu, 7 May 2009 05:26:48 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932130AbZEGJ0s
	(ORCPT <rfc822;kvm-outgoing>); Thu, 7 May 2009 05:26:48 -0400
Received: from mx2.redhat.com ([66.187.237.31]:36821 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1761010AbZEGJ0q (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 7 May 2009 05:26:46 -0400
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com
	[172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n479QkFp017948;
	Thu, 7 May 2009 05:26:46 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])
	by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id
	n479QjS7007754; Thu, 7 May 2009 05:26:45 -0400
Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com
	[10.35.255.11])
	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n479Qhkn020696;
	Thu, 7 May 2009 05:26:44 -0400
Received: from balrog.qumranet.com (dhcp-1-197.tlv.redhat.com [10.35.1.197])
	by cleopatra.tlv.redhat.com (Postfix) with ESMTP id A0605250061;
	Thu,  7 May 2009 12:26:42 +0300 (IDT)
Message-ID: <4A02A952.60204@redhat.com>
Date: Thu, 07 May 2009 12:26:42 +0300
From: Avi Kivity <avi@redhat.com>
User-Agent: Thunderbird 2.0.0.21 (X11/20090320)
MIME-Version: 1.0
To: Jes Sorensen <jes@sgi.com>
CC: "kvm-ia64@vger.kernel.org" <kvm-ia64@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [patch] fix - do not build blobs when blobs are not needed
References: <4A02A1BA.5020003@sgi.com>
In-Reply-To: <4A02A1BA.5020003@sgi.com>
X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26
Sender: kvm-owner@vger.kernel.org
Precedence: bulk
List-ID: <kvm.vger.kernel.org>
X-Mailing-List: kvm@vger.kernel.org

Jes Sorensen wrote:
> Hi,
>
> Don't like ugly assembler errors because QEMU tries to build some x86
> assembly code which isn't needed on non-x86.

 .PHONY: kvm/extboot
 
+ifdef INSTALL_BLOBS
 all: kvm/extboot
 
 kvm/extboot:
@@ -427,3 +428,4 @@
            || ! cmp -s pc-bios/extboot.bin $@/extboot.bin; then \
 		cp $@/extboot.bin pc-bios/extboot.bin; \
 	fi
+endif


Seems a bit heavy handed.  blobs != extboot.

How about instead:

    build-targets-x86 = kvm/extboot

    all: $(build-targets-$(ARCH))

(or something similar that builds)

Index: qemu-kvm/configure
===================================================================
--- qemu-kvm.orig/configure
+++ qemu-kvm/configure
@@ -356,6 +356,7 @@
      cpu_emulation="no"
      gdbstub="no"
      slirp="no"
+     blobs="no"
 fi
 if [ "$cpu" = "powerpc" ]; then
      kvm="yes"