From patchwork Thu May 7 09:35:57 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jes Sorensen X-Patchwork-Id: 22293 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n479aqvs026509 for ; Thu, 7 May 2009 09:36:52 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752193AbZEGJgJ (ORCPT ); Thu, 7 May 2009 05:36:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756077AbZEGJgG (ORCPT ); Thu, 7 May 2009 05:36:06 -0400 Received: from relay1.sgi.com ([192.48.179.29]:46236 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756660AbZEGJgE (ORCPT ); Thu, 7 May 2009 05:36:04 -0400 Received: from eye3.emea.sgi.com (eye3.emea.sgi.com [144.253.156.24]) by relay1.corp.sgi.com (Postfix) with ESMTP id 705FA8F808E; Thu, 7 May 2009 02:36:01 -0700 (PDT) Message-ID: <4A02AB7D.5000509@sgi.com> Date: Thu, 07 May 2009 11:35:57 +0200 From: Jes Sorensen User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Avi Kivity CC: "kvm-ia64@vger.kernel.org" , "kvm@vger.kernel.org" Subject: Re: [patch] fix - do not build blobs when blobs are not needed References: <4A02A1BA.5020003@sgi.com> <4A02A952.60204@redhat.com> In-Reply-To: <4A02A952.60204@redhat.com> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Avi Kivity wrote: > Seems a bit heavy handed. blobs != extboot. > > How about instead: > > build-targets-x86 = kvm/extboot > > all: $(build-targets-$(ARCH)) > > (or something similar that builds) There's no problem that cannot be fixed by applying an appropriately large hammer .... :-) This one works for me. Jes Do not try to build extboot on non-x86. Signed-off-by: Jes Sorensen --- Makefile | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) Index: qemu-kvm/Makefile =================================================================== --- qemu-kvm.orig/Makefile +++ qemu-kvm/Makefile @@ -419,7 +419,10 @@ .PHONY: kvm/extboot -all: kvm/extboot +build-targets-x86 = kvm/extboot +build-targets-ia64 = + +all: $(build-targets-$(ARCH)) kvm/extboot: $(MAKE) -C $@