| Message ID | 4A02D539.6040705@sgi.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Jes Sorensen wrote: > Avi Kivity wrote: >> I agree, unless >> >> - we want to make gdbstub support configurable (don't see any >> overwhelming reason for this, but maybe others do) >> - we want to merge ia64 kvm support upstream, and don't want to impose >> gdbstub support (though I'd recommend properly implementing gdbstub) >> >> In any case, I'm okay with dropping the check upstream and applying >> the local fixup. > > Hi, > > Here's a patch that fixes the #ifndef to make it the #ifdef as it was > intended. > > I am quite fine with us trying to drop all the #ifdefs and introduce > noop wrappers for archs that do not provide the gdbstubs (ie. ia64), but > to start with we better just fix the #ifndef to make it behave like it > was originally intended. As the original change this patch (correctly) fixes broke gdbstub support in qemu-kvm for all archs + it is still a deviation from upstream, please take the chance and go for ia64 stubs. BTW, I'm planning to submit a cleanup patch for CONFIG_GDBSTUB to upstream soon. Jan
Jan Kiszka wrote: > As the original change this patch (correctly) fixes broke gdbstub > support in qemu-kvm for all archs + it is still a deviation from > upstream, please take the chance and go for ia64 stubs. Jan, There's far more to do in upstream than just gdbstubs for ia64 to be usable :-( We'll get to gdbstubs at some point, but there's too many other higher priority items to deal with first. Cheers, Jes -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Jes Sorensen wrote: > Jan Kiszka wrote: >> As the original change this patch (correctly) fixes broke gdbstub >> support in qemu-kvm for all archs + it is still a deviation from >> upstream, please take the chance and go for ia64 stubs. > > Jan, > > There's far more to do in upstream than just gdbstubs for ia64 to be > usable :-( > > We'll get to gdbstubs at some point, but there's too many other higher > priority items to deal with first. I'm not asking for full gdbstub support at this point, just for a build workaround at arch-level (or in arch-specific blocks, in gdbstub.c e.g.) instead of patching generic code with global risk of regressions. Jan
Jan Kiszka wrote: > I'm not asking for full gdbstub support at this point, just for a build > workaround at arch-level (or in arch-specific blocks, in gdbstub.c e.g.) > instead of patching generic code with global risk of regressions. Oh, I see. I already submitted that to Avi, making gdb_set_stop_cpu() a noop on ia64. Since there's no target-ia64/ directory in mainline qemu.git yet, that fix will have to live in qemu-kvm for the time being. I am fine if you wish to remove all the #ifdef CONFIG_GDBSTUB bits. Cheers, Jes -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Fix incorrect #ifndef for CONFIG_GETSTUB, which should have been an #ifdef. Signed-off-by: Jes Sorensen <jes@sgi.com> --- vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: qemu/vl.c =================================================================== --- qemu.orig/vl.c +++ qemu/vl.c @@ -4350,7 +4350,7 @@ } if (cpu_can_run(env)) ret = qemu_cpu_exec(env); -#ifndef CONFIG_GDBSTUB +#ifdef CONFIG_GDBSTUB if (ret == EXCP_DEBUG) { gdb_set_stop_cpu(env); debug_requested = 1;